From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1191D2E645 for ; Sat, 27 Jan 2024 20:28:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706387315; cv=none; b=GtVuM9/hSb/Vkequ+DcDQcLclP08viMWK+Hgwthlyuc1IT+X2CLW+Or4LHGrpc/RNUizQtwN8KMcP5+JN2XPHuYVXVAdU0sww/lCL/nSFc0xC3gg+5ueuEfIPYwqkreyGfiOJ/NbZN/dibpiCh4F/yhPoEWwXBALL8cQqoUOfNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706387315; c=relaxed/simple; bh=LUBeGALBzMiCBd9c1SReM0q1tcU5b9jqGILvsbgJMIY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=SWJ4VIu0XRacarVkyF9VyV2qjfhy0ZueFnX4PU/Zyqt5jP8Ft/q1IUwcnltHIqDZA9yrA140ZkWj7YYT1zVeFgfWTK2lqkeRis143vp0RZ4OffEXshRIlWiEtqgG7HkRxaGzVTz3359d/WGtU07K1l6Suc6CKdTp/stRl1Yb9rI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iwanders.net; spf=pass smtp.mailfrom=iwanders.net; dkim=pass (1024-bit key) header.d=iwanders.net header.i=@iwanders.net header.b=cPiUlOQC; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iwanders.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iwanders.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=iwanders.net header.i=@iwanders.net header.b="cPiUlOQC" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-42a7aa96669so17179371cf.3 for ; Sat, 27 Jan 2024 12:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iwanders.net; s=google; t=1706387312; x=1706992112; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=LUBeGALBzMiCBd9c1SReM0q1tcU5b9jqGILvsbgJMIY=; b=cPiUlOQCphIO0s9NPenE2RFlAlyb8S/K+R4BYa5wtGhyJBvb2gRqVjjR8CnNDunySp Xbh8vGeIFcowaaGMk7FGDYGfMGysPL9EXx+tCaH8yBW7Utj96SM82gxSduB5Z3B8CUc5 cjcvlVDGKD1h85A82xGLxgStlA5Srwy6Bs08E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706387312; x=1706992112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LUBeGALBzMiCBd9c1SReM0q1tcU5b9jqGILvsbgJMIY=; b=WqLA21I155FaPi114MmdeRFuNohQHjz62pFZUSNbvEIEhZ1D3HbgjMXHPLsAndBp+z hCVl/KxBJL6C2Q3WavR5mrcR/SqSEgSyOXpc3LJ5bLwPi8eMcWZQ6n850Lw+/smyEdAp DpCLJWLkHYsmaqKTg65yvp1FNOduGfYwti/IcXlRKCcCrTYMePe7Fhkd7A24BImVcvAc o+jz+L89IcDspm32tDzaTdPNuOMa14CZFy3H44q2NnFWI/iBTrytrreGVethH3r54Wv4 GfW66IjjGnrraBQZGgvQNnYwfWJOJHevf2MKj+D2TPjsD/0D/m4jM8A0pW5v0XcaaI1h i1Mg== X-Gm-Message-State: AOJu0Yz+F9UTinb6syiNnwF22Kb5n6x07o+hQFu/Mgpq1ELDjtSRlTov TBlRUMf9MRr05SaIy9WhTcZvOKnCxjf/BI8ymX7zk4Xy9TdmupeqR58RcztsDrM= X-Google-Smtp-Source: AGHT+IG6s/fHhjP8Qd7QpYh+6hTN6Y01lcMsE9p4qdH9PvkO5SB3bp0d/yDNa1i7yrGjeQoZV0xYSQ== X-Received: by 2002:a05:620a:22c6:b0:783:949f:cbe2 with SMTP id o6-20020a05620a22c600b00783949fcbe2mr2208737qki.150.1706387312664; Sat, 27 Jan 2024 12:28:32 -0800 (PST) Received: from eagle.lan (24-246-30-234.cable.teksavvy.com. [24.246.30.234]) by smtp.gmail.com with ESMTPSA id b7-20020a05620a270700b00783e18e45desm868815qkp.104.2024.01.27.12.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Jan 2024 12:28:32 -0800 (PST) From: Ivor Wanders To: w_armin@gmx.de Cc: corbet@lwn.net, hdegoede@redhat.com, ivor@iwanders.net, jdelvare@suse.com, linux-doc@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux@roeck-us.net, luzmaximilian@gmail.com, markgross@kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v3 2/2] hwmon: add fan speed monitoring driver for Surface devices Date: Sat, 27 Jan 2024 15:28:28 -0500 Message-Id: <20240127202828.11140-1-ivor@iwanders.net> X-Mailer: git-send-email 2.17.1 In-Reply-To: <34960bb8-fb85-4cca-8b84-d99596d046e4@gmx.de> References: <34960bb8-fb85-4cca-8b84-d99596d046e4@gmx.de> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Hello Armin, thank you for your second review. > maybe you can just return 0 here. Good idea, that's indeed the only option for ret, so that makes it clearer. > Maybe use PTR_ERR_OR_ZERO() here? Definitely, thanks for suggesting this; cleans it up nicely. ~Ivor