From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35A45535DE for ; Tue, 19 Mar 2024 07:01:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710831678; cv=none; b=nDUHqXZKEr5o77ZAI3yKAuIbil+YZV+oZBKJy/VgZujuTYmmOIr6URLQixKOY02nXlXvkfunpXhrbsXtZnyAkOEd28u2tbhQ1ixsdJDUUND3Wa97ELw/Rn3DO9/rMaHcujSKPUQbGkhOWMNfqspkUcv1gGuT4XpNNnXGUekf9/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710831678; c=relaxed/simple; bh=+0yGzgO/uZDZuFmdyu9d+sc45NfVqM4uTrSkkmcuopU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bmcDonmLq1kwBfvFB85c6hvWqeEPGSc0d2TZmeZbNyRPakwXdnhtWSGoUp/rpg/quHPwzQtSiFlnR33RsutEvIvThvGkAmezlOh/s6eaJnYqrMnvR+a5BNUmmL/PP2m0DsedQGHfVvQ7vZEPAikjzHS/Wh+aWCRORkQQS7ihWwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PVYED9Di; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PVYED9Di" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710831676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=foUSQQGmYmOu8nLXi1AjlC9r9SGWzmdXWf6sigKcUWw=; b=PVYED9DiLa+C/i24h0zT2ZiUPqGClHCZeVmIU07c18eUxfJE1ON7FNctj6lJSXIcfredb1 RcuMQgHVqD6S0A8ScF+bQ0hc4IcHnBU7YDn7eoh4WbUtQkuSTZCEHO924POKqBGPl7222o 0dIH+MgRdpAWbpWfdLfrVr1eQBYNyF8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-42y_0G1eOD-M0B05tcUqWA-1; Tue, 19 Mar 2024 03:01:10 -0400 X-MC-Unique: 42y_0G1eOD-M0B05tcUqWA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-33eca6f6e4bso2730975f8f.0 for ; Tue, 19 Mar 2024 00:01:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710831669; x=1711436469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=foUSQQGmYmOu8nLXi1AjlC9r9SGWzmdXWf6sigKcUWw=; b=C23B9gJyRttHWa1FYJI82DhpLd4nMImtVS/7PhsFvCdYwD5/GjWENOu7p1rEGKozV0 pUUPU+Dgu4DbbAVmhKgh9wU8U2zH67GwSypw/OQxS0YnrrpwytZrlUfT1IuTZQrCUdZH +IY88HTA0mPtR4Kdm1x+h1YEOG8zHY3cuy/ZceiRr6oj9uVUJz/sP+NYYPYRL0aSJgJG 81R5PJ9TymczYKE1mI+kOwuOCx0X3wYw7KAGkAgWcoOe7xvBpD4xIA/RBytX81+Q/++Q rw4bn4kVeje7xelBOrQ4ASp9NT/TWlCAJnapAp2qvKlKUxlIIZszZschuRxXYfP/65qk HQ0A== X-Forwarded-Encrypted: i=1; AJvYcCVoK4uabRSTmuniJbJsoP3FsPOQrz0ew9PtF9pOtVJfqKO7PlbrG4mB1SjNXtvLOgQM6UQ2T7FCyl8nSB8XNCNvWe1S6sqiNDQ+H9V9hf7Pbt+xew== X-Gm-Message-State: AOJu0YyKhK6/9yETxF9i8Dm8n3qMo4XA5qyYH9o2iA+ywp3+x+gxSKxV XlFG9wwJCPTNNhfmyQscZuNPxaLNj7DYMm84a/DJ9BXO3RDUROI4Ds/0vHFZAxwiSlyVge2A896 PKRU42mc7dCTes30ADQLG3KXa9+psUbVG6dd/VB2mB+dqXWtyfeZO7dkntmpwBN5lU7ekMBw= X-Received: by 2002:a05:600c:4f0e:b0:413:ef8e:4cc with SMTP id l14-20020a05600c4f0e00b00413ef8e04ccmr1095509wmq.40.1710831669526; Tue, 19 Mar 2024 00:01:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzg6YzD09DcsuSp1mTE4kCrxMGUWI9Lm91o60NEdPSVsYEnPJ0jVjqFhsmb8yxRUdsUTgvyQ== X-Received: by 2002:a05:600c:4f0e:b0:413:ef8e:4cc with SMTP id l14-20020a05600c4f0e00b00413ef8e04ccmr1095470wmq.40.1710831668946; Tue, 19 Mar 2024 00:01:08 -0700 (PDT) Received: from redhat.com ([2.52.6.254]) by smtp.gmail.com with ESMTPSA id fk10-20020a05600c0cca00b0041463334822sm1536373wmb.26.2024.03.19.00.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 00:01:08 -0700 (PDT) Date: Tue, 19 Mar 2024 03:01:02 -0400 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: virtualization@lists.linux.dev, Richard Weinberger , Anton Ivanov , Johannes Berg , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Jason Wang , linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH vhost v3 0/4] refactor the params of find_vqs() Message-ID: <20240319025933-mutt-send-email-mst@kernel.org> References: <20240312021013.88656-1-xuanzhuo@linux.alibaba.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240312021013.88656-1-xuanzhuo@linux.alibaba.com> On Tue, Mar 12, 2024 at 10:10:09AM +0800, Xuan Zhuo wrote: > This pathset is splited from the > > http://lore.kernel.org/all/20240229072044.77388-1-xuanzhuo@linux.alibaba.com > > That may needs some cycles to discuss. But that notifies too many people. > > But just the four commits need to notify so many people. > And four commits are independent. So I split that patch set, > let us review these first. > > The patch set try to refactor the params of find_vqs(). > Then we can just change the structure, when introducing new > features. > > Thanks. > > v3: > 1. fix the bug: "assignment of read-only location '*cfg.names'" > > v2: > 1. add kerneldoc for "struct vq_transport_config" @ilpo.jarvinen > > v1: > 1. fix some comments from ilpo.jarvinen@linux.intel.com > As this came in after merge window was open I'm deferring this to the next merge window. Jason, can you pls try to complete the review meanwhile? > > Xuan Zhuo (4): > virtio: find_vqs: pass struct instead of multi parameters > virtio: vring_create_virtqueue: pass struct instead of multi > parameters > virtio: vring_new_virtqueue(): pass struct instead of multi parameters > virtio_ring: simplify the parameters of the funcs related to > vring_create/new_virtqueue() > > arch/um/drivers/virtio_uml.c | 31 ++-- > drivers/platform/mellanox/mlxbf-tmfifo.c | 24 ++-- > drivers/remoteproc/remoteproc_virtio.c | 31 ++-- > drivers/s390/virtio/virtio_ccw.c | 33 ++--- > drivers/virtio/virtio_mmio.c | 30 ++-- > drivers/virtio/virtio_pci_common.c | 60 ++++---- > drivers/virtio/virtio_pci_common.h | 9 +- > drivers/virtio/virtio_pci_legacy.c | 16 ++- > drivers/virtio/virtio_pci_modern.c | 38 +++-- > drivers/virtio/virtio_ring.c | 173 ++++++++--------------- > drivers/virtio/virtio_vdpa.c | 45 +++--- > include/linux/virtio_config.h | 85 ++++++++--- > include/linux/virtio_ring.h | 93 +++++++----- > tools/virtio/virtio_test.c | 4 +- > tools/virtio/vringh_test.c | 28 ++-- > 15 files changed, 363 insertions(+), 337 deletions(-) > > -- > 2.32.0.3.g01195cf9f