From: "Luke D. Jones" <luke@ljones.dev>
To: platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com, corentin.chary@gmail.com,
"Luke D. Jones" <luke@ljones.dev>
Subject: [PATCH v3 0/5] platform/x86: introduce asus-armoury driver
Date: Wed, 18 Sep 2024 21:42:45 +1200 [thread overview]
Message-ID: <20240918094250.82430-1-luke@ljones.dev> (raw)
This is the first major patch I've ever done with the intention of
introducing a new module, so it's highly likely I've made some mistakes
or misunderstood something.
TL;DR:
1. introduce new module to contain bios attributes, using fw_attributes_class
2. deprecate all possible attributes from asus-wmi that were added ad-hoc
3. remove those in the next LTS cycle
The idea for this originates from a conversation with Mario Limonciello
https://lore.kernel.org/platform-driver-x86/371d4109-a3bb-4c3b-802f-4ec27a945c99@amd.com/
It is without a doubt much cleaner to use, easier to discover, and the
API is well defined as opposed to the random clutter of attributes I had
been placing in the platform sysfs.
I am unsure of how best to handle the deprecation of attributes.
There's also some attributes that are obviously boolean but are using 0/1.
I'm unsure if I should change that.
And would it be best to move the asus stuff to a subdir now? Akin to the
Dell platform stuff.
Regards,
Luke
Changelog:
- v1
- Initial submission
- v2
- Too many changes to list, but all concerns raised in previous submission addressed.
- History: https://lore.kernel.org/platform-driver-x86/20240716051612.64842-1-luke@ljones.dev/
- v3
- All concerns addressed.
- History: https://lore.kernel.org/platform-driver-x86/20240806020747.365042-1-luke@ljones.dev/
Luke D. Jones (5):
platform/x86: asus-armoury: move existing tunings to asus-armoury
module
platform/x86: asus-armoury: add dgpu tgp control
platform/x86: asus-armoury: add apu-mem control support
platform/x86: asus-armoury: add core count control
platform/x86: asus-wmi: deprecate bios features
.../ABI/testing/sysfs-platform-asus-wmi | 17 +
drivers/platform/x86/Kconfig | 22 +
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/asus-armoury.c | 1056 +++++++++++++++++
drivers/platform/x86/asus-armoury.h | 255 ++++
drivers/platform/x86/asus-wmi.c | 203 +++-
drivers/platform/x86/asus-wmi.h | 14 +
include/linux/platform_data/x86/asus-wmi.h | 19 +
8 files changed, 1538 insertions(+), 49 deletions(-)
create mode 100644 drivers/platform/x86/asus-armoury.c
create mode 100644 drivers/platform/x86/asus-armoury.h
--
2.46.1
next reply other threads:[~2024-09-18 9:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 9:42 Luke D. Jones [this message]
2024-09-18 9:42 ` [PATCH v3 1/5] platform/x86: asus-armoury: move existing tunings to asus-armoury module Luke D. Jones
2024-09-18 15:37 ` Mario Limonciello
2024-09-20 7:27 ` Luke Jones
2024-09-21 7:13 ` Christophe JAILLET
2024-09-21 9:49 ` Luke Jones
2024-09-21 17:48 ` kernel test robot
2024-09-21 20:12 ` kernel test robot
2024-09-22 1:33 ` kernel test robot
2024-09-18 9:42 ` [PATCH v3 2/5] platform/x86: asus-armoury: add dgpu tgp control Luke D. Jones
2024-09-18 15:39 ` Mario Limonciello
2024-09-21 6:57 ` Luke Jones
2024-09-18 9:42 ` [PATCH v3 3/5] platform/x86: asus-armoury: add apu-mem control support Luke D. Jones
2024-09-18 15:44 ` Mario Limonciello
2024-09-21 7:05 ` Luke Jones
2024-09-18 9:42 ` [PATCH v3 4/5] platform/x86: asus-armoury: add core count control Luke D. Jones
2024-09-18 9:42 ` [PATCH v3 5/5] platform/x86: asus-wmi: deprecate bios features Luke D. Jones
2024-09-18 15:50 ` Mario Limonciello
2024-09-21 6:27 ` Luke Jones
-- strict thread matches above, loose matches on Subject: below --
2024-09-29 9:08 [PATCH v3 0/5] platform/x86: introduce asus-armoury driver Luke D. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240918094250.82430-1-luke@ljones.dev \
--to=luke@ljones.dev \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox