X86 platform drivers
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: "Daniel Scally" <djrscally@gmail.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 1/1] platform/x86: int3472: Call "reset" GPIO "enable" for INT347E
Date: Mon, 20 Jan 2025 12:17:43 +0200	[thread overview]
Message-ID: <20250120101743.149169-1-sakari.ailus@linux.intel.com> (raw)

The DT bindings for ov7251 specify "enable" GPIO (xshutdown in
documentation) but the int3472 indiscriminately provides this as a "reset"
GPIO to sensor drivers. Take this into account by assigning it as "enable"
with active high polarity for INT347E devices, i.e. ov7251.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
since v1:

- Fixed device name string.

 drivers/platform/x86/intel/int3472/discrete.c | 45 ++++++++++++++++---
 1 file changed, 40 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
index d881b2cfcdfc..6404ef1eb4a7 100644
--- a/drivers/platform/x86/intel/int3472/discrete.c
+++ b/drivers/platform/x86/intel/int3472/discrete.c
@@ -122,13 +122,47 @@ skl_int3472_gpiod_get_from_temp_lookup(struct int3472_discrete_device *int3472,
 	return desc;
 }
 
-static void int3472_get_func_and_polarity(u8 type, const char **func, u32 *polarity)
+/**
+ * struct int3472_reset_gpio_map - Map "reset" GPIO to whatever is expected by
+ * the sensor driver (as in DT bindings)
+ * @devname: The name of the device without the instance number e.g. i2c-INT347E
+ * @func: The function, e.g. "enable"
+ * @polarity: GPIO_ACTIVE_{HIGH,LOW}
+ */
+static const struct int3472_reset_gpio_map {
+	const char *devname;
+	const char *func;
+	unsigned int polarity;
+} int3472_reset_gpio_map[] = {
+	{ "i2c-INT347E", "enable", GPIO_ACTIVE_HIGH },
+};
+
+static void int3472_get_func_and_polarity(const char *sensor_name, u8 type,
+					  const char **func, u32 *polarity)
 {
 	switch (type) {
-	case INT3472_GPIO_TYPE_RESET:
-		*func = "reset";
-		*polarity = GPIO_ACTIVE_LOW;
+	case INT3472_GPIO_TYPE_RESET: {
+		const struct int3472_reset_gpio_map *map = NULL;
+		unsigned int i;
+
+		for (i = 0; i < ARRAY_SIZE(int3472_reset_gpio_map); i++) {
+			if (strncmp(sensor_name, int3472_reset_gpio_map[i].devname,
+				    strlen(int3472_reset_gpio_map[i].devname)))
+				continue;
+
+			map = &int3472_reset_gpio_map[i];
+			break;
+		}
+
+		if (map) {
+			*func = map->func;
+			*polarity = map->polarity;
+		} else {
+			*func = "reset";
+			*polarity = GPIO_ACTIVE_LOW;
+		}
 		break;
+	}
 	case INT3472_GPIO_TYPE_POWERDOWN:
 		*func = "powerdown";
 		*polarity = GPIO_ACTIVE_LOW;
@@ -217,7 +251,8 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,
 
 	type = FIELD_GET(INT3472_GPIO_DSM_TYPE, obj->integer.value);
 
-	int3472_get_func_and_polarity(type, &func, &polarity);
+	int3472_get_func_and_polarity(int3472->sensor_name, type, &func,
+				      &polarity);
 
 	pin = FIELD_GET(INT3472_GPIO_DSM_PIN, obj->integer.value);
 	if (pin != agpio->pin_table[0])
-- 
2.39.5


             reply	other threads:[~2025-01-20 10:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20 10:17 Sakari Ailus [this message]
2025-01-20 12:12 ` [PATCH v2 1/1] platform/x86: int3472: Call "reset" GPIO "enable" for INT347E Ilpo Järvinen
2025-01-20 13:39 ` Hans de Goede
2025-01-20 14:21   ` Sakari Ailus
2025-01-20 15:08     ` Hans de Goede
2025-01-21  8:08       ` Sakari Ailus
2025-01-21  9:19         ` Hans de Goede
2025-01-21  9:42 ` Hans de Goede
2025-01-21 11:11   ` Sakari Ailus
2025-01-21 12:35     ` Hans de Goede
2025-01-21 13:35       ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250120101743.149169-1-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=djrscally@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox