X86 platform drivers
 help / color / mirror / Atom feed
From: Kurt Borja <kuurtb@gmail.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, "Pali Rohár" <pali@kernel.org>,
	Dell.Client.Kernel@dell.com,
	"Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Kurt Borja" <kuurtb@gmail.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Subject: [PATCH] platform/x86: dell: Use *-y instead of *-objs in Makefile
Date: Fri, 14 Feb 2025 16:45:35 -0500	[thread overview]
Message-ID: <20250214214535.4947-1-kuurtb@gmail.com> (raw)

The `objs` suffix is reserved for user-space tools. Use the `y` suffix
instead, which is usually used for kernel drivers.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
Hi all,

I based this patch on top of the for-next branch.

Ilpo, if you prefer this patch to be based on top of the fixes branch,
let me know. I'd submit two separate patches, one for alienware-wmi, on
top of the for-next branch and one for the other drivers, on top of
fixes.

~ Kurt

 drivers/platform/x86/dell/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/dell/Makefile b/drivers/platform/x86/dell/Makefile
index 8ac9a933c770..c7501c25e627 100644
--- a/drivers/platform/x86/dell/Makefile
+++ b/drivers/platform/x86/dell/Makefile
@@ -5,7 +5,7 @@
 #
 
 obj-$(CONFIG_ALIENWARE_WMI)			+= alienware-wmi.o
-alienware-wmi-objs				:= alienware-wmi-base.o
+alienware-wmi-y					:= alienware-wmi-base.o
 alienware-wmi-$(CONFIG_ALIENWARE_WMI_LEGACY)	+= alienware-wmi-legacy.o
 alienware-wmi-$(CONFIG_ALIENWARE_WMI_WMAX)	+= alienware-wmi-wmax.o
 obj-$(CONFIG_DCDBAS)				+= dcdbas.o
@@ -14,14 +14,14 @@ obj-$(CONFIG_DELL_RBTN)				+= dell-rbtn.o
 obj-$(CONFIG_DELL_RBU)				+= dell_rbu.o
 obj-$(CONFIG_DELL_PC)				+= dell-pc.o
 obj-$(CONFIG_DELL_SMBIOS)			+= dell-smbios.o
-dell-smbios-objs				:= dell-smbios-base.o
+dell-smbios-y					:= dell-smbios-base.o
 dell-smbios-$(CONFIG_DELL_SMBIOS_WMI)		+= dell-smbios-wmi.o
 dell-smbios-$(CONFIG_DELL_SMBIOS_SMM)		+= dell-smbios-smm.o
 obj-$(CONFIG_DELL_SMO8800)			+= dell-smo8800.o
 obj-$(CONFIG_DELL_SMO8800)			+= dell-lis3lv02d.o
 obj-$(CONFIG_DELL_UART_BACKLIGHT)		+= dell-uart-backlight.o
 obj-$(CONFIG_DELL_WMI)				+= dell-wmi.o
-dell-wmi-objs					:= dell-wmi-base.o
+dell-wmi-y					:= dell-wmi-base.o
 dell-wmi-$(CONFIG_DELL_WMI_PRIVACY)		+= dell-wmi-privacy.o
 obj-$(CONFIG_DELL_WMI_AIO)			+= dell-wmi-aio.o
 obj-$(CONFIG_DELL_WMI_DESCRIPTOR)		+= dell-wmi-descriptor.o

base-commit: d497c47481f8e8f13e3191c9a707ed942d3bb3d7
-- 
2.48.1


             reply	other threads:[~2025-02-14 21:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-14 21:45 Kurt Borja [this message]
2025-02-16 20:24 ` [PATCH] platform/x86: dell: Use *-y instead of *-objs in Makefile Andy Shevchenko
2025-02-17  8:58 ` Ilpo Järvinen
2025-02-18 19:09   ` Kurt Borja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250214214535.4947-1-kuurtb@gmail.com \
    --to=kuurtb@gmail.com \
    --cc=Dell.Client.Kernel@dell.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=pali@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox