From: kernel test robot <lkp@intel.com>
To: "Bartosz Golaszewski" <brgl@bgdev.pl>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: oe-kbuild-all@lists.linux.dev,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] platform/x86: silicom: remove unnecessary GPIO line direction check
Date: Wed, 11 Jun 2025 13:07:56 +0800 [thread overview]
Message-ID: <202506111214.mbG7aOVD-lkp@intel.com> (raw)
In-Reply-To: <20250610144935.84375-1-brgl@bgdev.pl>
Hi Bartosz,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.16-rc1 next-20250610]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bartosz-Golaszewski/platform-x86-silicom-remove-unnecessary-GPIO-line-direction-check/20250610-225049
base: linus/master
patch link: https://lore.kernel.org/r/20250610144935.84375-1-brgl%40bgdev.pl
patch subject: [PATCH] platform/x86: silicom: remove unnecessary GPIO line direction check
config: x86_64-buildonly-randconfig-001-20250611 (https://download.01.org/0day-ci/archive/20250611/202506111214.mbG7aOVD-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250611/202506111214.mbG7aOVD-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506111214.mbG7aOVD-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/platform/x86/silicom-platform.c: In function 'silicom_gpio_set':
>> drivers/platform/x86/silicom-platform.c:251:13: warning: unused variable 'direction' [-Wunused-variable]
251 | int direction = silicom_gpio_get_direction(gc, offset);
| ^~~~~~~~~
vim +/direction +251 drivers/platform/x86/silicom-platform.c
d9cd21d441c8c7 Henry Shi 2023-11-24 247
88f67f2a99f061 Bartosz Golaszewski 2025-04-08 248 static int silicom_gpio_set(struct gpio_chip *gc, unsigned int offset,
d9cd21d441c8c7 Henry Shi 2023-11-24 249 int value)
d9cd21d441c8c7 Henry Shi 2023-11-24 250 {
d9cd21d441c8c7 Henry Shi 2023-11-24 @251 int direction = silicom_gpio_get_direction(gc, offset);
d9cd21d441c8c7 Henry Shi 2023-11-24 252 u8 *channels = gpiochip_get_data(gc);
d9cd21d441c8c7 Henry Shi 2023-11-24 253 int channel = channels[offset];
d9cd21d441c8c7 Henry Shi 2023-11-24 254
890a48ca7b0540 Dan Carpenter 2024-01-12 255 silicom_mec_port_set(channel, !value);
88f67f2a99f061 Bartosz Golaszewski 2025-04-08 256
88f67f2a99f061 Bartosz Golaszewski 2025-04-08 257 return 0;
d9cd21d441c8c7 Henry Shi 2023-11-24 258 }
d9cd21d441c8c7 Henry Shi 2023-11-24 259
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2025-06-11 5:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 14:49 [PATCH] platform/x86: silicom: remove unnecessary GPIO line direction check Bartosz Golaszewski
2025-06-11 5:07 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202506111214.mbG7aOVD-lkp@intel.com \
--to=lkp@intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox