From: Hans de Goede <hansg@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>
Cc: Hans de Goede <hansg@kernel.org>,
platform-driver-x86@vger.kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: [PATCH 2/2] platform/x86: int3472: Increase ov08x40 handshake GPIO delay to 45 ms
Date: Fri, 25 Jul 2025 16:44:44 +0200 [thread overview]
Message-ID: <20250725144444.210043-3-hansg@kernel.org> (raw)
In-Reply-To: <20250725144444.210043-1-hansg@kernel.org>
On HP laptops with an ov08x40 sensor the 25 ms delay coming from Intel's
out of tree drivers is not enough. Testing has confirmed that 45 ms does
work.
Add a quirk to the int3472_gpio_map[] to increase the delay to 45 ms to fix
probing of the ov08x40 sensor failing on these laptops.
Note this only impacts laptops which actually use an ov08x40 sensor with
a handshake GPIO.
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2333331
Signed-off-by: Hans de Goede <hansg@kernel.org>
---
drivers/platform/x86/intel/int3472/discrete.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
index bc442944be7f..e7ca1d83f45a 100644
--- a/drivers/platform/x86/intel/int3472/discrete.c
+++ b/drivers/platform/x86/intel/int3472/discrete.c
@@ -149,6 +149,12 @@ static const struct int3472_gpio_map int3472_gpio_map[] = {
false, "vdd", GPIO_REGULATOR_ENABLE_TIME },
/* ov7251 driver / DT-bindings expect "enable" as con_id for reset */
{ "INT347E", INT3472_GPIO_TYPE_RESET, INT3472_GPIO_TYPE_RESET, false, "enable" },
+ /*
+ * ov08x40 sensor with a handshake pin needs a 45 ms delay on some HP laptops
+ * https://bugzilla.redhat.com/show_bug.cgi?id=2333331
+ */
+ { "OVTI08F4", INT3472_GPIO_TYPE_HANDSHAKE, INT3472_GPIO_TYPE_HANDSHAKE,
+ false, "dvdd", 45 * USEC_PER_MSEC },
};
static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3472, u8 *type,
--
2.49.0
next prev parent reply other threads:[~2025-07-25 14:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 14:44 [PATCH 0/2] platform/x86: int3472: Increase ov08x40 handshake GPIO delay to 45 ms Hans de Goede
2025-07-25 14:44 ` [PATCH 1/2] platform/x86: int3472: Rework regulator enable-time handling Hans de Goede
2025-07-25 14:49 ` Andy Shevchenko
2025-07-25 20:38 ` Hans de Goede
2025-07-25 14:44 ` Hans de Goede [this message]
2025-07-25 14:52 ` [PATCH 2/2] platform/x86: int3472: Increase ov08x40 handshake GPIO delay to 45 ms Andy Shevchenko
2025-07-25 17:47 ` Sakari Ailus
2025-07-25 20:43 ` Hans de Goede
2025-07-28 22:56 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725144444.210043-3-hansg@kernel.org \
--to=hansg@kernel.org \
--cc=andy@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).