X86 platform drivers
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Mario Limonciello (AMD)" <superm1@kernel.org>,
	"Tom Lendacky" <thomas.lendacky@amd.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Rijo Thomas" <Rijo-john.Thomas@amd.com>
Cc: oe-kbuild-all@lists.linux.dev, John Allen <john.allen@amd.com>,
	"David S . Miller" <davem@davemloft.net>,
	Hans de Goede <hansg@kernel.org>,
	"(open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER)"
	<linux-crypto@vger.kernel.org>,
	platform-driver-x86@vger.kernel.org,
	Lars Francke <lars.francke@gmail.com>,
	Yijun Shen <Yijun.Shen@dell.com>,
	"Mario Limonciello (AMD)" <superm1@kernel.org>
Subject: Re: [PATCH v4 3/5] crypto: ccp - Add an S4 restore flow
Date: Tue, 6 Jan 2026 14:42:34 +0100	[thread overview]
Message-ID: <202601061453.8zskdbs5-lkp@intel.com> (raw)
In-Reply-To: <20260106045423.55190-4-superm1@kernel.org>

Hi Mario,

kernel test robot noticed the following build warnings:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master linus/master v6.16-rc1 next-20260106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello-AMD/platform-x86-amd-pmf-Prevent-TEE-errors-after-hibernate/20260106-130236
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/20260106045423.55190-4-superm1%40kernel.org
patch subject: [PATCH v4 3/5] crypto: ccp - Add an S4 restore flow
config: x86_64-rhel-9.4-kunit (https://download.01.org/0day-ci/archive/20260106/202601061453.8zskdbs5-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260106/202601061453.8zskdbs5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601061453.8zskdbs5-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/crypto/ccp/psp-dev.c: In function 'psp_restore':
>> drivers/crypto/ccp/psp-dev.c:357:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     357 |         int ret = 0;
         |             ^~~


vim +/ret +357 drivers/crypto/ccp/psp-dev.c

   353	
   354	int psp_restore(struct sp_device *sp)
   355	{
   356		struct psp_device *psp = sp->psp_data;
 > 357		int ret = 0;
   358	
   359		if (psp->tee_data)
   360			ret = tee_restore(psp);
   361	
   362		return 0;
   363	}
   364	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2026-01-06 13:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06  4:54 [PATCH v4 0/5] Fixes for PMF and CCP drivers after S4 Mario Limonciello (AMD)
2026-01-06  4:54 ` [PATCH v4 1/5] platform/x86/amd/pmf: Prevent TEE errors after hibernate Mario Limonciello (AMD)
2026-01-06  4:54 ` [PATCH v4 2/5] crypto: ccp - Declare PSP dead if PSP_CMD_TEE_RING_INIT fails Mario Limonciello (AMD)
2026-01-06  4:54 ` [PATCH v4 3/5] crypto: ccp - Add an S4 restore flow Mario Limonciello (AMD)
2026-01-06 13:42   ` kernel test robot [this message]
2026-01-07  7:59   ` Shyam Sundar S K
2026-01-06  4:54 ` [PATCH v4 4/5] crypto: ccp - Factor out ring destroy handling to a helper Mario Limonciello (AMD)
2026-01-06  4:54 ` [PATCH v4 5/5] crypto: ccp - Send PSP_CMD_TEE_RING_DESTROY when PSP_CMD_TEE_RING_INIT fails Mario Limonciello (AMD)
2026-01-07  9:04   ` Shyam Sundar S K
2026-01-10 21:34     ` Mario Limonciello
2026-01-07 14:06 ` [PATCH v4 0/5] Fixes for PMF and CCP drivers after S4 Tom Lendacky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202601061453.8zskdbs5-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Rijo-john.Thomas@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=Yijun.Shen@dell.com \
    --cc=davem@davemloft.net \
    --cc=hansg@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=john.allen@amd.com \
    --cc=lars.francke@gmail.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=superm1@kernel.org \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox