From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: linux-rt-devel@lists.linux.dev,
"Thomas Gleixner" <tglx@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org, "Borah,
Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>
Subject: Re: [PATCH 02/21] platform/x86: int0002: Remove IRQF_ONESHOT from request_irq()
Date: Fri, 23 Jan 2026 12:49:09 +0100 [thread overview]
Message-ID: <20260123114909.BPVv_oBm@linutronix.de> (raw)
In-Reply-To: <20260123113708.416727-3-bigeasy@linutronix.de>
On 2026-01-23 12:36:48 [+0100], To linux-kernel@vger.kernel.org wrote:
> Passing IRQF_ONESHOT ensures that the interrupt source is masked until
> the secondary (threaded) handler is done. If only a primary handler is
> used then the flag makes no sense because the interrupt can not fire
> (again) while its handler is running.
> The flag also disallows force-threading of the primary handler and the
> irq-core will warn about this.
>
> The flag was added to match the flag on the shared handler which uses a
> threaded handler and therefore IRQF_ONESHOT. This is no longer needed
> because devm_request_irq() now passes IRQF_COND_ONESHOT for this case.
>
> Revert adding IRQF_ONESHOT to irqflags.
This one should probably go hand in hand with the previous one. It might
be easier to route both via tip/irq.
Sebastian
next prev parent reply other threads:[~2026-01-23 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260123113708.416727-1-bigeasy@linutronix.de>
2026-01-23 11:36 ` [PATCH 02/21] platform/x86: int0002: Remove IRQF_ONESHOT from request_irq() Sebastian Andrzej Siewior
2026-01-23 11:49 ` Sebastian Andrzej Siewior [this message]
2026-01-26 14:05 ` Ilpo Järvinen
2026-01-24 10:21 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123114909.BPVv_oBm@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=chaitanya.kumar.borah@intel.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).