[PATCH 6/7] media: i2c: st-vd55g: Remove legacy vd55g1 remnants

[Peter Marshall <pm@petermarshall.ca>]

vd55g1 is superseded by the generic vd55g driver supporting the same
hardware and feature set. Remove it.

Signed-off-by: Peter Marshall <pm@petermarshall.ca>
---
 drivers/media/i2c/Makefile |    1 -
 drivers/media/i2c/vd55g1.c | 1767 ------------------------------------
 2 files changed, 1768 deletions(-)
 delete mode 100644 drivers/media/i2c/vd55g1.c

diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
index d87b64893..b40b6020e 100644
--- a/drivers/media/i2c/Makefile
+++ b/drivers/media/i2c/Makefile
@@ -165,7 +165,6 @@ obj-$(CONFIG_VIDEO_UDA1342) += uda1342.o
 obj-$(CONFIG_VIDEO_UPD64031A) += upd64031a.o
 obj-$(CONFIG_VIDEO_UPD64083) += upd64083.o
 obj-$(CONFIG_VIDEO_VD55G) += vd55g.o
-obj-$(CONFIG_VIDEO_VD55G1) += vd55g1.o
 obj-$(CONFIG_VIDEO_VD56G3) += vd56g3.o
 obj-$(CONFIG_VIDEO_VGXY61) += vgxy61.o
 obj-$(CONFIG_VIDEO_VP27SMPX) += vp27smpx.o
diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
deleted file mode 100644
index 1ae42e448..000000000
--- a/drivers/media/i2c/vd55g1.c
+++ /dev/null
@@ -1,1767 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/*
- * Driver for VD55G1 global shutter sensor family driver
- *
- * Copyright (C) 2025 STMicroelectronics SA
- */
-
-#include <linux/clk.h>
-#include <linux/delay.h>
-#include <linux/gpio/consumer.h>
-#include <linux/i2c.h>
-#include <linux/iopoll.h>
-#include <linux/module.h>
-#include <linux/pm_runtime.h>
-#include <linux/property.h>
-#include <linux/regmap.h>
-#include <linux/regulator/consumer.h>
-#include <linux/unaligned.h>
-#include <linux/units.h>
-
-#include <media/mipi-csi2.h>
-#include <media/v4l2-async.h>
-#include <media/v4l2-cci.h>
-#include <media/v4l2-ctrls.h>
-#include <media/v4l2-device.h>
-#include <media/v4l2-event.h>
-#include <media/v4l2-fwnode.h>
-#include <media/v4l2-subdev.h>
-
-/* Register Map */
-#define VD55G1_REG_MODEL_ID				CCI_REG32_LE(0x0000)
-#define VD55G1_MODEL_ID_VD55G1				0x53354731 /* Mono */
-#define VD55G1_MODEL_ID_VD65G4				0x53354733 /* RGB */
-#define VD55G1_REG_REVISION				CCI_REG16_LE(0x0004)
-#define VD55G1_REVISION_CCB				0x2020
-#define VD55G1_REVISION_BAYER				0x3030
-#define VD55G1_REG_FWPATCH_REVISION			CCI_REG16_LE(0x0012)
-#define VD55G1_REG_FWPATCH_START_ADDR			CCI_REG8(0x2000)
-#define VD55G1_REG_SYSTEM_FSM				CCI_REG8(0x001c)
-#define VD55G1_SYSTEM_FSM_READY_TO_BOOT			0x01
-#define VD55G1_SYSTEM_FSM_SW_STBY			0x02
-#define VD55G1_SYSTEM_FSM_STREAMING			0x03
-#define VD55G1_REG_BOOT					CCI_REG8(0x0200)
-#define VD55G1_BOOT_BOOT				1
-#define VD55G1_BOOT_PATCH_AND_BOOT			2
-#define VD55G1_REG_STBY					CCI_REG8(0x0201)
-#define VD55G1_STBY_START_STREAM			1
-#define VD55G1_REG_STREAMING				CCI_REG8(0x0202)
-#define VD55G1_STREAMING_STOP_STREAM			1
-#define VD55G1_REG_EXT_CLOCK				CCI_REG32_LE(0x0220)
-#define VD55G1_REG_LINE_LENGTH				CCI_REG16_LE(0x0300)
-#define VD55G1_REG_ORIENTATION				CCI_REG8(0x0302)
-#define VD55G1_REG_FORMAT_CTRL				CCI_REG8(0x030a)
-#define VD55G1_REG_OIF_CTRL				CCI_REG16_LE(0x030c)
-#define VD55G1_REG_ISL_ENABLE				CCI_REG16_LE(0x326)
-#define VD55G1_REG_OIF_IMG_CTRL				CCI_REG8(0x030f)
-#define VD55G1_REG_MIPI_DATA_RATE			CCI_REG32_LE(0x0224)
-#define VD55G1_REG_PATGEN_CTRL				CCI_REG16_LE(0x0304)
-#define VD55G1_PATGEN_TYPE_SHIFT			4
-#define VD55G1_PATGEN_ENABLE				BIT(0)
-#define VD55G1_REG_MANUAL_ANALOG_GAIN			CCI_REG8(0x0501)
-#define VD55G1_REG_MANUAL_COARSE_EXPOSURE		CCI_REG16_LE(0x0502)
-#define VD55G1_REG_MANUAL_DIGITAL_GAIN			CCI_REG16_LE(0x0504)
-#define VD55G1_REG_APPLIED_COARSE_EXPOSURE		CCI_REG16_LE(0x00e8)
-#define VD55G1_REG_APPLIED_ANALOG_GAIN			CCI_REG16_LE(0x00ea)
-#define VD55G1_REG_APPLIED_DIGITAL_GAIN			CCI_REG16_LE(0x00ec)
-#define VD55G1_REG_AE_FORCE_COLDSTART			CCI_REG8(0x0308)
-#define VD55G1_REG_AE_COLDSTART_EXP_TIME		CCI_REG32_LE(0x0374)
-#define VD55G1_REG_READOUT_CTRL				CCI_REG8(0x052e)
-#define VD55G1_READOUT_CTRL_BIN_MODE_NORMAL		0
-#define VD55G1_READOUT_CTRL_BIN_MODE_DIGITAL_X2		1
-#define VD55G1_REG_DUSTER_CTRL				CCI_REG8(0x03ae)
-#define VD55G1_DUSTER_ENABLE				BIT(0)
-#define VD55G1_DUSTER_DISABLE				0
-#define VD55G1_DUSTER_DYN_ENABLE			BIT(1)
-#define VD55G1_DUSTER_RING_ENABLE			BIT(4)
-#define VD55G1_REG_AE_TARGET_PERCENTAGE			CCI_REG8(0x0486)
-#define VD55G1_REG_NEXT_CTX				CCI_REG16_LE(0x03e4)
-#define VD55G1_REG_EXPOSURE_USE_CASES			CCI_REG8(0x0312)
-#define VD55G1_EXPOSURE_USE_CASES_MULTI_CONTEXT		BIT(2)
-#define VD55G1_REG_EXPOSURE_MAX_COARSE			CCI_REG16_LE(0x0372)
-#define VD55G1_EXPOSURE_MAX_COARSE_DEF			0x7fff
-#define VD55G1_EXPOSURE_MAX_COARSE_SUB			446
-#define VD55G1_REG_CTX_REPEAT_COUNT_CTX0		CCI_REG16_LE(0x03dc)
-#define VD55G1_REG_CTX_REPEAT_COUNT_CTX1		CCI_REG16_LE(0x03de)
-
-#define VD55G1_REG_EXP_MODE(ctx) \
-	CCI_REG8(0x0500 + VD55G1_CTX_OFFSET * (ctx))
-#define VD55G1_REG_FRAME_LENGTH(ctx) \
-	CCI_REG32_LE(0x050c + VD55G1_CTX_OFFSET * (ctx))
-#define VD55G1_REG_X_START(ctx) \
-	CCI_REG16_LE(0x0514 + VD55G1_CTX_OFFSET * (ctx))
-#define VD55G1_REG_X_WIDTH(ctx) \
-	CCI_REG16_LE(0x0516 + VD55G1_CTX_OFFSET * (ctx))
-#define VD55G1_REG_Y_START(ctx) \
-	CCI_REG16_LE(0x0510 + VD55G1_CTX_OFFSET * (ctx))
-#define VD55G1_REG_Y_HEIGHT(ctx) \
-	CCI_REG16_LE(0x0512 + VD55G1_CTX_OFFSET * (ctx))
-#define VD55G1_REG_GPIO_0_CTRL(ctx) \
-	CCI_REG8(0x051d + VD55G1_CTX_OFFSET * (ctx))
-#define VD55G1_GPIO_MODE_FSYNC_OUT			0x00
-#define VD55G1_GPIO_MODE_IN				0x01
-#define VD55G1_GPIO_MODE_STROBE				0x02
-#define VD55G1_REG_VT_MODE(ctx) \
-	CCI_REG8(0x0536 + VD55G1_CTX_OFFSET * (ctx))
-#define VD55G1_VT_MODE_NORMAL				0
-#define VD55G1_VT_MODE_SUBTRACTION			1
-#define VD55G1_REG_MASK_FRAME_CTRL(ctx) \
-	CCI_REG8(0x0537 + VD55G1_CTX_OFFSET * (ctx))
-#define VD55G1_MASK_FRAME_CTRL_OUTPUT			0
-#define VD55G1_MASK_FRAME_CTRL_MASK			1
-#define VD55G1_REG_EXPOSURE_INSTANCE(ctx) \
-	CCI_REG32_LE(0x52D + VD55G1_CTX_OFFSET * (ctx))
-
-#define VD55G1_WIDTH					804
-#define VD55G1_HEIGHT					704
-#define VD55G1_MODE_DEF					0
-#define VD55G1_NB_GPIOS					4
-#define VD55G1_MBUS_CODE_DEF				0
-#define VD55G1_DGAIN_DEF				256
-#define VD55G1_AGAIN_DEF				19
-#define VD55G1_EXPO_MAX_TERM				64
-#define VD55G1_EXPO_DEF					500
-#define VD55G1_LINE_LENGTH_MIN				1128
-#define VD55G1_LINE_LENGTH_SUB_MIN			1344
-#define VD55G1_VBLANK_MIN				86
-#define VD55G1_VBLANK_MAX				0xffff
-#define VD55G1_FRAME_LENGTH_DEF				1860 /* 60 fps */
-#define VD55G1_MIPI_MARGIN				900
-#define VD55G1_CTX_OFFSET				0x50
-#define VD55G1_FWPATCH_REVISION_MAJOR			2
-#define VD55G1_FWPATCH_REVISION_MINOR			9
-#define VD55G1_XCLK_FREQ_MIN				(6 * HZ_PER_MHZ)
-#define VD55G1_XCLK_FREQ_MAX				(27 * HZ_PER_MHZ)
-#define VD55G1_MIPI_RATE_MIN				(250 * MEGA)
-#define VD55G1_MIPI_RATE_MAX				(1200 * MEGA)
-
-#define VD55G1_MODEL_ID_NAME(id) \
-	((id) == VD55G1_MODEL_ID_VD55G1 ? "vd55g1" : "vd65g4")
-
-#include "vd55g-fw.h"
-
-static const char * const vd55g1_tp_menu[] = {
-	"Disabled",
-	"Diagonal Grey Scale",
-	"Pseudo-random Noise",
-};
-
-static const s64 vd55g1_ev_bias_menu[] = {
-	-3000, -2500, -2000, -1500, -1000, -500,
-	    0,
-	  500,  1000,  1500,  2000,  2500, 3000,
-};
-
-static const char * const vd55g1_hdr_menu[] = {
-	"No HDR",
-	/*
-	 * This mode acquires 2 frames on the sensor, the first one is ditched
-	 * out and only used for auto exposure data, the second one is output to
-	 * the host
-	 */
-	"Internal subtraction",
-};
-
-static const char * const vd55g1_supply_name[] = {
-	"vcore",
-	"vddio",
-	"vana",
-};
-
-enum vd55g1_hdr_mode {
-	VD55G1_NO_HDR,
-	VD55G1_HDR_SUB,
-};
-
-struct vd55g1_mode {
-	u32 width;
-	u32 height;
-};
-
-static const u32 vd55g1_mbus_formats_mono[] = {
-	MEDIA_BUS_FMT_Y8_1X8,
-	MEDIA_BUS_FMT_Y10_1X10,
-};
-
-/* Format order is : no flip, hflip, vflip, both */
-static const u32 vd55g1_mbus_formats_bayer[][4] = {
-	{
-		MEDIA_BUS_FMT_SRGGB8_1X8,
-		MEDIA_BUS_FMT_SGRBG8_1X8,
-		MEDIA_BUS_FMT_SGBRG8_1X8,
-		MEDIA_BUS_FMT_SBGGR8_1X8,
-	},
-	{
-		MEDIA_BUS_FMT_SRGGB10_1X10,
-		MEDIA_BUS_FMT_SGRBG10_1X10,
-		MEDIA_BUS_FMT_SGBRG10_1X10,
-		MEDIA_BUS_FMT_SBGGR10_1X10,
-	},
-};
-
-static const struct vd55g1_mode vd55g1_supported_modes[] = {
-	{
-		.width = VD55G1_WIDTH,
-		.height = VD55G1_HEIGHT,
-	},
-	{
-		.width = 800,
-		.height = VD55G1_HEIGHT,
-	},
-	{
-		.width = 800,
-		.height = 600,
-	},
-	{
-		.width = 640,
-		.height = 480,
-	},
-	{
-		.width = 320,
-		.height = 240,
-	},
-};
-
-enum vd55g1_expo_state {
-	VD55G1_EXP_AUTO,
-	VD55G1_EXP_FREEZE,
-	VD55G1_EXP_MANUAL,
-	VD55G1_EXP_SINGLE_STEP,
-	VD55G1_EXP_BYPASS,
-};
-
-struct vd55g1_vblank_limits {
-	u16 min;
-	u16 def;
-	u16 max;
-};
-
-struct vd55g1 {
-	struct device *dev;
-	unsigned int id;
-	struct v4l2_subdev sd;
-	struct media_pad pad;
-	struct regulator_bulk_data supplies[ARRAY_SIZE(vd55g1_supply_name)];
-	struct gpio_desc *reset_gpio;
-	struct clk *xclk;
-	struct regmap *regmap;
-	u32 xclk_freq;
-	u16 oif_ctrl;
-	u8 gpios[VD55G1_NB_GPIOS];
-	unsigned long ext_leds_mask;
-	u32 mipi_rate;
-	u32 pixel_clock;
-	u64 link_freq;
-	struct v4l2_ctrl_handler ctrl_handler;
-	struct v4l2_ctrl *pixel_rate_ctrl;
-	struct v4l2_ctrl *vblank_ctrl;
-	struct v4l2_ctrl *hblank_ctrl;
-	struct {
-		struct v4l2_ctrl *hflip_ctrl;
-		struct v4l2_ctrl *vflip_ctrl;
-	};
-	struct v4l2_ctrl *patgen_ctrl;
-	struct {
-		struct v4l2_ctrl *ae_ctrl;
-		struct v4l2_ctrl *expo_ctrl;
-		struct v4l2_ctrl *again_ctrl;
-		struct v4l2_ctrl *dgain_ctrl;
-	};
-	struct v4l2_ctrl *ae_lock_ctrl;
-	struct v4l2_ctrl *ae_bias_ctrl;
-	struct v4l2_ctrl *led_ctrl;
-	struct v4l2_ctrl *hdr_ctrl;
-};
-
-static inline struct vd55g1 *to_vd55g1(struct v4l2_subdev *sd)
-{
-	return container_of_const(sd, struct vd55g1, sd);
-}
-
-static inline struct vd55g1 *ctrl_to_vd55g1(struct v4l2_ctrl *ctrl)
-{
-	struct v4l2_subdev *sd = &container_of_const(ctrl->handler,
-						     struct vd55g1,
-						     ctrl_handler)->sd;
-
-	return to_vd55g1(sd);
-}
-
-static unsigned int vd55g1_get_fmt_bpp(u32 code)
-{
-	switch (code) {
-	case MEDIA_BUS_FMT_Y8_1X8:
-	case MEDIA_BUS_FMT_SRGGB8_1X8:
-	case MEDIA_BUS_FMT_SGRBG8_1X8:
-	case MEDIA_BUS_FMT_SGBRG8_1X8:
-	case MEDIA_BUS_FMT_SBGGR8_1X8:
-	default:
-		return 8;
-
-	case MEDIA_BUS_FMT_Y10_1X10:
-	case MEDIA_BUS_FMT_SRGGB10_1X10:
-	case MEDIA_BUS_FMT_SGRBG10_1X10:
-	case MEDIA_BUS_FMT_SGBRG10_1X10:
-	case MEDIA_BUS_FMT_SBGGR10_1X10:
-		return 10;
-	}
-}
-
-static unsigned int vd55g1_get_fmt_data_type(u32 code)
-{
-	switch (code) {
-	case MEDIA_BUS_FMT_Y8_1X8:
-	case MEDIA_BUS_FMT_SRGGB8_1X8:
-	case MEDIA_BUS_FMT_SGRBG8_1X8:
-	case MEDIA_BUS_FMT_SGBRG8_1X8:
-	case MEDIA_BUS_FMT_SBGGR8_1X8:
-	default:
-		return MIPI_CSI2_DT_RAW8;
-
-	case MEDIA_BUS_FMT_Y10_1X10:
-	case MEDIA_BUS_FMT_SRGGB10_1X10:
-	case MEDIA_BUS_FMT_SGRBG10_1X10:
-	case MEDIA_BUS_FMT_SGBRG10_1X10:
-	case MEDIA_BUS_FMT_SBGGR10_1X10:
-		return MIPI_CSI2_DT_RAW10;
-	}
-}
-
-static u32 vd55g1_get_fmt_code(struct vd55g1 *sensor, u32 code)
-{
-	unsigned int i, j;
-
-	if (sensor->id == VD55G1_MODEL_ID_VD55G1)
-		return code;
-
-	for (i = 0; i < ARRAY_SIZE(vd55g1_mbus_formats_bayer); i++) {
-		for (j = 0; j < ARRAY_SIZE(vd55g1_mbus_formats_bayer[i]); j++) {
-			if (vd55g1_mbus_formats_bayer[i][j] == code)
-				goto adapt_bayer_pattern;
-		}
-	}
-	dev_warn(sensor->dev, "Unsupported mbus format\n");
-
-	return code;
-
-adapt_bayer_pattern:
-	j = 0;
-	/* In first init_state() call, controls might not be initialized yet */
-	if (sensor->hflip_ctrl && sensor->vflip_ctrl) {
-		j = (sensor->hflip_ctrl->val ? 1 : 0) +
-			(sensor->vflip_ctrl->val ? 2 : 0);
-	}
-
-	return vd55g1_mbus_formats_bayer[i][j];
-}
-
-static s32 vd55g1_get_pixel_rate(struct vd55g1 *sensor,
-				 struct v4l2_mbus_framefmt *format)
-{
-	return sensor->mipi_rate / vd55g1_get_fmt_bpp(format->code);
-}
-
-static unsigned int vd55g1_get_hblank_min(struct vd55g1 *sensor,
-					  struct v4l2_mbus_framefmt *format,
-					  struct v4l2_rect *crop)
-{
-	u32 mipi_req_line_time;
-	u32 mipi_req_line_length;
-	u32 min_line_length;
-
-	/* MIPI required time */
-	mipi_req_line_time = (crop->width *
-			      vd55g1_get_fmt_bpp(format->code) +
-			      VD55G1_MIPI_MARGIN) /
-			      (sensor->mipi_rate / MEGA);
-	mipi_req_line_length = mipi_req_line_time * sensor->pixel_clock /
-			       HZ_PER_MHZ;
-
-	/* Absolute time required for ADCs to convert pixels */
-	min_line_length = VD55G1_LINE_LENGTH_MIN;
-	if (sensor->hdr_ctrl->val == VD55G1_HDR_SUB)
-		min_line_length = VD55G1_LINE_LENGTH_SUB_MIN;
-
-	/* Respect both constraint */
-	min_line_length = max(min_line_length, mipi_req_line_length);
-
-	return min_line_length - crop->width;
-}
-
-static void vd55g1_get_vblank_limits(struct vd55g1 *sensor,
-				     struct v4l2_rect *crop,
-				     struct vd55g1_vblank_limits *limits)
-{
-	limits->min = VD55G1_VBLANK_MIN;
-	limits->def = VD55G1_FRAME_LENGTH_DEF - crop->height;
-	limits->max = VD55G1_VBLANK_MAX - crop->height;
-}
-
-#define vd55g1_read(sensor, reg, val, err) \
-	cci_read((sensor)->regmap, reg, val, err)
-
-#define vd55g1_write(sensor, reg, val, err) \
-	cci_write((sensor)->regmap, reg, val, err)
-
-static int vd55g1_write_array(struct vd55g1 *sensor, u32 reg, unsigned int len,
-			      const u8 *array, int *err)
-{
-	unsigned int chunk_sz = 1024;
-	unsigned int sz;
-	int ret = 0;
-
-	if (err && *err)
-		return *err;
-
-	/*
-	 * This loop isn't necessary but in certains conditions (platforms, cpu
-	 * load, etc.) it has been observed that the bulk write could timeout.
-	 */
-	while (len) {
-		sz = min(len, chunk_sz);
-		ret = regmap_bulk_write(sensor->regmap, reg, array, sz);
-		if (ret < 0)
-			goto out;
-		len -= sz;
-		reg += sz;
-		array += sz;
-	}
-
-out:
-	if (ret && err)
-		*err = ret;
-
-	return ret;
-}
-
-static int vd55g1_poll_reg(struct vd55g1 *sensor, u32 reg, u8 poll_val,
-			   int *err)
-{
-	unsigned int val = 0;
-	int ret;
-
-	if (err && *err)
-		return *err;
-
-	ret = regmap_read_poll_timeout(sensor->regmap, CCI_REG_ADDR(reg), val,
-				       (val == poll_val), 2000,
-				       500 * USEC_PER_MSEC);
-
-	if (ret && err)
-		*err = ret;
-
-	return ret;
-}
-
-static int vd55g1_wait_state(struct vd55g1 *sensor, int state, int *err)
-{
-	return vd55g1_poll_reg(sensor, VD55G1_REG_SYSTEM_FSM, state, err);
-}
-
-static int vd55g1_prepare_clock_tree(struct vd55g1 *sensor)
-{
-	u32 sys_clk, mipi_div, pixel_div;
-
-	if (sensor->xclk_freq < VD55G1_XCLK_FREQ_MIN ||
-	    sensor->xclk_freq > VD55G1_XCLK_FREQ_MAX) {
-		dev_err(sensor->dev,
-			"Only %luMhz-%luMhz clock range supported. Provided %lu MHz\n",
-			VD55G1_XCLK_FREQ_MIN / HZ_PER_MHZ,
-			VD55G1_XCLK_FREQ_MAX / HZ_PER_MHZ,
-			sensor->xclk_freq / HZ_PER_MHZ);
-		return -EINVAL;
-	}
-
-	/* MIPI bus is double data rate */
-	sensor->mipi_rate = sensor->link_freq * 2;
-
-	if (sensor->mipi_rate < VD55G1_MIPI_RATE_MIN ||
-	    sensor->mipi_rate > VD55G1_MIPI_RATE_MAX) {
-		dev_err(sensor->dev,
-			"Only %luMbps-%luMbps data rate range supported. Provided %lu Mbps\n",
-			VD55G1_MIPI_RATE_MIN / MEGA,
-			VD55G1_MIPI_RATE_MAX / MEGA,
-			sensor->mipi_rate / MEGA);
-		return -EINVAL;
-	}
-
-	if (sensor->mipi_rate <= 300 * MEGA)
-		mipi_div = 4;
-	else if (sensor->mipi_rate <= 600 * MEGA)
-		mipi_div = 2;
-	else
-		mipi_div = 1;
-
-	sys_clk = sensor->mipi_rate * mipi_div;
-
-	if (sys_clk <= 780 * HZ_PER_MHZ)
-		pixel_div = 5;
-	else if (sys_clk <= 900 * HZ_PER_MHZ)
-		pixel_div = 6;
-	else
-		pixel_div = 8;
-
-	sensor->pixel_clock = sys_clk / pixel_div;
-
-	return 0;
-}
-
-static int vd55g1_update_patgen(struct vd55g1 *sensor, u32 patgen_index)
-{
-	static const u8 index2val[] = {
-		0x0, 0x22, 0x28
-	};
-	u32 pattern = index2val[patgen_index];
-	u32 reg = pattern << VD55G1_PATGEN_TYPE_SHIFT;
-	u8 duster = VD55G1_DUSTER_RING_ENABLE | VD55G1_DUSTER_DYN_ENABLE |
-		    VD55G1_DUSTER_ENABLE;
-	int ret = 0;
-
-	BUILD_BUG_ON(ARRAY_SIZE(index2val) != ARRAY_SIZE(vd55g1_tp_menu));
-
-	if (pattern != 0) {
-		reg |= VD55G1_PATGEN_ENABLE;
-		/* Take care of duster to not mess up the test pattern output */
-		duster = VD55G1_DUSTER_DISABLE;
-	}
-
-	vd55g1_write(sensor, VD55G1_REG_DUSTER_CTRL, duster, &ret);
-	vd55g1_write(sensor, VD55G1_REG_PATGEN_CTRL, reg, &ret);
-
-	return ret;
-}
-
-static int vd55g1_update_expo_cluster(struct vd55g1 *sensor, bool is_auto)
-{
-	enum vd55g1_expo_state expo_state = is_auto ? VD55G1_EXP_AUTO :
-						      VD55G1_EXP_MANUAL;
-	int ret = 0;
-
-	if (sensor->ae_ctrl->is_new)
-		vd55g1_write(sensor, VD55G1_REG_EXP_MODE(0), expo_state, &ret);
-
-	if (sensor->hdr_ctrl->val == VD55G1_HDR_SUB &&
-	    sensor->hdr_ctrl->is_new) {
-		vd55g1_write(sensor, VD55G1_REG_EXP_MODE(1), VD55G1_EXP_BYPASS,
-			     &ret);
-		if (ret)
-			return ret;
-	}
-
-	if (!is_auto && sensor->expo_ctrl->is_new)
-		vd55g1_write(sensor, VD55G1_REG_MANUAL_COARSE_EXPOSURE,
-			     sensor->expo_ctrl->val, &ret);
-
-	if (!is_auto && sensor->again_ctrl->is_new)
-		vd55g1_write(sensor, VD55G1_REG_MANUAL_ANALOG_GAIN,
-			     sensor->again_ctrl->val, &ret);
-
-	if (!is_auto && sensor->dgain_ctrl->is_new)
-		vd55g1_write(sensor, VD55G1_REG_MANUAL_DIGITAL_GAIN,
-			     sensor->dgain_ctrl->val, &ret);
-
-	return ret;
-}
-
-static int vd55g1_lock_exposure(struct vd55g1 *sensor, u32 lock_val)
-{
-	bool ae_lock = lock_val & V4L2_LOCK_EXPOSURE;
-	enum vd55g1_expo_state expo_state = ae_lock ? VD55G1_EXP_FREEZE :
-						      VD55G1_EXP_AUTO;
-	int ret = 0;
-
-	if (sensor->ae_ctrl->val == V4L2_EXPOSURE_AUTO)
-		vd55g1_write(sensor, VD55G1_REG_EXP_MODE(0), expo_state, &ret);
-
-	return ret;
-}
-
-static int vd55g1_read_expo_cluster(struct vd55g1 *sensor)
-{
-	u64 exposure = 0;
-	u64 again = 0;
-	u64 dgain = 0;
-	int ret = 0;
-
-	vd55g1_read(sensor, VD55G1_REG_APPLIED_COARSE_EXPOSURE, &exposure,
-		    &ret);
-	vd55g1_read(sensor, VD55G1_REG_APPLIED_ANALOG_GAIN, &again, &ret);
-	vd55g1_read(sensor, VD55G1_REG_APPLIED_DIGITAL_GAIN, &dgain, &ret);
-	if (ret)
-		return ret;
-
-	sensor->expo_ctrl->cur.val = exposure;
-	sensor->again_ctrl->cur.val = again;
-	sensor->dgain_ctrl->cur.val = dgain;
-
-	return 0;
-}
-
-static int vd55g1_update_frame_length(struct vd55g1 *sensor,
-				      unsigned int frame_length)
-{
-	int ret = 0;
-
-	if (sensor->hdr_ctrl->val == VD55G1_HDR_SUB)
-		vd55g1_write(sensor, VD55G1_REG_FRAME_LENGTH(1), frame_length,
-			     &ret);
-	vd55g1_write(sensor, VD55G1_REG_FRAME_LENGTH(0), frame_length, &ret);
-
-	return ret;
-}
-
-static int vd55g1_update_exposure_target(struct vd55g1 *sensor, int index)
-{
-	/*
-	 * Find auto exposure target with: default target exposure * 2^EV
-	 * Defaut target exposure being 27 for the sensor.
-	 */
-	static const unsigned int index2exposure_target[] = {
-		3, 5, 7, 10, 14, 19, 27, 38, 54, 76, 108, 153, 216,
-	};
-	int exposure_target = index2exposure_target[index];
-
-	return vd55g1_write(sensor, VD55G1_REG_AE_TARGET_PERCENTAGE,
-			    exposure_target, NULL);
-}
-
-static int vd55g1_apply_cold_start(struct vd55g1 *sensor,
-				   struct v4l2_rect *crop)
-{
-	/*
-	 * Cold start register is a single register expressed as exposure time
-	 * in us. This differ from status registers being a combination of
-	 * exposure, digital gain, and analog gain, requiring the following
-	 * format conversion.
-	 */
-	unsigned int line_length = crop->width + sensor->hblank_ctrl->val;
-	unsigned int line_time_us = DIV_ROUND_UP(line_length * MEGA,
-						 sensor->pixel_clock);
-	u8 d_gain = DIV_ROUND_CLOSEST(sensor->dgain_ctrl->val, 1 << 8);
-	u8 a_gain = DIV_ROUND_CLOSEST(32, (32 - sensor->again_ctrl->val));
-	unsigned int expo_us = sensor->expo_ctrl->val * d_gain * a_gain *
-			       line_time_us;
-	int ret = 0;
-
-	vd55g1_write(sensor, VD55G1_REG_AE_FORCE_COLDSTART, 1, &ret);
-	vd55g1_write(sensor, VD55G1_REG_AE_COLDSTART_EXP_TIME, expo_us, &ret);
-
-	return ret;
-}
-
-static void vd55g1_update_pad_fmt(struct vd55g1 *sensor,
-				  const struct vd55g1_mode *mode, u32 code,
-				  struct v4l2_mbus_framefmt *fmt)
-{
-	fmt->code = vd55g1_get_fmt_code(sensor, code);
-	fmt->width = mode->width;
-	fmt->height = mode->height;
-	fmt->colorspace = V4L2_COLORSPACE_RAW;
-	fmt->field = V4L2_FIELD_NONE;
-	fmt->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
-	fmt->quantization = V4L2_QUANTIZATION_DEFAULT;
-	fmt->xfer_func = V4L2_XFER_FUNC_DEFAULT;
-}
-
-static int vd55g1_update_hdr_mode(struct vd55g1 *sensor)
-{
-	int ret = 0;
-
-	switch (sensor->hdr_ctrl->val) {
-	case VD55G1_NO_HDR:
-		vd55g1_write(sensor, VD55G1_REG_EXPOSURE_MAX_COARSE,
-			     VD55G1_EXPOSURE_MAX_COARSE_DEF, &ret);
-		vd55g1_write(sensor, VD55G1_REG_EXPOSURE_USE_CASES, 0, &ret);
-		vd55g1_write(sensor, VD55G1_REG_NEXT_CTX, 0x0, &ret);
-
-		vd55g1_write(sensor, VD55G1_REG_CTX_REPEAT_COUNT_CTX0, 0, &ret);
-
-		vd55g1_write(sensor, VD55G1_REG_VT_MODE(0),
-			     VD55G1_VT_MODE_NORMAL, &ret);
-		vd55g1_write(sensor, VD55G1_REG_MASK_FRAME_CTRL(0),
-			     VD55G1_MASK_FRAME_CTRL_OUTPUT, &ret);
-		break;
-	case VD55G1_HDR_SUB:
-		vd55g1_write(sensor, VD55G1_REG_EXPOSURE_MAX_COARSE,
-			     VD55G1_EXPOSURE_MAX_COARSE_SUB, &ret);
-		vd55g1_write(sensor, VD55G1_REG_EXPOSURE_USE_CASES,
-			     VD55G1_EXPOSURE_USE_CASES_MULTI_CONTEXT, &ret);
-		vd55g1_write(sensor, VD55G1_REG_NEXT_CTX, 0x0001, &ret);
-
-		vd55g1_write(sensor, VD55G1_REG_CTX_REPEAT_COUNT_CTX0, 1, &ret);
-		vd55g1_write(sensor, VD55G1_REG_CTX_REPEAT_COUNT_CTX1, 1, &ret);
-
-		vd55g1_write(sensor, VD55G1_REG_VT_MODE(0),
-			     VD55G1_VT_MODE_NORMAL, &ret);
-		vd55g1_write(sensor, VD55G1_REG_MASK_FRAME_CTRL(0),
-			     VD55G1_MASK_FRAME_CTRL_MASK, &ret);
-		vd55g1_write(sensor, VD55G1_REG_EXPOSURE_INSTANCE(0), 0, &ret);
-		vd55g1_write(sensor, VD55G1_REG_VT_MODE(1),
-			     VD55G1_VT_MODE_SUBTRACTION, &ret);
-		vd55g1_write(sensor, VD55G1_REG_MASK_FRAME_CTRL(1),
-			     VD55G1_MASK_FRAME_CTRL_OUTPUT, &ret);
-		vd55g1_write(sensor, VD55G1_REG_EXPOSURE_INSTANCE(1), 1, &ret);
-		break;
-	default:
-		ret = -EINVAL;
-	}
-
-	return ret;
-}
-
-static int vd55g1_set_framefmt(struct vd55g1 *sensor,
-			       struct v4l2_mbus_framefmt *format,
-			       struct v4l2_rect *crop)
-{
-	u8 binning;
-	int ret = 0;
-
-	vd55g1_write(sensor, VD55G1_REG_FORMAT_CTRL,
-		     vd55g1_get_fmt_bpp(format->code), &ret);
-	vd55g1_write(sensor, VD55G1_REG_OIF_IMG_CTRL,
-		     vd55g1_get_fmt_data_type(format->code), &ret);
-
-	switch (crop->width / format->width) {
-	case 1:
-	default:
-		binning = VD55G1_READOUT_CTRL_BIN_MODE_NORMAL;
-		break;
-	case 2:
-		binning = VD55G1_READOUT_CTRL_BIN_MODE_DIGITAL_X2;
-		break;
-	}
-	vd55g1_write(sensor, VD55G1_REG_READOUT_CTRL, binning, &ret);
-
-	vd55g1_write(sensor, VD55G1_REG_X_START(0), crop->left, &ret);
-	vd55g1_write(sensor, VD55G1_REG_X_WIDTH(0), crop->width, &ret);
-	vd55g1_write(sensor, VD55G1_REG_Y_START(0), crop->top, &ret);
-	vd55g1_write(sensor, VD55G1_REG_Y_HEIGHT(0), crop->height, &ret);
-
-	vd55g1_write(sensor, VD55G1_REG_X_START(1), crop->left, &ret);
-	vd55g1_write(sensor, VD55G1_REG_X_WIDTH(1), crop->width, &ret);
-	vd55g1_write(sensor, VD55G1_REG_Y_START(1), crop->top, &ret);
-	vd55g1_write(sensor, VD55G1_REG_Y_HEIGHT(1), crop->height, &ret);
-
-	return ret;
-}
-
-static int vd55g1_update_gpios(struct vd55g1 *sensor, unsigned long gpio_mask)
-{
-	unsigned long io;
-	u8 gpio_val;
-	int ret = 0;
-
-	for_each_set_bit(io, &gpio_mask, VD55G1_NB_GPIOS) {
-		gpio_val = sensor->gpios[io];
-
-		if (gpio_val == VD55G1_GPIO_MODE_STROBE &&
-		    sensor->led_ctrl->val == V4L2_FLASH_LED_MODE_NONE) {
-			gpio_val = VD55G1_GPIO_MODE_IN;
-			if (sensor->hdr_ctrl->val == VD55G1_HDR_SUB) {
-				/* Make its context 1 counterpart strobe too */
-				vd55g1_write(sensor,
-					     VD55G1_REG_GPIO_0_CTRL(1) + io,
-					     gpio_val, &ret);
-			}
-		}
-
-		ret = vd55g1_write(sensor, VD55G1_REG_GPIO_0_CTRL(0) + io,
-				   gpio_val, &ret);
-	}
-
-	return ret;
-}
-
-static int vd55g1_ro_ctrls_setup(struct vd55g1 *sensor, struct v4l2_rect *crop)
-{
-	return vd55g1_write(sensor, VD55G1_REG_LINE_LENGTH,
-			    crop->width + sensor->hblank_ctrl->val, NULL);
-}
-
-static void vd55g1_grab_ctrls(struct vd55g1 *sensor, bool enable)
-{
-	/* These settings cannot change during stream */
-	v4l2_ctrl_grab(sensor->hflip_ctrl, enable);
-	v4l2_ctrl_grab(sensor->vflip_ctrl, enable);
-	v4l2_ctrl_grab(sensor->patgen_ctrl, enable);
-	v4l2_ctrl_grab(sensor->hdr_ctrl, enable);
-}
-
-static int vd55g1_enable_streams(struct v4l2_subdev *sd,
-				 struct v4l2_subdev_state *state, u32 pad,
-				 u64 streams_mask)
-{
-	struct vd55g1 *sensor = to_vd55g1(sd);
-	struct v4l2_rect *crop =
-		v4l2_subdev_state_get_crop(state, 0);
-	struct v4l2_mbus_framefmt *format =
-		v4l2_subdev_state_get_format(state, 0);
-	int ret;
-
-	ret = pm_runtime_resume_and_get(sensor->dev);
-	if (ret < 0)
-		return ret;
-
-	/* Configure output */
-	vd55g1_write(sensor, VD55G1_REG_MIPI_DATA_RATE,
-		     sensor->mipi_rate, &ret);
-	vd55g1_write(sensor, VD55G1_REG_OIF_CTRL, sensor->oif_ctrl, &ret);
-	vd55g1_write(sensor, VD55G1_REG_ISL_ENABLE, 0, &ret);
-	if (ret)
-		goto err_rpm_put;
-
-	ret = vd55g1_set_framefmt(sensor, format, crop);
-	if (ret)
-		goto err_rpm_put;
-
-	/* Setup default GPIO values; could be overridden by V4L2 ctrl setup */
-	ret = vd55g1_update_gpios(sensor, GENMASK(VD55G1_NB_GPIOS - 1, 0));
-	if (ret)
-		goto err_rpm_put;
-
-	ret = vd55g1_apply_cold_start(sensor, crop);
-	if (ret)
-		goto err_rpm_put;
-
-	/* Apply settings from V4L2 ctrls */
-	ret = __v4l2_ctrl_handler_setup(&sensor->ctrl_handler);
-	if (ret)
-		goto err_rpm_put;
-
-	/* Also apply settings from read-only V4L2 ctrls */
-	ret = vd55g1_ro_ctrls_setup(sensor, crop);
-	if (ret)
-		goto err_rpm_put;
-
-	/* Start streaming */
-	vd55g1_write(sensor, VD55G1_REG_STBY, VD55G1_STBY_START_STREAM, &ret);
-	vd55g1_poll_reg(sensor, VD55G1_REG_STBY, 0, &ret);
-	vd55g1_wait_state(sensor, VD55G1_SYSTEM_FSM_STREAMING, &ret);
-	if (ret)
-		goto err_rpm_put;
-
-	vd55g1_grab_ctrls(sensor, true);
-
-	return 0;
-
-err_rpm_put:
-	pm_runtime_put(sensor->dev);
-	return -EINVAL;
-}
-
-static int vd55g1_disable_streams(struct v4l2_subdev *sd,
-				  struct v4l2_subdev_state *state, u32 pad,
-				  u64 streams_mask)
-{
-	struct vd55g1 *sensor = to_vd55g1(sd);
-	int ret = 0;
-
-	/* Retrieve Expo cluster to enable coldstart of AE */
-	ret = vd55g1_read_expo_cluster(sensor);
-
-	vd55g1_write(sensor, VD55G1_REG_STREAMING, VD55G1_STREAMING_STOP_STREAM,
-		     &ret);
-	vd55g1_poll_reg(sensor, VD55G1_REG_STREAMING, 0, &ret);
-	vd55g1_wait_state(sensor, VD55G1_SYSTEM_FSM_SW_STBY, &ret);
-
-	if (ret)
-		dev_warn(sensor->dev, "Can't disable stream\n");
-
-	vd55g1_grab_ctrls(sensor, false);
-
-	pm_runtime_put_autosuspend(sensor->dev);
-
-	return ret;
-}
-
-static int vd55g1_patch(struct vd55g1 *sensor)
-{
-	u64 patch;
-	int ret = 0;
-
-	/* vd55g1 needs a patch while vd65g4 does not */
-	if (sensor->id == VD55G1_MODEL_ID_VD55G1) {
-		vd55g1_write_array(sensor, VD55G1_REG_FWPATCH_START_ADDR,
-				   sizeof(vd55g1_patch_array),
-				   vd55g1_patch_array, &ret);
-		vd55g1_write(sensor, VD55G1_REG_BOOT,
-			     VD55G1_BOOT_PATCH_AND_BOOT, &ret);
-		vd55g1_poll_reg(sensor, VD55G1_REG_BOOT, 0, &ret);
-		if (ret) {
-			dev_err(sensor->dev, "Failed to apply patch\n");
-			return ret;
-		}
-
-		vd55g1_read(sensor, VD55G1_REG_FWPATCH_REVISION, &patch, &ret);
-		if (patch != (VD55G1_FWPATCH_REVISION_MAJOR << 8) +
-		    VD55G1_FWPATCH_REVISION_MINOR) {
-			dev_err(sensor->dev, "Bad patch version expected %d.%d got %d.%d\n",
-				VD55G1_FWPATCH_REVISION_MAJOR,
-				VD55G1_FWPATCH_REVISION_MINOR,
-				(u8)(patch >> 8), (u8)(patch & 0xff));
-			return -ENODEV;
-		}
-		dev_dbg(sensor->dev, "patch %d.%d applied\n",
-			(u8)(patch >> 8), (u8)(patch & 0xff));
-
-	} else {
-		vd55g1_write(sensor, VD55G1_REG_BOOT, VD55G1_BOOT_BOOT, &ret);
-		vd55g1_poll_reg(sensor, VD55G1_REG_BOOT, 0, &ret);
-		if (ret) {
-			dev_err(sensor->dev, "Failed to boot\n");
-			return ret;
-		}
-	}
-
-	ret = vd55g1_wait_state(sensor, VD55G1_SYSTEM_FSM_SW_STBY, NULL);
-	if (ret) {
-		dev_err(sensor->dev, "Sensor waiting after boot failed\n");
-		return ret;
-	}
-
-	return 0;
-}
-
-static int vd55g1_get_selection(struct v4l2_subdev *sd,
-				struct v4l2_subdev_state *sd_state,
-				struct v4l2_subdev_selection *sel)
-{
-	const struct v4l2_rect *crop = v4l2_subdev_state_get_crop(sd_state, 0);
-
-	switch (sel->target) {
-	case V4L2_SEL_TGT_CROP:
-		sel->r = *crop;
-		return 0;
-	case V4L2_SEL_TGT_NATIVE_SIZE:
-	case V4L2_SEL_TGT_CROP_DEFAULT:
-	case V4L2_SEL_TGT_CROP_BOUNDS:
-		sel->r.top = 0;
-		sel->r.left = 0;
-		sel->r.width = VD55G1_WIDTH;
-		sel->r.height = VD55G1_HEIGHT;
-		return 0;
-	}
-
-	return -EINVAL;
-}
-
-static int vd55g1_enum_mbus_code(struct v4l2_subdev *sd,
-				 struct v4l2_subdev_state *sd_state,
-				 struct v4l2_subdev_mbus_code_enum *code)
-{
-	struct vd55g1 *sensor = to_vd55g1(sd);
-	u32 base_code;
-
-	if (sensor->id == VD55G1_MODEL_ID_VD55G1) {
-		if (code->index >= ARRAY_SIZE(vd55g1_mbus_formats_mono))
-			return -EINVAL;
-		base_code = vd55g1_mbus_formats_mono[code->index];
-	} else {
-		if (code->index >= ARRAY_SIZE(vd55g1_mbus_formats_bayer))
-			return -EINVAL;
-		base_code = vd55g1_mbus_formats_bayer[code->index][0];
-	}
-	code->code = vd55g1_get_fmt_code(sensor, base_code);
-
-	return 0;
-}
-
-static int vd55g1_new_format_change_controls(struct vd55g1 *sensor,
-					     struct v4l2_mbus_framefmt *format,
-					     struct v4l2_rect *crop)
-{
-	struct vd55g1_vblank_limits vblank;
-	unsigned int hblank;
-	unsigned int frame_length = 0;
-	unsigned int expo_max;
-	int ret;
-
-	/* Reset vblank and frame length to default */
-	vd55g1_get_vblank_limits(sensor, crop, &vblank);
-	ret = __v4l2_ctrl_modify_range(sensor->vblank_ctrl, vblank.min,
-				       vblank.max, 1, vblank.def);
-	if (ret)
-		return ret;
-
-	/* Max exposure changes with vblank */
-	frame_length = crop->height + sensor->vblank_ctrl->val;
-	expo_max = frame_length - VD55G1_EXPO_MAX_TERM;
-	ret = __v4l2_ctrl_modify_range(sensor->expo_ctrl, 0, expo_max, 1,
-				       VD55G1_EXPO_DEF);
-	if (ret)
-		return ret;
-
-	/* Update pixel rate to reflect new bpp */
-	ret = __v4l2_ctrl_s_ctrl_int64(sensor->pixel_rate_ctrl,
-				       vd55g1_get_pixel_rate(sensor, format));
-	if (ret)
-		return ret;
-
-	/* Update hblank according to new width */
-	hblank = vd55g1_get_hblank_min(sensor, format, crop);
-	ret = __v4l2_ctrl_modify_range(sensor->hblank_ctrl, hblank, hblank, 1,
-				       hblank);
-
-	return ret;
-}
-
-static int vd55g1_set_pad_fmt(struct v4l2_subdev *sd,
-			      struct v4l2_subdev_state *sd_state,
-			      struct v4l2_subdev_format *sd_fmt)
-{
-	struct vd55g1 *sensor = to_vd55g1(sd);
-	const struct vd55g1_mode *new_mode;
-	struct v4l2_mbus_framefmt *format;
-	struct v4l2_rect pad_crop;
-	unsigned int binning;
-
-	new_mode = v4l2_find_nearest_size(vd55g1_supported_modes,
-					  ARRAY_SIZE(vd55g1_supported_modes),
-					  width, height, sd_fmt->format.width,
-					  sd_fmt->format.height);
-
-	vd55g1_update_pad_fmt(sensor, new_mode, sd_fmt->format.code,
-			      &sd_fmt->format);
-
-	/*
-	 * Use binning to maximize the crop rectangle size, and centre it in the
-	 * sensor.
-	 */
-	binning = min(VD55G1_WIDTH / sd_fmt->format.width,
-		      VD55G1_HEIGHT / sd_fmt->format.height);
-	binning = min(binning, 2U);
-	pad_crop.width = sd_fmt->format.width * binning;
-	pad_crop.height = sd_fmt->format.height * binning;
-	pad_crop.left = (VD55G1_WIDTH - pad_crop.width) / 2;
-	pad_crop.top = (VD55G1_HEIGHT - pad_crop.height) / 2;
-
-	format = v4l2_subdev_state_get_format(sd_state, sd_fmt->pad);
-
-	*format = sd_fmt->format;
-
-	*v4l2_subdev_state_get_crop(sd_state, sd_fmt->pad) = pad_crop;
-	if (sd_fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE)
-		return vd55g1_new_format_change_controls(sensor,
-							 &sd_fmt->format,
-							 &pad_crop);
-
-	return 0;
-}
-
-static int vd55g1_init_state(struct v4l2_subdev *sd,
-			     struct v4l2_subdev_state *sd_state)
-{
-	struct vd55g1 *sensor = to_vd55g1(sd);
-	struct v4l2_subdev_format fmt = { 0 };
-	struct v4l2_subdev_route routes[] = {
-		{ .flags = V4L2_SUBDEV_ROUTE_FL_ACTIVE }
-	};
-	struct v4l2_subdev_krouting routing = {
-	    .num_routes = ARRAY_SIZE(routes),
-	    .routes = routes,
-	};
-	int ret;
-
-	/* Needed by v4l2_subdev_s_stream_helper(), even with 1 stream only */
-	ret = v4l2_subdev_set_routing(sd, sd_state, &routing);
-	if (ret)
-		return ret;
-
-	vd55g1_update_pad_fmt(sensor, &vd55g1_supported_modes[VD55G1_MODE_DEF],
-			      vd55g1_get_fmt_code(sensor, VD55G1_MBUS_CODE_DEF),
-			      &fmt.format);
-
-	return vd55g1_set_pad_fmt(sd, sd_state, &fmt);
-}
-
-static int vd55g1_enum_frame_size(struct v4l2_subdev *sd,
-				  struct v4l2_subdev_state *sd_state,
-				  struct v4l2_subdev_frame_size_enum *fse)
-{
-	struct vd55g1 *sensor = to_vd55g1(sd);
-	u32 code;
-
-	if (fse->index >= ARRAY_SIZE(vd55g1_supported_modes))
-		return -EINVAL;
-
-	code = vd55g1_get_fmt_code(sensor, fse->code);
-	if (fse->code != code)
-		return -EINVAL;
-
-	fse->min_width = vd55g1_supported_modes[fse->index].width;
-	fse->max_width = fse->min_width;
-	fse->min_height = vd55g1_supported_modes[fse->index].height;
-	fse->max_height = fse->min_height;
-
-	return 0;
-}
-
-static const struct v4l2_subdev_internal_ops vd55g1_internal_ops = {
-	.init_state = vd55g1_init_state,
-};
-
-static const struct v4l2_subdev_pad_ops vd55g1_pad_ops = {
-	.enum_mbus_code = vd55g1_enum_mbus_code,
-	.get_fmt = v4l2_subdev_get_fmt,
-	.set_fmt = vd55g1_set_pad_fmt,
-	.get_selection = vd55g1_get_selection,
-	.enum_frame_size = vd55g1_enum_frame_size,
-	.enable_streams = vd55g1_enable_streams,
-	.disable_streams = vd55g1_disable_streams,
-};
-
-static const struct v4l2_subdev_video_ops vd55g1_video_ops = {
-	.s_stream = v4l2_subdev_s_stream_helper,
-};
-
-static const struct v4l2_subdev_ops vd55g1_subdev_ops = {
-	.video = &vd55g1_video_ops,
-	.pad = &vd55g1_pad_ops,
-};
-
-static int vd55g1_g_volatile_ctrl(struct v4l2_ctrl *ctrl)
-{
-	struct vd55g1 *sensor = ctrl_to_vd55g1(ctrl);
-	int ret = 0;
-
-	/* Interact with HW only when it is powered ON */
-	if (!pm_runtime_get_if_in_use(sensor->dev))
-		return 0;
-
-	switch (ctrl->id) {
-	case V4L2_CID_EXPOSURE_AUTO:
-		ret = vd55g1_read_expo_cluster(sensor);
-		break;
-	default:
-		ret = -EINVAL;
-		break;
-	}
-
-	pm_runtime_put_autosuspend(sensor->dev);
-
-	return ret;
-}
-
-static int vd55g1_s_ctrl(struct v4l2_ctrl *ctrl)
-{
-	struct vd55g1 *sensor = ctrl_to_vd55g1(ctrl);
-	unsigned int frame_length = 0;
-	unsigned int expo_max;
-	struct v4l2_subdev_state *state =
-		v4l2_subdev_get_locked_active_state(&sensor->sd);
-	struct v4l2_rect *crop =
-		v4l2_subdev_state_get_crop(state, 0);
-	struct v4l2_mbus_framefmt *format =
-		v4l2_subdev_state_get_format(state, 0);
-	unsigned int hblank = vd55g1_get_hblank_min(sensor, format, crop);
-	bool is_auto = false;
-	int ret = 0;
-
-	if (ctrl->flags & V4L2_CTRL_FLAG_READ_ONLY)
-		return 0;
-
-	/* Update controls state, range, etc. whatever the state of the HW */
-	switch (ctrl->id) {
-	case V4L2_CID_VBLANK:
-		frame_length = crop->height + ctrl->val;
-		expo_max = frame_length - VD55G1_EXPO_MAX_TERM;
-		ret = __v4l2_ctrl_modify_range(sensor->expo_ctrl, 0, expo_max,
-					       1, VD55G1_EXPO_DEF);
-		break;
-	case V4L2_CID_EXPOSURE_AUTO:
-		is_auto = (ctrl->val == V4L2_EXPOSURE_AUTO);
-		__v4l2_ctrl_grab(sensor->ae_lock_ctrl, !is_auto);
-		__v4l2_ctrl_grab(sensor->ae_bias_ctrl, !is_auto);
-		break;
-	case V4L2_CID_HDR_SENSOR_MODE:
-		/* Discriminate if the userspace changed the control value */
-		if (ctrl->val != ctrl->cur.val) {
-			/* Max horizontal blanking changes with hdr mode */
-			ret = __v4l2_ctrl_modify_range(sensor->hblank_ctrl,
-						       hblank, hblank, 1,
-						       hblank);
-		}
-		break;
-	default:
-		break;
-	}
-
-	/* Don't modify hardware if controls modification failed */
-	if (ret)
-		return ret;
-
-	/* Interact with HW only when it is powered ON */
-	if (!pm_runtime_get_if_in_use(sensor->dev))
-		return 0;
-
-	switch (ctrl->id) {
-	case V4L2_CID_HFLIP:
-		ret = vd55g1_write(sensor, VD55G1_REG_ORIENTATION,
-				   sensor->hflip_ctrl->val |
-					   (sensor->vflip_ctrl->val << 1),
-				   NULL);
-		break;
-	case V4L2_CID_TEST_PATTERN:
-		ret = vd55g1_update_patgen(sensor, ctrl->val);
-		break;
-	case V4L2_CID_EXPOSURE_AUTO:
-		ret = vd55g1_update_expo_cluster(sensor, is_auto);
-		break;
-	case V4L2_CID_3A_LOCK:
-		ret = vd55g1_lock_exposure(sensor, ctrl->val);
-		break;
-	case V4L2_CID_AUTO_EXPOSURE_BIAS:
-		/*
-		 * We use auto exposure target percentage register to control
-		 * exposure bias for more precision.
-		 */
-		ret = vd55g1_update_exposure_target(sensor, ctrl->val);
-		break;
-	case V4L2_CID_VBLANK:
-		ret = vd55g1_update_frame_length(sensor, frame_length);
-		break;
-	case V4L2_CID_FLASH_LED_MODE:
-		ret = vd55g1_update_gpios(sensor, sensor->ext_leds_mask);
-		break;
-	case V4L2_CID_HDR_SENSOR_MODE:
-		ret = vd55g1_update_hdr_mode(sensor);
-		break;
-	default:
-		ret = -EINVAL;
-		break;
-	}
-
-	pm_runtime_put_autosuspend(sensor->dev);
-
-	return ret;
-}
-
-static const struct v4l2_ctrl_ops vd55g1_ctrl_ops = {
-	.g_volatile_ctrl = vd55g1_g_volatile_ctrl,
-	.s_ctrl = vd55g1_s_ctrl,
-};
-
-static int vd55g1_init_ctrls(struct vd55g1 *sensor)
-{
-	const struct v4l2_ctrl_ops *ops = &vd55g1_ctrl_ops;
-	struct v4l2_ctrl_handler *hdl = &sensor->ctrl_handler;
-	struct v4l2_ctrl *ctrl;
-	struct v4l2_fwnode_device_properties fwnode_props;
-	struct vd55g1_vblank_limits vblank;
-	unsigned int hblank;
-	struct v4l2_subdev_state *state =
-		v4l2_subdev_lock_and_get_active_state(&sensor->sd);
-	struct v4l2_rect *crop =
-		v4l2_subdev_state_get_crop(state, 0);
-	struct v4l2_mbus_framefmt *format =
-		v4l2_subdev_state_get_format(state, 0);
-	s32 pixel_rate = vd55g1_get_pixel_rate(sensor, format);
-	int ret;
-
-	v4l2_ctrl_handler_init(hdl, 16);
-
-	/* Flip cluster */
-	sensor->hflip_ctrl = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_HFLIP,
-					       0, 1, 1, 0);
-	if (sensor->hflip_ctrl)
-		sensor->hflip_ctrl->flags |= V4L2_CTRL_FLAG_MODIFY_LAYOUT;
-	sensor->vflip_ctrl = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_VFLIP,
-					       0, 1, 1, 0);
-	if (sensor->vflip_ctrl)
-		sensor->vflip_ctrl->flags |= V4L2_CTRL_FLAG_MODIFY_LAYOUT;
-	v4l2_ctrl_cluster(2, &sensor->hflip_ctrl);
-
-	/* Exposition cluster */
-	sensor->ae_ctrl = v4l2_ctrl_new_std_menu(hdl, ops,
-						 V4L2_CID_EXPOSURE_AUTO, 1,
-						 ~0x3, V4L2_EXPOSURE_AUTO);
-	sensor->again_ctrl = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_ANALOGUE_GAIN,
-					       0, 0x1c, 1, VD55G1_AGAIN_DEF);
-	sensor->dgain_ctrl = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_DIGITAL_GAIN,
-					       256, 0xffff, 1,
-					       VD55G1_DGAIN_DEF);
-	sensor->expo_ctrl = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_EXPOSURE, 0,
-					      VD55G1_FRAME_LENGTH_DEF -
-					      VD55G1_EXPO_MAX_TERM,
-					      1, VD55G1_EXPO_DEF);
-	v4l2_ctrl_auto_cluster(4, &sensor->ae_ctrl, V4L2_EXPOSURE_MANUAL, true);
-
-	sensor->patgen_ctrl =
-		v4l2_ctrl_new_std_menu_items(hdl, ops, V4L2_CID_TEST_PATTERN,
-					     ARRAY_SIZE(vd55g1_tp_menu) - 1, 0,
-					     0, vd55g1_tp_menu);
-	ctrl = v4l2_ctrl_new_int_menu(hdl, ops, V4L2_CID_LINK_FREQ,
-				      0, 0, &sensor->link_freq);
-	if (ctrl)
-		ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;
-	sensor->pixel_rate_ctrl = v4l2_ctrl_new_std(hdl, ops,
-						    V4L2_CID_PIXEL_RATE, 1,
-						    INT_MAX, 1,
-						    pixel_rate);
-	if (sensor->pixel_rate_ctrl)
-		sensor->pixel_rate_ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;
-	sensor->ae_lock_ctrl = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_3A_LOCK,
-						 0, 1, 0, 0);
-	sensor->ae_bias_ctrl =
-		v4l2_ctrl_new_int_menu(hdl, ops,
-				       V4L2_CID_AUTO_EXPOSURE_BIAS,
-				       ARRAY_SIZE(vd55g1_ev_bias_menu) - 1,
-				       ARRAY_SIZE(vd55g1_ev_bias_menu) / 2,
-				       vd55g1_ev_bias_menu);
-	sensor->hdr_ctrl =
-		v4l2_ctrl_new_std_menu_items(hdl, ops,
-					     V4L2_CID_HDR_SENSOR_MODE,
-					     ARRAY_SIZE(vd55g1_hdr_menu) - 1, 0,
-					     VD55G1_NO_HDR, vd55g1_hdr_menu);
-	hblank = vd55g1_get_hblank_min(sensor, format, crop);
-	sensor->hblank_ctrl = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_HBLANK,
-						hblank, hblank, 1, hblank);
-	if (sensor->hblank_ctrl)
-		sensor->hblank_ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;
-	vd55g1_get_vblank_limits(sensor, crop, &vblank);
-	sensor->vblank_ctrl = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_VBLANK,
-						vblank.min, vblank.max,
-						1, vblank.def);
-
-	/* Additional controls based on device tree properties */
-	if (sensor->ext_leds_mask) {
-		sensor->led_ctrl =
-			v4l2_ctrl_new_std_menu(hdl, ops,
-					       V4L2_CID_FLASH_LED_MODE,
-					       V4L2_FLASH_LED_MODE_FLASH, 0,
-					       V4L2_FLASH_LED_MODE_NONE);
-	}
-
-	ret = v4l2_fwnode_device_parse(sensor->dev, &fwnode_props);
-	if (ret)
-		goto free_ctrls;
-
-	ret = v4l2_ctrl_new_fwnode_properties(hdl, ops, &fwnode_props);
-	if (ret)
-		goto free_ctrls;
-
-	sensor->sd.ctrl_handler = hdl;
-	goto unlock_state;
-
-free_ctrls:
-	v4l2_ctrl_handler_free(hdl);
-unlock_state:
-	v4l2_subdev_unlock_state(state);
-	return ret;
-}
-
-static int vd55g1_detect(struct vd55g1 *sensor)
-{
-	unsigned int dt_id = (uintptr_t)device_get_match_data(sensor->dev);
-	u64 rev, id;
-	int ret;
-
-	ret = vd55g1_read(sensor, VD55G1_REG_MODEL_ID, &id, NULL);
-	if (ret)
-		return ret;
-
-	if (id != VD55G1_MODEL_ID_VD55G1 && id != VD55G1_MODEL_ID_VD65G4) {
-		dev_warn(sensor->dev, "Unsupported sensor id 0x%x\n",
-			 (u32)id);
-		return -ENODEV;
-	}
-	if (id != dt_id) {
-		dev_err(sensor->dev, "Probed sensor %s and device tree definition (%s) mismatch",
-			VD55G1_MODEL_ID_NAME(id), VD55G1_MODEL_ID_NAME(dt_id));
-		return -ENODEV;
-	}
-	sensor->id = id;
-
-	ret = vd55g1_read(sensor, VD55G1_REG_REVISION, &rev, NULL);
-	if (ret)
-		return ret;
-
-	if ((id == VD55G1_MODEL_ID_VD55G1 && rev != VD55G1_REVISION_CCB) &&
-	    (id == VD55G1_MODEL_ID_VD65G4 && rev != VD55G1_REVISION_BAYER)) {
-		dev_err(sensor->dev, "Unsupported sensor revision 0x%x for sensor %s\n",
-			(u16)rev, VD55G1_MODEL_ID_NAME(id));
-		return -ENODEV;
-	}
-
-	return 0;
-}
-
-static int vd55g1_power_on(struct device *dev)
-{
-	struct v4l2_subdev *sd = dev_get_drvdata(dev);
-	struct vd55g1 *sensor = to_vd55g1(sd);
-	int ret;
-
-	ret = regulator_bulk_enable(ARRAY_SIZE(vd55g1_supply_name),
-				    sensor->supplies);
-	if (ret) {
-		dev_err(dev, "Failed to enable regulators %d\n", ret);
-		return ret;
-	}
-
-	ret = clk_prepare_enable(sensor->xclk);
-	if (ret) {
-		dev_err(dev, "Failed to enable clock %d\n", ret);
-		goto disable_bulk;
-	}
-
-	gpiod_set_value_cansleep(sensor->reset_gpio, 0);
-	usleep_range(5000, 10000);
-	ret = vd55g1_wait_state(sensor, VD55G1_SYSTEM_FSM_READY_TO_BOOT, NULL);
-	if (ret) {
-		dev_err(dev, "Sensor reset failed %d\n", ret);
-		goto disable_clock;
-	}
-
-	ret = vd55g1_detect(sensor);
-	if (ret) {
-		dev_err(dev, "Sensor detect failed %d\n", ret);
-		goto disable_clock;
-	}
-
-	/* Setup clock now to advance through system FSM states */
-	vd55g1_write(sensor, VD55G1_REG_EXT_CLOCK, sensor->xclk_freq, &ret);
-
-	ret = vd55g1_patch(sensor);
-	if (ret) {
-		dev_err(dev, "Sensor patch failed %d\n", ret);
-		goto disable_clock;
-	}
-
-	return 0;
-
-disable_clock:
-	gpiod_set_value_cansleep(sensor->reset_gpio, 1);
-	clk_disable_unprepare(sensor->xclk);
-disable_bulk:
-	regulator_bulk_disable(ARRAY_SIZE(vd55g1_supply_name),
-			       sensor->supplies);
-
-	return ret;
-}
-
-static int vd55g1_power_off(struct device *dev)
-{
-	struct v4l2_subdev *sd = dev_get_drvdata(dev);
-	struct vd55g1 *sensor = to_vd55g1(sd);
-
-	gpiod_set_value_cansleep(sensor->reset_gpio, 1);
-	clk_disable_unprepare(sensor->xclk);
-	regulator_bulk_disable(ARRAY_SIZE(sensor->supplies), sensor->supplies);
-
-	return 0;
-}
-
-static int vd55g1_check_csi_conf(struct vd55g1 *sensor,
-				 struct fwnode_handle *endpoint)
-{
-	struct v4l2_fwnode_endpoint ep = { .bus_type = V4L2_MBUS_CSI2_DPHY };
-	u8 n_lanes;
-	int ret;
-
-	ret = v4l2_fwnode_endpoint_alloc_parse(endpoint, &ep);
-	if (ret)
-		return -EINVAL;
-
-	/* Check lanes number */
-	n_lanes = ep.bus.mipi_csi2.num_data_lanes;
-	if (n_lanes != 1) {
-		dev_err(sensor->dev, "Sensor only supports 1 lane, found %d\n",
-			n_lanes);
-		ret = -EINVAL;
-		goto done;
-	}
-
-	/* Clock lane must be first */
-	if (ep.bus.mipi_csi2.clock_lane != 0) {
-		dev_err(sensor->dev, "Clock lane must be mapped to lane 0\n");
-		ret = -EINVAL;
-		goto done;
-	}
-
-	/* Handle polarities in sensor configuration */
-	sensor->oif_ctrl = (ep.bus.mipi_csi2.lane_polarities[0] << 3) |
-			   (ep.bus.mipi_csi2.lane_polarities[1] << 6);
-
-	/* Check the link frequency set in device tree */
-	if (!ep.nr_of_link_frequencies) {
-		dev_err(sensor->dev, "link-frequency property not found in DT\n");
-		ret = -EINVAL;
-		goto done;
-	}
-	if (ep.nr_of_link_frequencies != 1) {
-		dev_err(sensor->dev, "Multiple link frequencies not supported\n");
-		ret = -EINVAL;
-		goto done;
-	}
-	sensor->link_freq = ep.link_frequencies[0];
-
-done:
-	v4l2_fwnode_endpoint_free(&ep);
-
-	return ret;
-}
-
-static int vd55g1_parse_dt_gpios_array(struct vd55g1 *sensor,
-				       char *prop_name, u32 *array, int *nb)
-{
-	unsigned int i;
-	int ret;
-
-	*nb = device_property_count_u32(sensor->dev, prop_name);
-	if (*nb == -EINVAL) {
-		/* Property not found */
-		*nb = 0;
-		return 0;
-	}
-
-	ret = device_property_read_u32_array(sensor->dev,
-					     prop_name, array, *nb);
-	if (ret) {
-		dev_err(sensor->dev, "Failed to read %s prop\n", prop_name);
-		return ret;
-	}
-	for (i = 0; i < *nb;  i++) {
-		if (array[i] >= VD55G1_NB_GPIOS) {
-			dev_err(sensor->dev, "Invalid GPIO number %d\n",
-				array[i]);
-			return -EINVAL;
-		}
-	}
-
-	return 0;
-}
-
-static int vd55g1_parse_dt_gpios(struct vd55g1 *sensor)
-{
-	u32 led_gpios[VD55G1_NB_GPIOS];
-	int nb_gpios_leds;
-	unsigned int i;
-	int ret;
-
-	/* Initialize GPIOs to default */
-	for (i = 0; i < VD55G1_NB_GPIOS; i++)
-		sensor->gpios[i] = VD55G1_GPIO_MODE_IN;
-	sensor->ext_leds_mask = 0;
-
-	/* Take into account optional 'st,leds' output for GPIOs */
-	ret = vd55g1_parse_dt_gpios_array(sensor, "st,leds", led_gpios,
-					  &nb_gpios_leds);
-	if (ret)
-		return ret;
-
-	for (i = 0; i < nb_gpios_leds; i++) {
-		sensor->gpios[led_gpios[i]] = VD55G1_GPIO_MODE_STROBE;
-		set_bit(led_gpios[i], &sensor->ext_leds_mask);
-	}
-
-	return 0;
-}
-
-static int vd55g1_parse_dt(struct vd55g1 *sensor)
-{
-	struct fwnode_handle *endpoint;
-	int ret;
-
-	endpoint = fwnode_graph_get_endpoint_by_id(dev_fwnode(sensor->dev),
-						   0, 0, 0);
-	if (!endpoint) {
-		dev_err(sensor->dev, "Endpoint node not found\n");
-		return -EINVAL;
-	}
-
-	ret = vd55g1_check_csi_conf(sensor, endpoint);
-	fwnode_handle_put(endpoint);
-	if (ret)
-		return ret;
-
-	return vd55g1_parse_dt_gpios(sensor);
-}
-
-static int vd55g1_subdev_init(struct vd55g1 *sensor)
-{
-	int ret;
-
-	/* Init sub device */
-	sensor->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
-	sensor->sd.internal_ops = &vd55g1_internal_ops;
-
-	/* Init source pad */
-	sensor->pad.flags = MEDIA_PAD_FL_SOURCE;
-	sensor->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
-	ret = media_entity_pads_init(&sensor->sd.entity, 1, &sensor->pad);
-	if (ret) {
-		dev_err(sensor->dev, "Failed to init media entity: %d\n", ret);
-		return ret;
-	}
-
-	sensor->sd.state_lock = sensor->ctrl_handler.lock;
-	ret = v4l2_subdev_init_finalize(&sensor->sd);
-	if (ret) {
-		dev_err(sensor->dev, "Subdev init error: %d\n", ret);
-		goto err_ctrls;
-	}
-
-	/*
-	 * Initialize controls after v4l2_subdev_init_finalize() to make sure
-	 * active state is set
-	 */
-	ret = vd55g1_init_ctrls(sensor);
-	if (ret) {
-		dev_err(sensor->dev, "Controls initialization failed %d\n",
-			ret);
-		goto err_media;
-	}
-
-	return 0;
-
-err_ctrls:
-	v4l2_ctrl_handler_free(sensor->sd.ctrl_handler);
-
-err_media:
-	media_entity_cleanup(&sensor->sd.entity);
-	return ret;
-}
-
-static void vd55g1_subdev_cleanup(struct vd55g1 *sensor)
-{
-	v4l2_async_unregister_subdev(&sensor->sd);
-	v4l2_subdev_cleanup(&sensor->sd);
-	media_entity_cleanup(&sensor->sd.entity);
-	v4l2_ctrl_handler_free(sensor->sd.ctrl_handler);
-}
-
-static int vd55g1_get_regulators(struct vd55g1 *sensor)
-{
-	unsigned int i;
-
-	for (i = 0; i < ARRAY_SIZE(vd55g1_supply_name); i++)
-		sensor->supplies[i].supply = vd55g1_supply_name[i];
-
-	return devm_regulator_bulk_get(sensor->dev,
-				       ARRAY_SIZE(vd55g1_supply_name),
-				       sensor->supplies);
-}
-
-static int vd55g1_probe(struct i2c_client *client)
-{
-	struct device *dev = &client->dev;
-	struct vd55g1 *sensor;
-	int ret;
-
-	sensor = devm_kzalloc(dev, sizeof(*sensor), GFP_KERNEL);
-	if (!sensor)
-		return -ENOMEM;
-	sensor->dev = &client->dev;
-
-	v4l2_i2c_subdev_init(&sensor->sd, client, &vd55g1_subdev_ops);
-
-	ret = vd55g1_parse_dt(sensor);
-	if (ret)
-		return dev_err_probe(dev, ret, "Failed to parse Device Tree\n");
-
-	/* Get (and check) resources : power regs, ext clock, reset gpio */
-	ret = vd55g1_get_regulators(sensor);
-	if (ret)
-		return dev_err_probe(dev, ret, "Failed to get regulators\n");
-
-	sensor->xclk = devm_v4l2_sensor_clk_get(dev, NULL);
-	if (IS_ERR(sensor->xclk))
-		return dev_err_probe(dev, PTR_ERR(sensor->xclk),
-				     "Failed to get xclk\n");
-
-	sensor->xclk_freq = clk_get_rate(sensor->xclk);
-	ret = vd55g1_prepare_clock_tree(sensor);
-	if (ret)
-		return ret;
-
-	sensor->reset_gpio = devm_gpiod_get_optional(dev, "reset",
-						     GPIOD_OUT_HIGH);
-	if (IS_ERR(sensor->reset_gpio))
-		return dev_err_probe(dev, PTR_ERR(sensor->reset_gpio),
-				     "Failed to get reset gpio\n");
-
-	sensor->regmap = devm_cci_regmap_init_i2c(client, 16);
-	if (IS_ERR(sensor->regmap))
-		return dev_err_probe(dev, PTR_ERR(sensor->regmap),
-				     "Failed to init regmap\n");
-
-	/* Detect if sensor is present and if its revision is supported */
-	ret = vd55g1_power_on(dev);
-	if (ret)
-		return ret;
-
-	/* Enable pm_runtime and power off the sensor */
-	pm_runtime_set_active(dev);
-	pm_runtime_get_noresume(dev);
-	pm_runtime_enable(dev);
-	pm_runtime_set_autosuspend_delay(dev, 4000);
-	pm_runtime_use_autosuspend(dev);
-	pm_runtime_put_autosuspend(dev);
-
-	ret = vd55g1_subdev_init(sensor);
-	if (ret) {
-		dev_err(dev, "V4l2 init failed: %d\n", ret);
-		goto err_power_off;
-	}
-
-	ret = v4l2_async_register_subdev(&sensor->sd);
-	if (ret) {
-		dev_err(dev, "async subdev register failed %d\n", ret);
-		goto err_subdev;
-	}
-
-	return 0;
-
-err_subdev:
-	vd55g1_subdev_cleanup(sensor);
-err_power_off:
-	pm_runtime_disable(dev);
-	pm_runtime_put_noidle(dev);
-	pm_runtime_dont_use_autosuspend(dev);
-	vd55g1_power_off(dev);
-
-	return ret;
-}
-
-static void vd55g1_remove(struct i2c_client *client)
-{
-	struct v4l2_subdev *sd = i2c_get_clientdata(client);
-	struct vd55g1 *sensor = to_vd55g1(sd);
-
-	vd55g1_subdev_cleanup(sensor);
-
-	pm_runtime_disable(&client->dev);
-	if (!pm_runtime_status_suspended(&client->dev))
-		vd55g1_power_off(&client->dev);
-	pm_runtime_set_suspended(&client->dev);
-	pm_runtime_dont_use_autosuspend(&client->dev);
-}
-
-static const struct of_device_id vd55g1_dt_ids[] = {
-	{ .compatible = "st,vd55g1", .data = (void *)VD55G1_MODEL_ID_VD55G1 },
-	{ .compatible = "st,vd65g4", .data = (void *)VD55G1_MODEL_ID_VD65G4 },
-	{ /* sentinel */ }
-};
-MODULE_DEVICE_TABLE(of, vd55g1_dt_ids);
-
-static const struct dev_pm_ops vd55g1_pm_ops = {
-	SET_RUNTIME_PM_OPS(vd55g1_power_off, vd55g1_power_on, NULL)
-};
-
-static struct i2c_driver vd55g1_i2c_driver = {
-	.driver = {
-		.name  = "vd55g1",
-		.of_match_table = vd55g1_dt_ids,
-		.pm = &vd55g1_pm_ops,
-	},
-	.probe = vd55g1_probe,
-	.remove = vd55g1_remove,
-};
-
-module_i2c_driver(vd55g1_i2c_driver);
-
-MODULE_AUTHOR("Benjamin Mugnier <benjamin.mugnier@foss.st.com>");
-MODULE_AUTHOR("Sylvain Petinot <sylvain.petinot@foss.st.com>");
-MODULE_DESCRIPTION("VD55G1 camera subdev driver");
-MODULE_LICENSE("GPL");
-- 
2.55.0