From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BF8F50C299 for ; Thu, 3 Sep 2026 20:10:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788466259; cv=none; b=pu2UqADgxID6ls2n67hLoXpI4Ust/uEbkJsfHFBJgrHdBRzeBAB3oOtfMqdHmdEQn+njLec3TlvFZ5dKVeEA88sCv/0XTmm1DGxBjK1eeAzC/zvBDuWIJmI6oeg9y+Fa6nzscSAzyK5chwV14gXpI/HJYJyz52hmtiun2bpQUvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788466259; c=relaxed/simple; bh=cBLkstfZV7FeSnmOp5Vv8t6GcefvtRBwmlxcw1AND1k=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I9Qdgc48LSuIenI+K2MKVEX2tCsXn/KSmQOkBGzyUQVncFObec0VMtIC8i2HmmKeGJ43XwYWwEz7jgIneShTbmFgBjKZpUw+mKPCWkCG0fxn9M8jJlNn8s0SDkM7+kRkGKA4DrJPwn8qcCrNNnquBFarfW2WtE5hQUUOxpFKePk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=O7BMAxjP; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="O7BMAxjP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788466249; x=1820002249; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=cBLkstfZV7FeSnmOp5Vv8t6GcefvtRBwmlxcw1AND1k=; b=O7BMAxjPrtfl/HXiJd3R6m6hJ6f/EU7qnbjc/JCGTBqKtiqQYGuQLB3y XYXFpWxz/IF3/z7D7fBeP4XqwgKv1xeYCdT0FH+Vr2ia02f9FCG27UJ5U /di+1auzKtqrL1TPQZFT9DCh7YeLEopeaYYv82+SU9kaD/7UxFD++smed u8hHsNCPfvxtEHxjB/FnHL2mi/NFyPDyQMczW8JXKszUIXMdeM0fzx8xQ nxSh810IKBUQ4UbXBDIo3AaTKzSMT6dQ9nde8L7Gu2LM90wO8nLT9neHr fetFh2nJdM9h2z/WNucTulbWVvuZgL9Uu1yGaLw2FVhgI9ijNf+K6Pfn6 A==; X-CSE-ConnectionGUID: Ty4aZzeUSTWLjDcK6PaPew== X-CSE-MsgGUID: ZwzxPaS2SgO70MdZSdDK/g== X-IronPort-AV: E=McAfee;i="6800,10657,11895"; a="88994605" X-IronPort-AV: E=Sophos;i="6.25,260,1779174000"; d="scan'208";a="88994605" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2026 13:10:37 -0700 X-CSE-ConnectionGUID: vjnHy0+DRyewPWz4YJCV2Q== X-CSE-MsgGUID: 6+sz1rbkScaK4SsNCTxilA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,260,1779174000"; d="scan'208";a="273348136" Received: from mjruhl-vm.amr.corp.intel.com ([10.11.186.166]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2026 13:10:26 -0700 From: "Michael J. Ruhl" To: platform-driver-x86@vger.kernel.org, intel-xe@lists.freedesktop.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, matthew.brost@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, airlied@gmail.com, simona@ffwll.ch, david.e.box@linux.intel.com, anoop.c.vijay@intel.com, badal.nilawar@intel.com, matthew.d.roper@intel.com, james.ausmus@intel.com, karthik.poosa@intel.com Subject: [PATCH v5 08/18] drm/xe/vsec: Use correct pm state get Date: Thu, 3 Sep 2026 13:10:10 -0700 Message-ID: <20260903201002.1064889-28-michael.j.ruhl@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260903201002.1064889-20-michael.j.ruhl@intel.com> References: <20260903201002.1064889-20-michael.j.ruhl@intel.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Crashlog needs to be collected at all times. The current pm check assumes telemetry only. Update read path to enable device for crashlog instances. Include check of the WATCHER CAP_TYPE for completeness. WATCHER is a possible type and needs to be accounted for, but is not supported. Signed-off-by: Michael J. Ruhl Fixes: 2c402a801c19 ("platform/x86/intel/pmt: support BMG crashlog") --- drivers/gpu/drm/xe/xe_vsec.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c index dd7723ba6c1c..468a221378fa 100644 --- a/drivers/gpu/drm/xe/xe_vsec.c +++ b/drivers/gpu/drm/xe/xe_vsec.c @@ -145,6 +145,7 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse { struct xe_device *xe = kdev_to_xe_device(dev); void __iomem *telem_addr = xe->mmio.regs + BMG_TELEMETRY_OFFSET; + u32 cap_type = FIELD_GET(GUID_CAP_TYPE, guid); u32 mem_region; u32 offset; int ret; @@ -158,9 +159,18 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse telem_addr += offset + user_offset; - /* indicate that we are not at an appropriate power level */ - if (!xe_pm_runtime_get_if_active(xe)) - return -ENODATA; + /* Always allow crashlog. Telemetry, only when powered */ + switch (cap_type) { + case CRASHLOG: + xe_pm_runtime_get(xe); + break; + case TELEMETRY: + if (!xe_pm_runtime_get_if_active(xe)) + return -ENODATA; + break; + case WATCHER: + return -EINVAL; + } mutex_lock(&xe->pmt.lock); -- 2.43.0