From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9319D3939CE for ; Tue, 15 Sep 2026 12:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789476544; cv=none; b=oqsM2g/UBKYBZm0E+CQgl6nbS7Enk1uky/G9Bfo86xU3yzhbtD9zNTD/wqmeLjo7FRer9wzkVA+AswNnMZMihHkDts9P/7p/gnJfr/OyTXJL0foASihzBfSk5qRIUse0PMQ5yGrlJLGPjU4k+Bre6ECruaBXAQi1/g4xmbOPd1U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789476544; c=relaxed/simple; bh=YFHzDuiSQXSIMebzDRCSKEz0SUhCBqu8HZ+JLzlNMtI=; h=From:To:Cc:Subject:Date:Message-Id; b=ki0PLqrY95G5rcXvlfwjRqdVN5dfG11eYG3QBr1U+fjOSI3HsKoOneH6E921FUpPb1I2E6n9H/rx7y/94PH2QXhs46dH8McnrdSyEsulaPteMKKgc9FLXoNcF+z7IFX+6vp86DptwOTn48x5WhhTVWDOiNVGZhHFSg2bT/R4/tA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DFb7u2Tr; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DFb7u2Tr" Received: by mail-pj2-f12.google.com with SMTP id d9443c01a7336-2d747ed1368so31515185ad.1 for ; Tue, 15 Sep 2026 05:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789476542; x=1790081342; darn=vger.kernel.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=K4NEyPUzdcskfuL6SgD4LKloEIz4xPCUOIfMYZX8ltY=; b=DFb7u2TrVWtDC6Qq5VonQ5y2Eno7vf7CBQVoAV63ywLB9WT0T+27nkyA6yjSyunuX9 ZUMSh76lb9z3WI87LNmWa5FIO1PoORJpclzrDvxLY+EpECdFtRyw2RF0/zdsI2Bgr45+ JdEJV4nb78TfntkjcgwYUZOrRI1qzSoW+D8J9yDZtY82hh/ABfe0NDCiBvdoerTYcd2F urRnaPBZnfrq74XuRUX97vWmpv6dYpqTvwgoE5/GC3r309s3WZwSqS/JyNIh/jxIP5SU 3DOs13v36CcG5FSs9EnzSxfdBkqRNNoHpLRt6fWeG0YNwClKyvfAon1GjPllksjonoEe qYnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789476542; x=1790081342; h=message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=K4NEyPUzdcskfuL6SgD4LKloEIz4xPCUOIfMYZX8ltY=; b=SHXgFjvAoQ/4yb82WpE6mfazbRkDSa0B3EY2vDXTfPivMmc1h3oq9je3PxgFsMkdXQ 4pQscp9t3Tc2F+w9mQEjWZcc46FIhPaEQmD5lWTyg9kajwz5SFeZqwhjFGkv48aOKcUc +xPFEdoeyMgPViAAc2ysdIDYw3rtxNplKc4c0gK+4S3DENPS9gav+nDLinjlUFPO6Vaz ud+GgVDvR7qHmZpkaH/TV56dyllMqzUXGCaWED+itAsn5yOfDyfRtjv54gaYnz8SovGl 5C5uP/JvzML9qcGn6Y184utcc33SEMEMjn6of78CGYNr4TNCyFbIVPn3n2RFGJtOO/31 VHew== X-Forwarded-Encrypted: i=1; AKwUvBxmcp7FJHtcmeVwbK8Oalflps6Fa2Sy6gBTKQOGcr8niNdqznhXHBWthdAlOXuO+KZ5gDxN4TEVU01oKanUNpTIPlJw@vger.kernel.org X-Gm-Message-State: AFuF++mgXE4w4jylnyaqpbsW85vYVgkPLKctNw0eE/e80+16gnA6hM+D /sthpIzMr99cOq3Rz9Y5NKUc+dmOEosULqgZhYk0OPFNPfLUKSFOpXsR X-Gm-Gg: AYBFou1c3ZD6qDfr75hc5eI0EkhvdLsrzr+4aOzJOaboMNKHB1mdeFMk+JfmX2IoZgL U0sMwViFUcEu08hNZgUU63lsQ/rMbksXJSrM2akcsMjp/cMEFJztoTlaMWJQSkpd19u3fM6ed2V 9LODriJSAtl6kAXVGfP7j2F6k2dX6lGMnC+VRa+L6bOQhNEiW171OzMRy0b7b/+AxWv8dW2d68g MpnH+wC4Z8T/2kwS+Uj2b/tJlRQiVVDSV230Gyne0VyGvu7FYL/aZx+QqyBCtyj9rn1gFCr8Y3n nwepoysvPer6h7dJQ06hipC12wvCZQoqfezqfwyD40F+w8S1REQ1SEKpaBK/fRcdWDfMOWGzWVR zvFYGLYBmQ05uls6Zh4cDLPRKidlWGESUpjbtsQEZVNyXOFPznb4VlvC1+O2Lhwkaghc6PMH4Xv myUgB9APQEbSFEdGnZFvp3jNYr2rDSkKYC+hQzsZzx4CcZkk0f6xGVC5I5TaVkyUx0NRONvg== X-Received: by 2002:a17:903:11cf:b0:2db:733c:fd1f with SMTP id d9443c01a7336-2dd6c5ee698mr129931065ad.8.1789476541491; Tue, 15 Sep 2026 05:49:01 -0700 (PDT) Received: from [127.0.1.1] ([240e:b8f:91e2:d400:ec2a:b15e:fef8:70a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2dd48ae3cacsm52866095ad.26.2026.09.15.05.48.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 05:49:00 -0700 (PDT) From: Liang Haowen To: linux-leds@vger.kernel.org Cc: Lee Jones , Pavel Machek , Martin K. Petersen , linux-scsi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Denis Benato , Armin Wolf , Hans de Goede , Ilpo Jarvinen Subject: [PATCH RFC v4 0/1] leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures Date: Tue, 15 Sep 2026 12:48:57 -0000 Message-Id: <202609152112.RFCv4-0.lhw@gmail.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Hello, v4, sent as its own thread this time, addressing the third sashiko review round (the Medium naming item is a real bug, the two Low ones are false positives again). Changes since v3: - LED class device names follow the devicename:color:function scheme again. v3 embedded the sdev's H:C:T:L verbatim (asus-arion-0:0:0:0:led0); the extra colons break the single separator userspace parses LED names with. The colons are now flattened to dashes (asus-arion-0-0-0-0:led0), keeping the per-attachment uniqueness while leaving exactly one separator. The two low-severity items are the same false positives as before: - kzalloc_obj() exists in include/linux/slab.h since v7.0 (Kees Cook's overflow-refactor series); this driver builds against 7.2. - blk_rq_map_kern() takes four arguments on current kernels (rq, buf, len, gfp); drivers/scsi/scsi_lib.c calls it exactly this way from scsi_execute_cmd(). v4 was re-verified on hardware: per-LED colours, 100 sequential updates, concurrent updates from four writers, and unplug under load (zero splats, zero leaked LED nodes, clean rmmod). Everything else is unchanged: the hardware description, the scsi_device_handler that does not claim the sdev, the multicolor LED interface, the protocol handling and the known caveats (manual attach until a notifier lands; SAVE on every update writes the enclosure flash, wear uncharacterized; NULL-parent LED registration to avoid the sdev reference cycle). The open question from v3 stands: the driver is deliberately not wired into Kconfig/Makefile/MAINTAINERS yet, because the agreed direction with the SCSI side is a split into a SCSI transport helper and a shared ASUS Aura LED interface, and the wiring would follow that shape. Is deferring the wiring to that split acceptable for an RFC, or would you rather have the driver buildable in-tree from this series already? Comments on the interface shape and on folding this into the shared Aura work with Denis remain very welcome. Signed-off-by: Liang Haowen