From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2301A4F68BC for ; Mon, 28 Sep 2026 20:03:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790625823; cv=none; b=jh4uE6R2kN9ni5fmKZW4aP/xp6Ph2EC8Y7eTgQLelyaZFYftrw2LEY9DGBWtR4SwXrZqczXevSBv8julbMImYyKrmpwmpxCusY06L/dGKDmOb+8z5BWIArqbX8vgzGHMNvNpnbJBRuifVfrza3ku17kQPGVQcMv6t0tolyJlLTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790625823; c=relaxed/simple; bh=YEdYxhIApJRRb/H+xRmCLt5a3CHQQvc9rbOlS/lYSJc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rdkd+COQ5snWA2wocFodyRJsfW/G8KJf/EJncSKR5lE/xiieAzpCdc3vtut8eoG54KhJbji/iJ2nif7HE90RKjaI58K8Hit13dfRkNdBorZZmPeH0oLh3USmd1ojWxCM0D1LL44Ql6nbYJ6vbbdz9OrTfOXKMeX4RUb1krtRZRo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SkjJXmHg; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SkjJXmHg" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49fff72474fso11519585e9.3 for ; Mon, 28 Sep 2026 13:03:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790625818; x=1791230618; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NgJAjv7LJOWIoyDAobDDwkG2YUEnWGXF9w9IGSvXkDU=; b=SkjJXmHgIja2q+F/rvbLbxTP/oI09tRaKrKqTzfZAR1n+ceO9E97UZZK/9TrfyiUfo xCo3Bk+t3gp+ie/lDLpgT5yYYjHxT1Kbcc03YWyK7SBbcNz13WinK7YwRJgXzEEYyqhN 7OjkuZD8UJp+KlpA3JrUm8rwPIos1gTgWDPy4apcYs0EQmzIxhnJnFKVetfKAZ6YFF50 MxFBDvSrLP8g0tnkiaGM9uwWijvK2+VF/eSv15VB/jWkTvxM0zsKL4i38sejNpr+DhJ9 CH3y8T45O5avuhQdLe972qsf5rOF/CAL/x1NCA4snv2GSCyBps3GSFsC0m4gMKheTbqC P88Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790625818; x=1791230618; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NgJAjv7LJOWIoyDAobDDwkG2YUEnWGXF9w9IGSvXkDU=; b=zAU/R7Al3cSMMuP/SEVSQF05C1KB3RNMI0MNw0vCaIQkCSZgF7dFmMlVlnAOJHVFG2 y18oh5G+pEzV6axih6C3mzRM2Hpvn83rAnwarpopTTzLh4dF9SC0T+1sWNL7GAR1R+Y2 jyCAR0y01WYAOD9cDynbz2CoEmkTNirPHA70Sb5kQ0Er0Qk9x4e6uwm1gzgKzWLoOfc1 vTwQf4nd/T1fdebm3+KVYPLVqmbLke8wT25XMHP4J73r2pENJH9gUBKQJ3NqxbWLGPvC PaZ9EfjHq8zqejeR2vGPMIsCWcpl73f14kVGdPHj2EWoh/mi4cLUUp1i8Jmo5OL2m+gv OOQQ== X-Forwarded-Encrypted: i=1; AKwUvBwQSS4Bup8UJG4KZ9bbH89xfUmYjI/Ass0CFNJWLZJDJHrfv6fPkQ9SFYHtL9Swihnn5DG/ovJN4foJjv4PMdV3/teV@vger.kernel.org X-Gm-Message-State: AFuF++mUjKTEEgyDc/3MSqhvPn8ZL7AOWTiouGL/p6AEIW1fP3dw4GkX 80PXBIr2EB3hLKJnSXoqqXfOwFOCc2PEU8rr8xz0gToNAc27s0gayMM5xCG4Jl/sZwSmug== X-Gm-Gg: AYBFou20mymDxopl9UtkKyidBvQ8ZSjceg3RH5Tq/w1wWYiMu43P0DrTXTmIOqM7tBs 60xrEAcdp6WX6qU39O/uEyedav2rC3xuCx8VGoyBMBf1rMECxwInTOBPUnXGEJ9IN/hYDxHhyjC r7GJnJ5b+UBqu2fiW3/bQcQlKpsfWJJn0WfARKHChxg+u7fi3CeVyp5ND0nfMbbkjY4iaksibId ZpQo1soH6iZmidzm5jeXkhvhzuPdjd8KSUYr2XtO520IzUyQWUN3IXZeSsSBW6AkIDh4zPKxjgj GM7WuNLnIh0XRGDGDTYg8EGtuqqs2H+omFkf2eCRRt78pyqEa0jy9SPsRbF2c+LOTmhYl/PeSbT ZW0aRfaj04UsbXKB/Ea/ayVAT8YYN89akDcSfCF+e8B8d6H8RTa3E8lnxlKDiqk9jHRcfsgaPcP GznfdAzsKAbqPPOJumma/mqYVX/Fe6dbjiVWSeeROYps6QoN+kFtjmtN9TMz0uxh2lcIOM/P/PE XpbrxirfAMXJYEvJ2EAY5m0sEXjBd6i7FeRES68uY4lp4rE/Ahf X-Received: by 2002:a05:600c:8a1a:20b0:49f:f0bd:1e40 with SMTP id 5b1f17b1804b1-49ff0bd1ea8mr132227285e9.23.1790625818398; Mon, 28 Sep 2026 13:03:38 -0700 (PDT) Received: from fedora ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a00c0730a8sm26506625e9.0.2026.09.28.13.03.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2026 13:03:37 -0700 (PDT) From: Muhammad Bilal To: Jorge Lopez , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Muhammad Bilal Subject: [PATCH v2 3/3] platform/x86: hp-bioscfg: return -ERANGE from validate_password_input() Date: Tue, 29 Sep 2026 01:03:18 +0500 Message-ID: <20260928200318.63383-4-meatuni001@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260928200318.63383-1-meatuni001@gmail.com> References: <20260928200318.63383-1-meatuni001@gmail.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit validate_password_input() returns INVALID_BIOS_AUTH (0x0E, positive) on rejection. store_password_instance() skips the store on nonzero ret, but its final "return ret < 0 ? ret : count" treats the positive value as success, so userspace sees count instead of an error. Return -ERANGE, matching the sibling validators for string, enumeration, and integer attribute types. Tested on HP EliteBook 840 G2 (Fedora 44, Linux 7.2.7): writing 999 bytes to current_password returned 999 with no error before this fix. Fixes: 8646a3b5ee3a ("platform/x86: hp-bioscfg: passwdobj-attributes") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- Changes in v2: - New patch in this series. drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c index 9b989ef756ea..b1c687fb4700 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c @@ -70,12 +70,12 @@ static int validate_password_input(int instance_id, const char *buf) length--; if (length > MAX_PASSWD_SIZE) - return INVALID_BIOS_AUTH; + return -ERANGE; if (password_data->min_password_length > length || password_data->max_password_length < length) - return INVALID_BIOS_AUTH; - return SUCCESS; + return -ERANGE; + return 0; } ATTRIBUTE_N_PROPERTY_SHOW(is_enabled, password); -- 2.55.0