Re: [PATCH v2 1/2] platform/x86: thinkpad_acpi: Add support to detect hardware damage detection capability.

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Tue, 16 Dec 2025, Nitin wrote:

> Hello ,
> 
> On 12/16/25 10:19, kernel test robot wrote:
> > Hi Nitin,
> > 
> > kernel test robot noticed the following build warnings:
> > 
> > [auto build test WARNING on linus/master]
> > [also build test WARNING on v6.19-rc1 next-20251215]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> > 
> > url:
> > https://github.com/intel-lab-lkp/linux/commits/Nitin-Joshi/platform-x86-thinkpad_acpi-Add-sysfs-to-display-details-of-damaged-device/20251210-231409
> > base:   linus/master
> > patch link:
> > https://lore.kernel.org/r/20251210151133.7933-1-nitjoshi%40gmail.com
> > patch subject: [PATCH v2 1/2] platform/x86: thinkpad_acpi: Add support to
> > detect hardware damage detection capability.
> > reproduce:
> > (https://download.01.org/0day-ci/archive/20251216/202512160219.94nMjvxO-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version
> > of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes:
> > https://lore.kernel.org/oe-kbuild-all/202512160219.94nMjvxO-lkp@intel.com/
> 
> Thank you for reporting this issue and I will fix this issue .
> 
> I have already send patch v3 for this and will fix this warning in next patch
> version i.e v4 .
> 
> May i know, if its OK to add this Reported-by and closes tag in patch version
> v4 ?

Hi,

Please only add those tags when you're fixing code that exists in a repo 
already. For new work, we don't normally add lkp report tags despite the 
email suggesting you to do so (I know it's a bit confusing but it's sort 
of same as we don't normally mention all reviewers who gave improvement 
suggestions either).

> > All warnings (new ones prefixed by >>):
> > 
> >     WARNING: No kernel-doc for file ./include/linux/pci.h
> >     ERROR: Cannot find file ./include/linux/mod_devicetable.h
> >     WARNING: No kernel-doc for file ./include/linux/mod_devicetable.h
> >     ERROR: Cannot find file ./include/linux/bootconfig.h
> >     WARNING: No kernel-doc for file ./include/linux/bootconfig.h
> > > > Documentation/admin-guide/laptops/thinkpad-acpi.rst:1581: WARNING: Title
> > > > underline too short.
> > --
> >     Hardware damage detection capability
> >     ----------------- [docutils]
> > > > Documentation/admin-guide/laptops/thinkpad-acpi.rst:1581: WARNING: Title
> > > > underline too short.
> 
> Ack. Thank you !
> 
> > 
> > vim +1581 Documentation/admin-guide/laptops/thinkpad-acpi.rst
> > 
> >    1579	
> >    1580	Hardware damage detection capability
> > > 1581	-----------------
> >    1582	
> > 
> 

-- 
 i.