From: Tom Lendacky <thomas.lendacky@amd.com>
To: "Mario Limonciello (AMD)" <superm1@kernel.org>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: John Allen <john.allen@amd.com>,
"David S . Miller" <davem@davemloft.net>,
Hans de Goede <hansg@kernel.org>,
"open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER"
<linux-crypto@vger.kernel.org>,
"open list:AMD PMF DRIVER" <platform-driver-x86@vger.kernel.org>,
Lars Francke <lars.francke@gmail.com>
Subject: Re: [PATCH v2 0/4] Fixes for PMF and CCP drivers after S4
Date: Thu, 11 Dec 2025 16:23:05 -0600 [thread overview]
Message-ID: <27406dfa-6eb4-47d1-93d9-709dc6b893fc@amd.com> (raw)
In-Reply-To: <20251211212847.11980-1-superm1@kernel.org>
On 12/11/25 15:28, Mario Limonciello (AMD) wrote:
> Lars Francke reported that the PMF driver fails to work afer S4 with:
> ccp 0000:c3:00.2: tee: command 0x5 timed out, disabling PSP
>
> This is because there is a TA loaded to the TEE environment that
> is lost during S4. The TEE rings need to be reinitialized and the
> TA needs to be reloaded.
>
> This series adds those flows to the PMF and CCP drivers.
You should also include Rijo Thomas <Rijo-john.Thomas@amd.com> on this
series.
Thanks,
Tom
>
> ---
> v2:
> * Fixes for potential race conditions in hibernate resume
> * Fix for error handling if tee ring is never destroyed
> * Fixes for dead PSP (which can lead to hangs)
> * Fixes for LKP robot reported issues
>
> Mario Limonciello (AMD) (3):
> crypto: ccp - Declare PSP dead if PSP_CMD_TEE_RING_INIT fails
> crypto: ccp - Send PSP_CMD_TEE_RING_DESTROY when PSP_CMD_TEE_RING_INIT
> fails
> crypto: ccp - Add an S4 restore flow
>
> Shyam Sundar S K (1):
> platform/x86/amd/pmf: Prevent TEE errors after hibernate
>
> drivers/crypto/ccp/sp-dev.c | 13 ++++++
> drivers/crypto/ccp/sp-dev.h | 1 +
> drivers/crypto/ccp/sp-pci.c | 16 ++++++-
> drivers/crypto/ccp/tee-dev.c | 17 ++++++++
> drivers/crypto/ccp/tee-dev.h | 6 +++
> drivers/platform/x86/amd/pmf/core.c | 62 ++++++++++++++++++++++++++-
> drivers/platform/x86/amd/pmf/pmf.h | 10 +++++
> drivers/platform/x86/amd/pmf/tee-if.c | 12 ++----
> 8 files changed, 126 insertions(+), 11 deletions(-)
>
prev parent reply other threads:[~2025-12-11 22:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 21:28 [PATCH v2 0/4] Fixes for PMF and CCP drivers after S4 Mario Limonciello (AMD)
2025-12-11 21:28 ` [PATCH v2 1/4] platform/x86/amd/pmf: Prevent TEE errors after hibernate Mario Limonciello (AMD)
2025-12-11 21:28 ` [PATCH v2 2/4] crypto: ccp - Declare PSP dead if PSP_CMD_TEE_RING_INIT fails Mario Limonciello (AMD)
2025-12-11 21:28 ` [PATCH v2 3/4] crypto: ccp - Add an S4 restore flow Mario Limonciello (AMD)
2025-12-11 22:03 ` Tom Lendacky
2025-12-11 21:28 ` [PATCH v2 4/4] crypto: ccp - Send PSP_CMD_TEE_RING_DESTROY when PSP_CMD_TEE_RING_INIT fails Mario Limonciello (AMD)
2025-12-11 22:21 ` Tom Lendacky
2025-12-13 19:05 ` Shyam Sundar S K
2025-12-11 22:23 ` Tom Lendacky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27406dfa-6eb4-47d1-93d9-709dc6b893fc@amd.com \
--to=thomas.lendacky@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=davem@davemloft.net \
--cc=hansg@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=john.allen@amd.com \
--cc=lars.francke@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox