From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: rjingar <rajvi.jingar@linux.intel.com>
Cc: irenic.rajneesh@gmail.com, david.e.box@intel.com,
Hans de Goede <hdegoede@redhat.com>,
markgross@kernel.org, platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] platform/x86/intel/pmc: Fix in pmc_core_ssram_get_pmc()
Date: Mon, 18 Dec 2023 14:08:34 +0200 (EET) [thread overview]
Message-ID: <292ed49e-cb34-7ca8-dbb5-a25857c75ef2@linux.intel.com> (raw)
In-Reply-To: <20231216011702.1976408-1-rajvi.jingar@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]
On Fri, 15 Dec 2023, rjingar wrote:
> From: Rajvi Jingar <rajvi.jingar@linux.intel.com>
>
> Passing PMC_IDX_MAIN in pmc_core_pmc_add() adds only primary pmc to pmcdev.
> Use pmc_idx instead to add all available pmcs.
>
> Fixes: a01486dc4bb1 ("platform/x86/intel/pmc: Cleanup SSRAM discovery")
> Signed-off-by: Rajvi Jingar <rajvi.jingar@linux.intel.com>
> ---
> drivers/platform/x86/intel/pmc/core_ssram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/pmc/core_ssram.c b/drivers/platform/x86/intel/pmc/core_ssram.c
> index 3501c7bd6b33..55e54207987c 100644
> --- a/drivers/platform/x86/intel/pmc/core_ssram.c
> +++ b/drivers/platform/x86/intel/pmc/core_ssram.c
> @@ -287,7 +287,7 @@ pmc_core_ssram_get_pmc(struct pmc_dev *pmcdev, int pmc_idx, u32 offset)
> if (!map)
> return -ENODEV;
>
> - return pmc_core_pmc_add(pmcdev, pwrm_base, map, PMC_IDX_MAIN);
> + return pmc_core_pmc_add(pmcdev, pwrm_base, map, pmc_idx);
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2023-12-18 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 1:17 [PATCH 2/2] platform/x86/intel/pmc: Fix in pmc_core_ssram_get_pmc() rjingar
2023-12-18 12:08 ` Ilpo Järvinen [this message]
2023-12-18 14:00 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=292ed49e-cb34-7ca8-dbb5-a25857c75ef2@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=david.e.box@intel.com \
--cc=hdegoede@redhat.com \
--cc=irenic.rajneesh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajvi.jingar@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox