From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Chen Ni <nichen@iscas.ac.cn>,
sre@kernel.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform: arm64: thinkpad-t14s-ec: Convert comma to semicolon
Date: Fri, 26 Sep 2025 09:21:17 +0100 [thread overview]
Message-ID: <2c915fe6-a6c4-4814-a7ba-8f9682775951@linaro.org> (raw)
In-Reply-To: <20250926014345.651176-1-nichen@iscas.ac.cn>
On 26/09/2025 02:43, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/platform/arm64/lenovo-thinkpad-t14s.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/arm64/lenovo-thinkpad-t14s.c b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
> index f721763e13cc..1d5d11adaf32 100644
> --- a/drivers/platform/arm64/lenovo-thinkpad-t14s.c
> +++ b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
> @@ -401,14 +401,14 @@ static int t14s_kbd_audio_led_probe(struct t14s_ec *ec)
> int ret;
>
> ec->led_mic_mute.name = "platform::micmute";
> - ec->led_mic_mute.max_brightness = 1,
> - ec->led_mic_mute.default_trigger = "audio-micmute",
> + ec->led_mic_mute.max_brightness = 1;
> + ec->led_mic_mute.default_trigger = "audio-micmute";
> ec->led_mic_mute.brightness_set_blocking = t14s_mic_mute_led_set;
> ec->led_mic_mute.brightness_get = t14s_mic_mute_led_get;
>
> ec->led_spk_mute.name = "platform::mute";
> - ec->led_spk_mute.max_brightness = 1,
> - ec->led_spk_mute.default_trigger = "audio-mute",
> + ec->led_spk_mute.max_brightness = 1;
> + ec->led_spk_mute.default_trigger = "audio-mute";
> ec->led_spk_mute.brightness_set_blocking = t14s_spk_mute_led_set;
> ec->led_spk_mute.brightness_get = t14s_spk_mute_led_get;
>
This definitely deserves a Fixes tag.
Then add
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
prev parent reply other threads:[~2025-09-26 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 1:43 [PATCH] platform: arm64: thinkpad-t14s-ec: Convert comma to semicolon Chen Ni
2025-09-26 8:21 ` Bryan O'Donoghue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c915fe6-a6c4-4814-a7ba-8f9682775951@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).