* [PATCH] platform: arm64: thinkpad-t14s-ec: Convert comma to semicolon
@ 2025-09-26 1:43 Chen Ni
2025-09-26 8:21 ` Bryan O'Donoghue
0 siblings, 1 reply; 2+ messages in thread
From: Chen Ni @ 2025-09-26 1:43 UTC (permalink / raw)
To: sre, hansg, ilpo.jarvinen, bryan.odonoghue
Cc: platform-driver-x86, linux-kernel, Chen Ni
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/platform/arm64/lenovo-thinkpad-t14s.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/arm64/lenovo-thinkpad-t14s.c b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
index f721763e13cc..1d5d11adaf32 100644
--- a/drivers/platform/arm64/lenovo-thinkpad-t14s.c
+++ b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
@@ -401,14 +401,14 @@ static int t14s_kbd_audio_led_probe(struct t14s_ec *ec)
int ret;
ec->led_mic_mute.name = "platform::micmute";
- ec->led_mic_mute.max_brightness = 1,
- ec->led_mic_mute.default_trigger = "audio-micmute",
+ ec->led_mic_mute.max_brightness = 1;
+ ec->led_mic_mute.default_trigger = "audio-micmute";
ec->led_mic_mute.brightness_set_blocking = t14s_mic_mute_led_set;
ec->led_mic_mute.brightness_get = t14s_mic_mute_led_get;
ec->led_spk_mute.name = "platform::mute";
- ec->led_spk_mute.max_brightness = 1,
- ec->led_spk_mute.default_trigger = "audio-mute",
+ ec->led_spk_mute.max_brightness = 1;
+ ec->led_spk_mute.default_trigger = "audio-mute";
ec->led_spk_mute.brightness_set_blocking = t14s_spk_mute_led_set;
ec->led_spk_mute.brightness_get = t14s_spk_mute_led_get;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform: arm64: thinkpad-t14s-ec: Convert comma to semicolon
2025-09-26 1:43 [PATCH] platform: arm64: thinkpad-t14s-ec: Convert comma to semicolon Chen Ni
@ 2025-09-26 8:21 ` Bryan O'Donoghue
0 siblings, 0 replies; 2+ messages in thread
From: Bryan O'Donoghue @ 2025-09-26 8:21 UTC (permalink / raw)
To: Chen Ni, sre, hansg, ilpo.jarvinen; +Cc: platform-driver-x86, linux-kernel
On 26/09/2025 02:43, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/platform/arm64/lenovo-thinkpad-t14s.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/arm64/lenovo-thinkpad-t14s.c b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
> index f721763e13cc..1d5d11adaf32 100644
> --- a/drivers/platform/arm64/lenovo-thinkpad-t14s.c
> +++ b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
> @@ -401,14 +401,14 @@ static int t14s_kbd_audio_led_probe(struct t14s_ec *ec)
> int ret;
>
> ec->led_mic_mute.name = "platform::micmute";
> - ec->led_mic_mute.max_brightness = 1,
> - ec->led_mic_mute.default_trigger = "audio-micmute",
> + ec->led_mic_mute.max_brightness = 1;
> + ec->led_mic_mute.default_trigger = "audio-micmute";
> ec->led_mic_mute.brightness_set_blocking = t14s_mic_mute_led_set;
> ec->led_mic_mute.brightness_get = t14s_mic_mute_led_get;
>
> ec->led_spk_mute.name = "platform::mute";
> - ec->led_spk_mute.max_brightness = 1,
> - ec->led_spk_mute.default_trigger = "audio-mute",
> + ec->led_spk_mute.max_brightness = 1;
> + ec->led_spk_mute.default_trigger = "audio-mute";
> ec->led_spk_mute.brightness_set_blocking = t14s_spk_mute_led_set;
> ec->led_spk_mute.brightness_get = t14s_spk_mute_led_get;
>
This definitely deserves a Fixes tag.
Then add
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-26 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-26 1:43 [PATCH] platform: arm64: thinkpad-t14s-ec: Convert comma to semicolon Chen Ni
2025-09-26 8:21 ` Bryan O'Donoghue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).