From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2404EC433EF for ; Fri, 14 Jan 2022 08:32:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235197AbiANIcD (ORCPT ); Fri, 14 Jan 2022 03:32:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:39884 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234648AbiANIcC (ORCPT ); Fri, 14 Jan 2022 03:32:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642149121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4e3R0cGDEuzfJCTMeYBZ008JX3SkTwc1ShwrpVRZ6sY=; b=Vduft9vwVNK2t9xhcLQRxm/zhlejbEa8EGR1jYYeLDav0BzGd+rxArqvu4CN3K1nELPr2P JyV/dbepT5Hk1gmO7rP19mY/nH8LxPmuwBoMREJDXgsMG53zwo+X4KpQqckUDoLC2kuSld r6JZwTv2FyqiqMKHuy5JGXWXfWaGe10= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-191-EhElR-zVMrqUBA4iLMHwKA-1; Fri, 14 Jan 2022 03:31:58 -0500 X-MC-Unique: EhElR-zVMrqUBA4iLMHwKA-1 Received: by mail-ed1-f71.google.com with SMTP id b8-20020a056402350800b003f8f42a883dso7727765edd.16 for ; Fri, 14 Jan 2022 00:31:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=4e3R0cGDEuzfJCTMeYBZ008JX3SkTwc1ShwrpVRZ6sY=; b=1wBfchtHyJZVfkDyVY4906cLjfTsi75XjKEek4eDW9VbVYxLim9GUNzYhhBe8P0Z4L laX/kD1lu0YiPrCM9QNQkcUc8rrjWNr9KIHcFfkCEtWDLSlVuj5odDmpiiDsZrwsmenc X99wZCsfms5+PLwcsSXOoYYMAeZfHgMh7OTxkO5SDCwY7IAEH/URQEmfO/Y5fEEzYa0+ AgO8xQs0ZWelHm/gD18J1yf6uhZRsiuokX06OTaAJZ18Z7bpUA1ecG+O2QnlqLB7ia4+ SH1nDQNDNgudRgZLbwUfzrTA4mUcdPTgFnE+pdvL+4VLm/mI6DioK3PqSrDtcN7pL5K6 kgDA== X-Gm-Message-State: AOAM533zo3bR/F3kOrYQnT+RjK8F2qZTPMGHJUIeiTO9uNu1Jn1VFJ+U qsrRnVH2NZmPrfResigk6ndatGqParTwClvFmAPIvQhsSqHqAGGdbzSCLPe+Kd6ApfRMWMXPdd9 qs98tccEYjid8/7mfZ6U4IvCBF24WVzrVkw== X-Received: by 2002:a17:907:7b9a:: with SMTP id ne26mr6794387ejc.24.1642149117278; Fri, 14 Jan 2022 00:31:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyc7ZUjSZiOi4vR7JBwLNXvaLjQlMFxrVHe1I54Rh0HNGyN31qRHcwp/dgJR+l4YdLADSfyPQ== X-Received: by 2002:a17:907:7b9a:: with SMTP id ne26mr6794377ejc.24.1642149117132; Fri, 14 Jan 2022 00:31:57 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id 17sm1623091ejo.27.2022.01.14.00.31.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jan 2022 00:31:56 -0800 (PST) Message-ID: <2d6ab8ab-79c8-681b-a898-a88b48fceb55@redhat.com> Date: Fri, 14 Jan 2022 09:31:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 2/5] platform: surface: Propagate ACPI Dependency Content-Language: en-US To: Geert Uytterhoeven , Felipe Balbi Cc: Jarrett Schultz , Rob Herring , Andy Gross , Bjorn Andersson , Mark Gross , Maximilian Luz , linux-arm-msm , platform-driver-x86@vger.kernel.org, Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jarrett Schultz References: <20211202191630.12450-1-jaschultz@microsoft.com> <20211202191630.12450-3-jaschultz@microsoft.com> <87czku4z2i.fsf@kernel.org> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 1/14/22 09:29, Geert Uytterhoeven wrote: > Hi Felipe, > > On Fri, Jan 14, 2022 at 7:21 AM Felipe Balbi wrote: >> Geert Uytterhoeven writes: >>> On Mon, Dec 6, 2021 at 4:03 PM Jarrett Schultz wrote: >>>> Since the Surface XBL Driver does not depend on ACPI, the >>>> platform/surface directory as a whole no longer depends on ACPI. With >>>> respect to this, the ACPI dependency is moved into each config that depends >>>> on ACPI individually. >>>> >>>> Signed-off-by: Jarrett Schultz >>> >>> Thanks for your patch, which is now commit 272479928172edf0 ("platform: >>> surface: Propagate ACPI Dependency"). >>> >>>> --- a/drivers/platform/surface/Kconfig >>>> +++ b/drivers/platform/surface/Kconfig >>>> @@ -5,7 +5,6 @@ >>>> >>>> menuconfig SURFACE_PLATFORMS >>>> bool "Microsoft Surface Platform-Specific Device Drivers" >>>> - depends on ACPI >>>> default y >>>> help >>>> Say Y here to get to see options for platform-specific device drivers >>> >>> Without any dependency, all users configuring a kernel are now asked >>> about this. Is there any other platform dependency that can be used >>> instead? >> >> there's probably no symbol that would be true for x86 and arm64 while >> being false for everything else. Any ideas? > > depends on ARM64 || X86 || COMPILE_TEST? That sounds reasonable to me, I would be happy to take a patch for that. Regards, Hans