Re: [PATCH] platform/x86: lenovo: Reassign KEY_CUT to KEY_SELECTIVE_SCREENSHOT for Ideapad laptops

[Hans de Goede <hansg@kernel.org>]

Hi,

On 11-Sep-25 4:13 PM, Tomáš Hnyk wrote:
> This key is produced by FN+PRINT_SCREEN and as per Lenovo documentation,
> it should be "Open the Snipping tool". This corresponds to
> KEY_SELECTIVE_SCRENSHOT, whose keycode is 0x27a. Previously, keycodes
> under 248 were preferred due to X11 limitations, so KEY_CUT was used.
> This is now being corrected.
> 
> Signed-off-by: Tomáš Hnyk <tomashnyk@gmail.com>
> ---
>  Fixes https://bugzilla.kernel.org/show_bug.cgi?id=220566

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hansg@kernel.org>

Regards,

Hans





>  drivers/platform/x86/lenovo/ideapad-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/lenovo/ideapad-laptop.c b/drivers/platform/x86/lenovo/ideapad-laptop.c
> index fcebfbaf0460..556d50fb7996 100644
> --- a/drivers/platform/x86/lenovo/ideapad-laptop.c
> +++ b/drivers/platform/x86/lenovo/ideapad-laptop.c
> @@ -1328,7 +1328,7 @@ static const struct key_entry ideapad_keymap[] = {
>     /* Performance toggle also Fn+Q, handled inside ideapad_wmi_notify() */
>     { KE_KEY,   0x3d | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
>     /* shift + prtsc */
> -   { KE_KEY,   0x2d | IDEAPAD_WMI_KEY, { KEY_CUT } },
> +   { KE_KEY,   0x2d | IDEAPAD_WMI_KEY, { KEY_SELECTIVE_SCREENSHOT } },
>     { KE_KEY,   0x29 | IDEAPAD_WMI_KEY, { KEY_TOUCHPAD_TOGGLE } },
>     { KE_KEY,   0x2a | IDEAPAD_WMI_KEY, { KEY_ROOT_MENU } },
>