Re: [PATCH] platform/x86: dell-lis3lv02d: Add Latitude 5500

[Hans de Goede <hansg@kernel.org>]

Hi Paul,

On 22-Jun-25 10:07 AM, Paul Menzel wrote:
> Add 0x29 as the accelerometer address for the Dell Latitude 5500 to
> lis3lv02d_devices[].
> 
> The address was verified as below:
> 
>     $ cd /sys/bus/pci/drivers/i801_smbus/0000:00:1f.4
>     $ ls -d i2c-?
>     i2c-2
>     $ sudo modprobe i2c-dev
>     $ sudo i2cdetect 2
>     WARNING! This program can confuse your I2C bus, cause data loss and worse!
>     I will probe file /dev/i2c-2.
>     I will probe address range 0x08-0x77.
>     Continue? [Y/n] Y
>          0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f
>     00:                         08 -- -- -- -- -- -- --
>     10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>     20: -- -- -- -- -- -- -- -- -- 29 -- -- -- -- -- --
>     30: 30 -- -- -- -- 35 UU UU -- -- -- -- -- -- -- --
>     40: -- -- -- -- 44 -- -- -- -- -- -- -- -- -- -- --
>     50: UU -- 52 -- -- -- -- -- -- -- -- -- -- -- -- --
>     60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>     70: -- -- -- -- -- -- -- --
>     $ echo lis3lv02d 0x29 | sudo tee /sys/bus/i2c/devices/i2c-2/new_device
>     lis3lv02d 0x29
>     $ sudo dmesg
>     [    0.000000] Linux version 6.12.32-amd64 (debian-kernel@lists.debian.org) (x86_64-linux-gnu-gcc-14 (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44) #1 SMP PREEMPT_DYNAMIC Debian 6.12.32-1 (2025-06-07)
>     […]
>     [    0.000000] DMI: Dell Inc. Latitude 5500/0M14W7, BIOS 1.38.0 03/06/2025
>     […]
>     [  609.063488] i2c_dev: i2c /dev entries driver
>     [  639.135020] i2c i2c-2: new_device: Instantiated device lis3lv02d at 0x29
> 
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hansg@kernel.org>

Note with kernels >= 6.14 you could have also used the new
probe_i2c_addr module option for the dell-lis3lv02d module.

Regards,

Hans



> ---
>  drivers/platform/x86/dell/dell-lis3lv02d.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/dell/dell-lis3lv02d.c b/drivers/platform/x86/dell/dell-lis3lv02d.c
> index efe26d667973..0791118dd6b7 100644
> --- a/drivers/platform/x86/dell/dell-lis3lv02d.c
> +++ b/drivers/platform/x86/dell/dell-lis3lv02d.c
> @@ -45,6 +45,7 @@ static const struct dmi_system_id lis3lv02d_devices[] __initconst = {
>  	 * Additional individual entries were added after verification.
>  	 */
>  	DELL_LIS3LV02D_DMI_ENTRY("Latitude 5480",      0x29),
> +	DELL_LIS3LV02D_DMI_ENTRY("Latitude 5500",      0x29),
>  	DELL_LIS3LV02D_DMI_ENTRY("Latitude E6330",     0x29),
>  	DELL_LIS3LV02D_DMI_ENTRY("Latitude E6430",     0x29),
>  	DELL_LIS3LV02D_DMI_ENTRY("Precision 3540",     0x29),