From: Hans de Goede <hdegoede@redhat.com>
To: "Barnabás Pőcze" <pobrn@protonmail.com>
Cc: Elia Devito <eliadevito@gmail.com>,
Mark Pearson <mpearson@lenovo.com>,
Benjamin Berg <bberg@redhat.com>,
Bastien Nocera <hadess@hadess.net>,
Jared Dominguez <jaredz@redhat.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: RFC: offering a standardized (/sys/class) userspace API for selecting system/laptop performance-profiles
Date: Thu, 17 Sep 2020 15:24:31 +0200 [thread overview]
Message-ID: <3748b6be-cd8b-19e6-eb36-c5f94850d764@redhat.com> (raw)
In-Reply-To: <jQoirRukXGYClb58QQWmL6rQ6usxi_hKzPRYe2tlEyjXG-hEVxwzECgEXFxzyMRG2sEnxwdKNvmWzEV4oZcaJ4MM5RrgFtBdin8yxH4cAYs=@protonmail.com>
Hi,
On 9/17/20 3:02 PM, Barnabás Pőcze wrote:
> Hi
>
>
> 2020. szeptember 17., csütörtök 13:22 keltezéssel, Hans de Goede írta:
>
>> [...]
>> I guess we should also add an optional lap_mode sysfs attribute
>> to the class-device, to have all the info for the Thinkpads in
>> one place.
>> [...]
>
>
> Excuse my ignorance, but why does "lap_mode" need to be here?
> I understand the implications of it regarding performance, but
> I think it would be more sense to export it via the hwmon (or
> something similar) subsystem? What am I missing?
Well hwmon has very clearly defined sensor types, like voltage,
fan-speed and temperature. lap_mode does not match any of them.
Also registering another-type class device just for the lap_mode
boolean seems overkill, esp. since lap_mode is inherently coupled
to the performance-profile stuff.
Regards,
Hans
next prev parent reply other threads:[~2020-09-17 13:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 11:22 RFC: offering a standardized (/sys/class) userspace API for selecting system/laptop performance-profiles Hans de Goede
2020-09-17 11:50 ` Bastien Nocera
2020-09-17 12:51 ` Hans de Goede
2020-09-17 13:00 ` Bastien Nocera
2020-09-17 13:50 ` Benjamin Berg
2020-09-17 13:54 ` Hans de Goede
2020-09-17 14:10 ` Benjamin Berg
2020-09-17 16:58 ` [External] " Mark Pearson
2020-09-17 17:03 ` Hans de Goede
2020-09-17 17:16 ` Mark Pearson
2020-09-17 18:16 ` Benjamin Berg
2020-09-21 9:03 ` Elia Devito
2020-09-22 10:43 ` Hans de Goede
2020-09-24 2:10 ` Mark Pearson
2020-09-24 8:21 ` Hans de Goede
2020-09-24 11:48 ` Benjamin Berg
2020-09-22 10:30 ` Hans de Goede
2020-09-24 1:44 ` Mark Pearson
2020-09-17 13:36 ` Mark Pearson
2020-09-17 14:04 ` Hans de Goede
2020-09-17 16:51 ` Mark Pearson
2020-09-17 12:22 ` Benjamin Berg
2020-09-17 12:45 ` Hans de Goede
2020-09-17 13:07 ` Bastien Nocera
2020-09-17 13:46 ` Hans de Goede
2020-09-17 13:02 ` Barnabás Pőcze
2020-09-17 13:24 ` Hans de Goede [this message]
2020-09-17 13:28 ` Bastien Nocera
2020-09-17 13:51 ` Hans de Goede
2020-09-17 13:59 ` Benjamin Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3748b6be-cd8b-19e6-eb36-c5f94850d764@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bberg@redhat.com \
--cc=eliadevito@gmail.com \
--cc=hadess@hadess.net \
--cc=jaredz@redhat.com \
--cc=mpearson@lenovo.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox