From: Hans de Goede <hdegoede@redhat.com>
To: Jorge Lopez <jorgealtxwork@gmail.com>
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v4 2/6] Introduction of HP-BIOSCFG driver
Date: Sat, 12 Nov 2022 09:30:18 +0100 [thread overview]
Message-ID: <38afe79b-0c23-cfbb-30a8-71ce9fcd794b@redhat.com> (raw)
In-Reply-To: <CAOOmCE9YT3VxEbuMMX3MCvxEinHugvvYkGHgrnRN1fHVSy7cWw@mail.gmail.com>
Hi,
On 11/12/22 00:00, Jorge Lopez wrote:
> Hi Hans,
>
> A quick note to check the next step. The changes requested for
> enum-attributes,c and several supporting functions will impact other
> source files. To save reviewing time, I am planning to introduce the
> same changes across all source files and then proceed to submit the
> review. Is this option acceptable?.
Yes applying the same changes to all the source files is
the *intention*. This is why I stopped reviewing after
reviewing the first set of files.
Regards,
Hans
next prev parent reply other threads:[~2022-11-12 8:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 20:10 [PATCH v4 0/6] Introduction of HP-BIOSCFG driver Jorge Lopez
2022-10-20 20:10 ` [PATCH v4 1/6] Moving existing HP drivers to a central location Jorge Lopez
2022-11-07 13:48 ` Hans de Goede
2022-11-08 21:36 ` Jorge Lopez
2022-10-20 20:10 ` [PATCH v4 2/6] Introduction of HP-BIOSCFG driver Jorge Lopez
2022-11-08 14:51 ` Hans de Goede
2022-11-09 17:24 ` Jorge Lopez
2022-11-09 18:10 ` Hans de Goede
2022-11-09 20:00 ` Jorge Lopez
2022-11-09 20:05 ` Hans de Goede
2022-11-09 20:52 ` Jorge Lopez
2022-11-09 20:55 ` Hans de Goede
2022-11-09 21:04 ` Jorge Lopez
2022-11-09 21:11 ` Hans de Goede
2022-11-09 21:26 ` Jorge Lopez
2022-11-11 23:00 ` Jorge Lopez
2022-11-12 8:30 ` Hans de Goede [this message]
2022-11-14 14:13 ` Jorge Lopez
2022-10-20 20:10 ` [PATCH v4 3/6] HP BIOSCFG driver - set 2 Jorge Lopez
2022-10-20 20:10 ` [PATCH v4 4/6] HP BIOSCFG driver - set 3 Jorge Lopez
2022-10-20 20:10 ` [PATCH v4 5/6] HP BIOSCFG driver - set 4 Jorge Lopez
2022-10-20 20:10 ` [PATCH v4 6/6] HP BIOSCFG driver - remaining components Jorge Lopez
2022-11-08 14:59 ` [PATCH v4 0/6] Introduction of HP-BIOSCFG driver Hans de Goede
2022-11-08 21:38 ` Jorge Lopez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38afe79b-0c23-cfbb-30a8-71ce9fcd794b@redhat.com \
--to=hdegoede@redhat.com \
--cc=jorgealtxwork@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox