Re: [PATCH v5 5/8] platform/x86/amd/pmf: Move debug helper functions to UAPI header

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Thu, 21 May 2026, Shyam Sundar S K wrote:

> These debug helper functions convert enumerated values to appropriate
> message and can be useful for userspace tools and other kernel components
> that need to interpret AMD PMF state values.
> 
> By making them inline functions in the UAPI header, they become available
> to both kernel and userspace without code duplication. Also, prefix the
> function names with amd_pmf_.
> 
> Co-developed-by: Sanket Goswami <Sanket.Goswami@amd.com>
> Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> ---
>  drivers/platform/x86/amd/pmf/spc.c | 61 ++----------------------------
>  include/uapi/linux/amd-pmf.h       | 57 ++++++++++++++++++++++++++++
>  2 files changed, 60 insertions(+), 58 deletions(-)


> diff --git a/include/uapi/linux/amd-pmf.h b/include/uapi/linux/amd-pmf.h
> index 54baf015e4c1..a8c715bee9cc 100644
> --- a/include/uapi/linux/amd-pmf.h
> +++ b/include/uapi/linux/amd-pmf.h
> @@ -115,6 +115,63 @@ enum amd_pmf_platform_type {
>  	AMD_PMF_PTYPE_INVALID = 0xf,
>  };
>  
> +/* Retrieve the platform type as a string */
> +static inline const char *amd_pmf_get_pt(unsigned int platform_type)

> +/* Retrieve the laptop placement as a string */
> +static inline const char *amd_pmf_get_lp(unsigned int device_state)

> +/* Retrieve the slider position as a string */
> +static inline const char *amd_pmf_get_sp(unsigned int state)

"pt", "lp", and "sp" are not particularly descriptive. I know they get a 
bit longer if you expand them but it'd be huge win for code readability 
still.

-- 
 i.