Re: [v4 1/3] platform/x86/amd/hsmp: Use a single DRIVER_VERSION for all hsmp modules

[Suma Hegde <Suma.Hegde@amd.com>]

Hi Ilpo,


On 5/8/2025 8:04 PM, Ilpo Järvinen wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On Tue, 6 May 2025, Suma Hegde wrote:
>
>> Use a single DRIVER_VERSION for the plat, hsmp and acpi modules,
>> as all these modules are connected to a common functionality.
>>
>> Signed-off-by: Suma Hegde <suma.hegde@amd.com>
>> Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
>> ---
>> Changes since v3:
>> None
>>
>> This patch is rebased on https://lore.kernel.org/platform-driver-x86/20250425102357.266790-1-suma.hegde@amd.com/T/#u
>>
>> Changes since v2:
>> Update the commit message and description
>>
>> Changes since v1:
>> None
>>
>>   drivers/platform/x86/amd/hsmp/acpi.c | 1 -
>>   drivers/platform/x86/amd/hsmp/hsmp.c | 2 --
>>   drivers/platform/x86/amd/hsmp/hsmp.h | 2 ++
>>   drivers/platform/x86/amd/hsmp/plat.c | 1 -
>>   4 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/platform/x86/amd/hsmp/acpi.c b/drivers/platform/x86/amd/hsmp/acpi.c
>> index eaae044e4f82..12f4950afcd9 100644
>> --- a/drivers/platform/x86/amd/hsmp/acpi.c
>> +++ b/drivers/platform/x86/amd/hsmp/acpi.c
>> @@ -28,7 +28,6 @@
>>   #include "hsmp.h"
>>
>>   #define DRIVER_NAME          "hsmp_acpi"
>> -#define DRIVER_VERSION               "2.3"
> This fails to apply on top of the review-ilpo-next branch, I've no idea on
> what commit this is based on. Could you please rebase and check if the
> entire series is fine wrt. the changes what this is based on vs what's in
> the review-ilpo-next branch.


This patch series is re based on 
https://lore.kernel.org/platform-driver-x86/20250425102357.266790-1-suma.hegde@amd.com/T/#u 
(I added this as part of changelog)

I rechecked by applying this series on review-ilpo-next + the above 
patch. It applies clean.

Could you please take the above mentioned dependent patch and apply this 
series?


Thanks and Regards,

Suma

> --
>   i.
>
>>   /* These are the strings specified in ACPI table */
>>   #define MSG_IDOFF_STR                "MsgIdOffset"
>> diff --git a/drivers/platform/x86/amd/hsmp/hsmp.c b/drivers/platform/x86/amd/hsmp/hsmp.c
>> index a3ac09a90de4..3df34d7436a9 100644
>> --- a/drivers/platform/x86/amd/hsmp/hsmp.c
>> +++ b/drivers/platform/x86/amd/hsmp/hsmp.c
>> @@ -32,8 +32,6 @@
>>   #define HSMP_WR                      true
>>   #define HSMP_RD                      false
>>
>> -#define DRIVER_VERSION               "2.4"
>> -
>>   /*
>>    * When same message numbers are used for both GET and SET operation,
>>    * bit:31 indicates whether its SET or GET operation.
>> diff --git a/drivers/platform/x86/amd/hsmp/hsmp.h b/drivers/platform/x86/amd/hsmp/hsmp.h
>> index d58d4f0c20d5..7877cb97993b 100644
>> --- a/drivers/platform/x86/amd/hsmp/hsmp.h
>> +++ b/drivers/platform/x86/amd/hsmp/hsmp.h
>> @@ -25,6 +25,8 @@
>>   #define HSMP_DEVNODE_NAME    "hsmp"
>>   #define ACPI_HSMP_DEVICE_HID    "AMDI0097"
>>
>> +#define DRIVER_VERSION               "2.4"
>> +
>>   struct hsmp_mbaddr_info {
>>        u32 base_addr;
>>        u32 msg_id_off;
>> diff --git a/drivers/platform/x86/amd/hsmp/plat.c b/drivers/platform/x86/amd/hsmp/plat.c
>> index 81931e808bbc..4f03fdf988c1 100644
>> --- a/drivers/platform/x86/amd/hsmp/plat.c
>> +++ b/drivers/platform/x86/amd/hsmp/plat.c
>> @@ -24,7 +24,6 @@
>>   #include "hsmp.h"
>>
>>   #define DRIVER_NAME          "amd_hsmp"
>> -#define DRIVER_VERSION               "2.3"
>>
>>   /*
>>    * To access specific HSMP mailbox register, s/w writes the SMN address of HSMP mailbox
>>