X86 platform drivers
 help / color / mirror / Atom feed
From: leo60228 <leo@60228.dev>
To: Hans de Goede <hdegoede@redhat.com>,
	platform-driver-x86@vger.kernel.org,
	Jafar Akhondali <jafar.akhoondali@gmail.com>
Subject: Re: [PATCH] platform/x86: add support for Acer Predator LEDs
Date: Wed, 16 Jun 2021 13:01:14 -0400	[thread overview]
Message-ID: <3b6e5d63-b1a3-2fa2-06e6-1312e6a1ad2d@60228.dev> (raw)
In-Reply-To: <03ed17f3-60e1-f88f-d9e3-7fd388fa8ad9@redhat.com>

> Ok, I'm afraid that using your real-name is a hard requirements for kernel
> contributions.

Okay, thank you.

> Hmm, but you do have both 4 RGB LED zones which are addressable per zone, are you saying that the code for supporting that basic functionality is also different ? Note Jafar's driver did not use the LED API sofar, it was simply forwarding an array of bytes from userspace to a WMI call.

Jafar's patch is for method ID 20 with a 16-byte buffer, while my 
hardware uses method ID 6 with a 4-byte buffer. Method ID 20 doesn't 
seem to do anything on my machine.

  reply	other threads:[~2021-06-16 17:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 22:19 [PATCH] platform/x86: add support for Acer Predator LEDs leo60228
2021-06-15 23:24 ` Barnabás Pőcze
     [not found]   ` <CAPRrO0xZunTfYYSOg-Gvk18FMHPufAURZ=fWjQN1bmP=RuuzGA@mail.gmail.com>
2021-06-16  0:21     ` Barnabás Pőcze
2021-06-16  0:24       ` leo60228
2021-06-16  0:51 ` [PATCH v2] " leo60228
2021-06-16 15:43   ` Enrico Weigelt, metux IT consult
2021-06-16 15:56     ` leo60228
2021-06-16 17:20       ` Enrico Weigelt, metux IT consult
2021-06-16 17:50         ` Hans de Goede
2021-06-21 19:23           ` Enrico Weigelt, metux IT consult
2021-06-21 19:43             ` Hans de Goede
2021-06-22 10:19               ` input devices vs. keyboard backlights [WAS: [PATCH v2] platform/x86: add support for Acer Predator LEDs] Enrico Weigelt, metux IT consult
2021-06-22 10:46                 ` Hans de Goede
2021-06-16 15:41 ` [PATCH] platform/x86: add support for Acer Predator LEDs Enrico Weigelt, metux IT consult
2021-06-16 16:06   ` leo60228
2021-06-16 17:22     ` Enrico Weigelt, metux IT consult
2021-06-16 16:00 ` Hans de Goede
2021-06-16 16:16   ` leo60228
2021-06-16 16:39     ` Hans de Goede
2021-06-16 17:01       ` leo60228 [this message]
2021-06-16 17:13   ` Jafar Akhondali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b6e5d63-b1a3-2fa2-06e6-1312e6a1ad2d@60228.dev \
    --to=leo@60228.dev \
    --cc=hdegoede@redhat.com \
    --cc=jafar.akhoondali@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox