From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 156DCC00140 for ; Tue, 2 Aug 2022 12:44:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235174AbiHBMo0 (ORCPT ); Tue, 2 Aug 2022 08:44:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234149AbiHBMoZ (ORCPT ); Tue, 2 Aug 2022 08:44:25 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 21ED62CE03 for ; Tue, 2 Aug 2022 05:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659444263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XZ2kNp4bdTekuKRDQveV4xcZjTV9r6m4qwF/eEMbjX0=; b=DtgndOnQj9xPyGs2zOMkbRbcR8cuNlHEtn1R7JiTSIjvuCun4tn4eVf+/hQUQhNG2PFQVD AXLwqsAsSQtcPVFdXyHUEOmFbbVNQXHiwzDCeKC5fethPuQ92jLGCVMigV+UCvPFhQ22ph 1zep83xotFAroPCuq/jdNPFkv+LyBJU= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-674-vh-5RkRFPVygXGKAnH3Thg-1; Tue, 02 Aug 2022 08:44:21 -0400 X-MC-Unique: vh-5RkRFPVygXGKAnH3Thg-1 Received: by mail-ed1-f72.google.com with SMTP id c9-20020a05640227c900b0043ad14b1fa0so9035012ede.1 for ; Tue, 02 Aug 2022 05:44:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=XZ2kNp4bdTekuKRDQveV4xcZjTV9r6m4qwF/eEMbjX0=; b=FGOoJ1HRsmfcSJoVXS/M7I99Q44vEnqwdUVXUU+BdzrE578HNp5QhI3g2Du6+eqM5O /La3dH+1MnC+6ClAANxycsYvengxR8WoOnttbvE7IpZUqEZcPVIjEi+3xkZ2L4UhrQcy 5Mz0S3K+PhGL82s1w/qx3z9AeNa6f7W3jIC3yd8JiTxHq/tFV8BnOZSQ6yqL7XNr4+aB c26hJZaXX8DJFpHIexLnA/Rwus0Vyo45u6pfCqGDyzxsM0jQs1ALV+69ZNmTrf6WZ/jt 0kuht7klnc4zau5OJ4rLHIZjFIzsB7I3XImDxVGYEgDOuhRi+4jH9/82u4UmNwt8qDWB GVtQ== X-Gm-Message-State: AJIora/K8BlxlQca2FFKG2j3OXyx0xIn8lQqqgvLyqv4D2L5zTnhs3IY isBwGDTaml72JF+CcxRPlBNbdabP8jo4GdJ1ZMkiHX5a1tHLspaO6JvOw9mqJ05kSkfUGmHKB09 4IjPTDFzaQO3xAogxd3L4Op3TpEfP3T4WTw== X-Received: by 2002:a17:907:628f:b0:72f:57da:c33d with SMTP id nd15-20020a170907628f00b0072f57dac33dmr16032791ejc.374.1659444260549; Tue, 02 Aug 2022 05:44:20 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vNft13NEtbL1La733wNacCOp8zhJRTHH8nWdliZjfjpbJl9Kec/T7EG8es50OigdtlowotOw== X-Received: by 2002:a17:907:628f:b0:72f:57da:c33d with SMTP id nd15-20020a170907628f00b0072f57dac33dmr16032774ejc.374.1659444260333; Tue, 02 Aug 2022 05:44:20 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id n25-20020a170906379900b0072fd6e9f707sm3491250ejc.100.2022.08.02.05.44.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 05:44:19 -0700 (PDT) Message-ID: <405c2b61-9bb2-aa36-b324-80de324f7831@redhat.com> Date: Tue, 2 Aug 2022 14:44:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 02/11] platform/x86/amd/pmf: Add support for PMF APCI layer Content-Language: en-US To: Shyam Sundar S K , markgross@kernel.org Cc: platform-driver-x86@vger.kernel.org, Patil.Reddy@amd.com References: <20220802112545.2118632-1-Shyam-sundar.S-k@amd.com> <20220802112545.2118632-3-Shyam-sundar.S-k@amd.com> From: Hans de Goede In-Reply-To: <20220802112545.2118632-3-Shyam-sundar.S-k@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 8/2/22 13:25, Shyam Sundar S K wrote: > PMF driver implements the ACPI methods as defined by AMD for PMF Support. > The ACPI layer acts as a glue that helps in providing the infrastructure > for OEMs customization. > > OEMs can refer to PMF support documentation to decide on the list of > functions to be supported on their specific platform model. > > AMD mandates that PMF ACPI fn0 and fn1 to be implemented which > provides the set of functions, params and the notifications that > would be sent to PMF driver so that PMF driver can adapt and > react. > > Signed-off-by: Shyam Sundar S K Thank you for the changes to this, this looks even better to me now :) : Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/amd/pmf/Makefile | 2 +- > drivers/platform/x86/amd/pmf/acpi.c | 153 ++++++++++++++++++++++++++ > drivers/platform/x86/amd/pmf/core.c | 1 + > drivers/platform/x86/amd/pmf/pmf.h | 23 ++++ > 4 files changed, 178 insertions(+), 1 deletion(-) > create mode 100644 drivers/platform/x86/amd/pmf/acpi.c > > diff --git a/drivers/platform/x86/amd/pmf/Makefile b/drivers/platform/x86/amd/pmf/Makefile > index 459005f659e5..2617eba773ce 100644 > --- a/drivers/platform/x86/amd/pmf/Makefile > +++ b/drivers/platform/x86/amd/pmf/Makefile > @@ -5,4 +5,4 @@ > # > > obj-$(CONFIG_AMD_PMF) += amd-pmf.o > -amd-pmf-objs := core.o > +amd-pmf-objs := core.o acpi.o > diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c > new file mode 100644 > index 000000000000..5269d48b1f5f > --- /dev/null > +++ b/drivers/platform/x86/amd/pmf/acpi.c > @@ -0,0 +1,153 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * AMD Platform Management Framework Driver > + * > + * Copyright (c) 2022, Advanced Micro Devices, Inc. > + * All Rights Reserved. > + * > + * Author: Shyam Sundar S K > + */ > + > +#include > +#include "pmf.h" > + > +static union acpi_object *apmf_if_call(struct amd_pmf_dev *pdev, int fn, struct acpi_buffer *param) > +{ > + struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL }; > + acpi_handle ahandle = ACPI_HANDLE(pdev->dev); > + struct acpi_object_list apmf_if_arg_list; > + union acpi_object apmf_if_args[2]; > + acpi_status status; > + > + apmf_if_arg_list.count = 2; > + apmf_if_arg_list.pointer = &apmf_if_args[0]; > + > + apmf_if_args[0].type = ACPI_TYPE_INTEGER; > + apmf_if_args[0].integer.value = fn; > + > + if (param) { > + apmf_if_args[1].type = ACPI_TYPE_BUFFER; > + apmf_if_args[1].buffer.length = param->length; > + apmf_if_args[1].buffer.pointer = param->pointer; > + } else { > + apmf_if_args[1].type = ACPI_TYPE_INTEGER; > + apmf_if_args[1].integer.value = 0; > + } > + > + status = acpi_evaluate_object(ahandle, "APMF", &apmf_if_arg_list, &buffer); > + if (ACPI_FAILURE(status)) { > + dev_err(pdev->dev, "APMF method call failed\n"); > + if (status != AE_NOT_FOUND) > + kfree(buffer.pointer); > + > + return NULL; > + } > + > + return buffer.pointer; > +} > + > +static int apmf_if_call_store_buffer(struct amd_pmf_dev *pdev, int fn, void *dest, size_t out_sz) > +{ > + union acpi_object *info; > + size_t size; > + int err = 0; > + > + info = apmf_if_call(pdev, fn, NULL); > + if (!info) > + return -EIO; > + > + if (info->type != ACPI_TYPE_BUFFER) { > + dev_err(pdev->dev, "object is not a buffer\n"); > + err = -EINVAL; > + goto out; > + } > + > + if (info->buffer.length < 2) { > + dev_err(pdev->dev, "buffer too small\n"); > + err = -EINVAL; > + goto out; > + } > + > + size = *(u16 *)info->buffer.pointer; > + if (info->buffer.length < size) { > + dev_err(pdev->dev, "buffer smaller then headersize %u < %zu\n", > + info->buffer.length, size); > + err = -EINVAL; > + goto out; > + } > + > + if (size < out_sz) { > + dev_err(pdev->dev, "buffer too small %zu\n", size); > + err = -EINVAL; > + goto out; > + } > + > + memcpy(dest, info->buffer.pointer, out_sz); > + > +out: > + kfree(info); > + return err; > +} > + > +int is_apmf_func_supported(struct amd_pmf_dev *pdev, unsigned long index) > +{ > + /* If bit-n is set, that indicates function n+1 is supported */ > + return !!(pdev->supported_func & BIT(index - 1)); > +} > + > +static int apmf_if_verify_interface(struct amd_pmf_dev *pdev) > +{ > + struct apmf_verify_interface output; > + int err; > + > + err = apmf_if_call_store_buffer(pdev, APMF_FUNC_VERIFY_INTERFACE, &output, sizeof(output)); > + if (err) > + return err; > + > + pdev->supported_func = output.supported_functions; > + dev_dbg(pdev->dev, "supported functions:0x%x notifications:0x%x\n", > + output.supported_functions, output.notification_mask); > + > + return 0; > +} > + > +static int apmf_get_system_params(struct amd_pmf_dev *dev) > +{ > + struct apmf_system_params params; > + int err; > + > + if (!is_apmf_func_supported(dev, APMF_FUNC_GET_SYS_PARAMS)) > + return -EINVAL; > + > + err = apmf_if_call_store_buffer(dev, APMF_FUNC_GET_SYS_PARAMS, ¶ms, sizeof(params)); > + if (err) > + return err; > + > + dev_dbg(dev->dev, "system params mask:0x%x flags:0x%x cmd_code:0x%x\n", > + params.valid_mask, > + params.flags, > + params.command_code); > + params.flags = params.flags & params.valid_mask; > + > + return 0; > +} > + > +int apmf_acpi_init(struct amd_pmf_dev *pmf_dev) > +{ > + int ret; > + > + ret = apmf_if_verify_interface(pmf_dev); > + if (ret) { > + dev_err(pmf_dev->dev, "APMF verify interface failed :%d\n", ret); > + goto out; > + } > + > + ret = apmf_get_system_params(pmf_dev); > + if (ret) { > + dev_err(pmf_dev->dev, "APMF apmf_get_system_params failed :%d\n", ret); > + goto out; > + } > + > +out: > + return ret; > +} > diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c > index aef97965c181..c5002b7bb904 100644 > --- a/drivers/platform/x86/amd/pmf/core.c > +++ b/drivers/platform/x86/amd/pmf/core.c > @@ -204,6 +204,7 @@ static int amd_pmf_probe(struct platform_device *pdev) > if (!dev->regbase) > return -ENOMEM; > > + apmf_acpi_init(dev); > platform_set_drvdata(pdev, dev); > > mutex_init(&dev->lock); > diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h > index 1c2e942e5096..bdadbff168ee 100644 > --- a/drivers/platform/x86/amd/pmf/pmf.h > +++ b/drivers/platform/x86/amd/pmf/pmf.h > @@ -11,6 +11,12 @@ > #ifndef PMF_H > #define PMF_H > > +#include > + > +/* APMF Functions */ > +#define APMF_FUNC_VERIFY_INTERFACE 0 > +#define APMF_FUNC_GET_SYS_PARAMS 1 > + > /* Message Definitions */ > #define SET_SPL 0x03 /* SPL: Sustained Power Limit */ > #define SET_SPPT 0x05 /* SPPT: Slow Package Power Tracking */ > @@ -30,6 +36,21 @@ > #define GET_STT_LIMIT_APU 0x20 > #define GET_STT_LIMIT_HS2 0x21 > > +/* AMD PMF BIOS interfaces */ > +struct apmf_verify_interface { > + u16 size; > + u16 version; > + u32 notification_mask; > + u32 supported_functions; > +} __packed; > + > +struct apmf_system_params { > + u16 size; > + u32 valid_mask; > + u32 flags; > + u8 command_code; > +} __packed; > + > struct amd_pmf_dev { > void __iomem *regbase; > void __iomem *smu_virt_addr; > @@ -38,9 +59,11 @@ struct amd_pmf_dev { > u32 cpu_id; > struct device *dev; > struct mutex lock; /* protects the PMF interface */ > + u32 supported_func; > }; > > /* Core Layer */ > +int apmf_acpi_init(struct amd_pmf_dev *pmf_dev); > int amd_pmf_send_cmd(struct amd_pmf_dev *dev, u8 message, bool get, u32 arg, u32 *data); > > #endif /* PMF_H */