Re: [PATCH] platform/x86: touchscreen_dmi: Add info for SARY Tab 3 tablet

[Huy Minh <buingoc67@gmail.com>]

On Tuesday, December 10, 2024 9:31:37 PM Indochina Time Ilpo Järvinen wrote:
> On Tue, 3 Dec 2024, buingoc67@gmail.com wrote:
> > From: hmtheboy154 <buingoc67@gmail.com>
> > 
> > There's no info about the OEM behind the tablet, only online stores
> > listing. This tablet uses an Intel Atom x5-Z8300, 4GB of RAM & 64GB
> > of storage.
> > 
> > Signed-off-by: hmtheboy154 <buingoc67@gmail.com>
> 
> Hi,
> 
> Thank you for the patch.
> 
> We need to have your proper name in From and Signed-off-by tag before a
> patch can be accepted. Please send a v2 with that fixed, thanks.
> 
> --
>  i.
> 

Thank you. I'll send a new patch. I thought I can keep this as I used to send 
patches with the same name to Hans de Goede. 


> > ---
> > 
> >  drivers/platform/x86/touchscreen_dmi.c | 26 ++++++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> > 
> > diff --git a/drivers/platform/x86/touchscreen_dmi.c
> > b/drivers/platform/x86/touchscreen_dmi.c index 0a39f68c641d..bdc19cd8d3ed
> > 100644
> > --- a/drivers/platform/x86/touchscreen_dmi.c
> > +++ b/drivers/platform/x86/touchscreen_dmi.c
> > @@ -855,6 +855,23 @@ static const struct ts_dmi_data rwc_nanote_next_data
> > = {> 
> >  	.properties = rwc_nanote_next_props,
> >  
> >  };
> > 
> > +static const struct property_entry sary_tab_3_props[] = {
> > +	PROPERTY_ENTRY_U32("touchscreen-size-x", 1730),
> > +	PROPERTY_ENTRY_U32("touchscreen-size-y", 1151),
> > +	PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> > +	PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> > +	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> > +	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-sary-tab-3.fw"),
> > +	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> > +	PROPERTY_ENTRY_BOOL("silead,home-button"),
> > +	{ }
> > +};
> > +
> > +static const struct ts_dmi_data sary_tab_3_data = {
> > +	.acpi_name	= "MSSL1680:00",
> > +	.properties	= sary_tab_3_props,
> > +};
> > +
> > 
> >  static const struct property_entry schneider_sct101ctm_props[] = {
> >  
> >  	PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
> >  	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
> > 
> > @@ -1615,6 +1632,15 @@ const struct dmi_system_id touchscreen_dmi_table[]
> > = {> 
> >  			DMI_MATCH(DMI_BIOS_VERSION, "S8A70R100-
V005"),
> >  		
> >  		},
> >  	
> >  	},
> > 
> > +	{
> > +		/* SARY Tab 3 */
> > +		.driver_data = (void *)&sary_tab_3_data,
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "SARY"),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "C210C"),
> > +			DMI_MATCH(DMI_PRODUCT_SKU, "TAB3"),
> > +		},
> > +	},
> > 
> >  	{
> >  	
> >  		/* Schneider SCT101CTM */
> >  		.driver_data = (void *)&schneider_sct101ctm_data,