X86 platform drivers
 help / color / mirror / Atom feed
From: Colin Guthrie <gmane@colin.guthr.ie>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	platform-driver-x86@vger.kernel.org
Subject: Re: [Regression] Problem with rfkill on 2.6.38
Date: Mon, 09 May 2011 17:30:20 +0100	[thread overview]
Message-ID: <4DC8169C.3020601@colin.guthr.ie> (raw)
In-Reply-To: <1304930195.3475.17.camel@jlt3.sipsolutions.net>

Hiya,


No worries about the late reply... was running around for the last
couple weeks at various events so haven't had a chance to test any other
suggestions yet anyway.

'Twas brillig, and Johannes Berg at 09/05/11 09:36 did gyre and gimble:
>> > [root@jimmy ~]# rmmod dell_laptop
> I'm pretty sure this one's at fault, see below.

Looking at the only commit available for this module on this cycle I see:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.38.y.git;a=commit;h=a3d77411e8b2ad661958c1fbee65beb476ec6d70

dell-laptop: Toggle the unsupported hardware killswitch

It is found on Dell Inspiron 1018 that the firmware reports that the
hardware killswitch is not supported. This makes the rfkill key not
functional.

This patch forces the driver to toggle the firmware rfkill status in the
case that the hardware killswitch is indicated as unsupported by the
firmware.





This looks pretty suspicious to me (from the description) and sounds
like this could be an unintended consequence of the changes here.

I'll see if reverting this one fixes the issue. Thanks for the insights!

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]

  reply	other threads:[~2011-05-09 16:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ip6j66$o5f$1@dough.gmane.org>
2011-05-09  8:36 ` [Regression] Problem with rfkill on 2.6.38 Johannes Berg
2011-05-09 16:30   ` Colin Guthrie [this message]
2011-05-09 17:09   ` Colin Guthrie
2011-05-09 17:11     ` Matthew Garrett
     [not found]       ` <20110509171144.GA7194-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2011-05-10  9:36         ` Colin Guthrie
     [not found]           ` <4DC9072D.4030103-D409yXkIzt2rnn0nCzrM/w@public.gmane.org>
2011-05-10 14:48             ` Keng-Yü Lin
     [not found]               ` <BANLkTinVwnSei_VobfKtgzrwSP+cJSvxaQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-10 15:12                 ` Colin Guthrie
2011-06-24 10:54               ` Colin Guthrie
2011-06-24 12:29                 ` Keng-Yü Lin
2011-06-24 13:23                   ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC8169C.3020601@colin.guthr.ie \
    --to=gmane@colin.guthr.ie \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox