From: John Hughes <john@calvaedi.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: John Hughes <john@Calva.COM>,
platform-driver-x86@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Mattia Dongili <malattia@linux.it>
Subject: Re: drivers/platform/x86/sony-laptop.c: fix scancodes
Date: Wed, 30 Nov 2011 22:50:15 +0100 [thread overview]
Message-ID: <4ED6A517.4050908@calvaedi.com> (raw)
In-Reply-To: <20111130125545.GA5815@elgon.mountain>
On 11/30/2011 01:55 PM, Dan Carpenter wrote:
> Hi John,
>
> Commit 04840b50f395 "drivers/platform/x86/sony-laptop.c: fix scancodes"
> introduces a gcc warning:
>
> drivers/platform/x86/sony-laptop.c:395:14: warning:
> ‘scancode’ may be used uninitialized in this function [-Wuninitialized]
>
Ok, my code was broken, but so was the original - the jogdial device
isn't supposed to send scancodes for it's events:
jog_dev->name = "Sony Vaio Jogdial";
jog_dev->id.bustype = BUS_ISA;
jog_dev->id.vendor = PCI_VENDOR_ID_SONY;
key_dev->dev.parent =&acpi_device->dev;
input_set_capability(jog_dev, EV_KEY, BTN_MIDDLE);
input_set_capability(jog_dev, EV_REL, REL_WHEEL);
Note, no EV_MSC, MSC_SCAN here.
Whoops, anoher bug! Look there, it's setting key_dev->dev.parent
instead of jog_dev.dev_parent!
I'll post a new patch when I've finished testing it.
next prev parent reply other threads:[~2011-11-30 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 12:55 drivers/platform/x86/sony-laptop.c: fix scancodes Dan Carpenter
2011-11-30 13:22 ` John Hughes
2011-11-30 21:50 ` John Hughes [this message]
2011-12-03 11:47 ` [PATCH] Fix scancodes emitted by sony-laptop driver (Version 2 with warnings fixed) John Hughes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED6A517.4050908@calvaedi.com \
--to=john@calvaedi.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=john@Calva.COM \
--cc=malattia@linux.it \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox