From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F38C433EF for ; Wed, 11 May 2022 16:30:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344739AbiEKQaw (ORCPT ); Wed, 11 May 2022 12:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344759AbiEKQau (ORCPT ); Wed, 11 May 2022 12:30:50 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 869F16242; Wed, 11 May 2022 09:30:46 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: usama.anjum) with ESMTPSA id 6A2651F43201 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652286615; bh=McJOd1OtcooV/2GyTlhAmO/oG/dgXkbBGxYysmipYdk=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=VzCtVwdQlqPakSLJ6UCDMWheZMYOIyk+aHp5prPY5f2IR/g2qQeolRqAShBqjyVwC mIdleiFJViLVz0xD9K0oZ/6AFzVyJ2+meMAX6iNMj1+Mk2+c1V3HdwHCLHqjGzaERA DJdI53Z2A9U2w+mxEKUa45Ge1RwTDk4fq2iwJdNxGLpjd6qHdQ0eEK/bo7KDlr9YDy hKgS3leqKfT5sRj/D3AML6U5N8j52eL0ZZ4NhxVqe5anKMELARxa5iESwkoAT5P6bV a6NQZIItNU8tY60jaZcImHIvT9ZtZkNKIehK7hMiMlwu6bg0/Sv2+2dAWiHxv2Pkyc DEQC6VYsFEzHw== Message-ID: <4bcd4fd7-ff81-b480-6ad6-ae027e268c7e@collabora.com> Date: Wed, 11 May 2022 21:29:46 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Cc: usama.anjum@collabora.com, "Rafael J. Wysocki" , Len Brown , Hans de Goede , Mark Gross , Benson Leung , Enric Balletbo i Serra , Greg Kroah-Hartman , Collabora Kernel ML , Guenter Roeck , Dmitry Torokhov , Gwendal Grignou , vbendeb@chromium.org, Andy Shevchenko , Ayman Bagabas , Benjamin Tissoires , =?UTF-8?Q?Bla=c5=be_Hrastnik?= , Darren Hart , Dmitry Torokhov , Jeremy Soller , Mattias Jacobsson <2pi@mok.nu>, Mauro Carvalho Chehab , Rajat Jain , Srinivas Pandruvada , Platform Driver , Linux Kernel Mailing List , ACPI Devel Maling List , "Rafael J . Wysocki" , chrome-platform@lists.linux.dev Subject: Re: [PATCH RESEND v11] platform/chrome: Add ChromeOS ACPI device driver Content-Language: en-US To: Guenter Roeck , Andy Shevchenko References: <8bd83f45-5278-e817-3f65-88fafd0ad3f4@collabora.com> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org On 5/11/22 9:23 PM, Guenter Roeck wrote: > On Wed, May 11, 2022 at 8:59 AM Muhammad Usama Anjum > wrote: >>>> +#define GPIO_ATTR_GROUP(_group, _name, _num) \ >>>> + static umode_t attr_is_visible_gpio_##_num(struct kobject *kobj, \ >>>> + struct attribute *attr, int n) \ >>>> + { \ >>>> + if (_num < chromeos_acpi_gpio_groups) \ >>>> + return attr->mode; \ >>> >>>> + else \ >>> >>> Redundant. >> We are deciding on run time that how many GPIO attribute groups need to >> be shown. chromeos_acpi_gpio_groups is set at run time. I don't see why >> `else` can be redundant here. >> > > else after return is _always_ unnecessary (and results in static > analyzer messages). > Got it. I'll update. Thank you. -- Muhammad Usama Anjum