From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Suma Hegde <suma.hegde@amd.com>
Cc: platform-driver-x86@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
Subject: Re: [v7 08/10] platform/x86/amd/hsmp: Create mutually exclusive ACPI and plat drivers
Date: Wed, 4 Sep 2024 16:30:45 +0300 (EEST) [thread overview]
Message-ID: <4dc8bd2b-07ce-4d69-cd30-82c3872a7ab1@linux.intel.com> (raw)
In-Reply-To: <20240903123830.2717196-8-suma.hegde@amd.com>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On Tue, 3 Sep 2024, Suma Hegde wrote:
> Separate the probes for HSMP ACPI and platform device drivers.
>
> Provide a Kconfig option to choose between
> ACPI or the platform device based driver.
> The common code which is the core part of the HSMP driver
> maintained at hsmp.c is guarded by AMD_HSMP config and is selected by
> these two driver configs.
>
> Also add "|| COMPILE_TEST" clause in Kconfig to get build coverage
> for HSMP.
>
> Signed-off-by: Suma Hegde <suma.hegde@amd.com>
> Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
This series looks ready as far as I can see.
Thanks for all the work you've done to improve it!
--
i.
next prev parent reply other threads:[~2024-09-04 13:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 12:38 [v7 01/10] platform/x86/amd/hsmp: Create hsmp/ directory Suma Hegde
2024-09-03 12:38 ` [v7 02/10] platform/x86/amd/hsmp: Create wrapper function init_acpi() Suma Hegde
2024-09-03 12:38 ` [v7 03/10] platform/x86/amd/hsmp: Convert amd_hsmp_rdwr() to a function pointer Suma Hegde
2024-09-03 12:38 ` [v7 04/10] platform/x86/amd/hsmp: Move structure and macros to header file Suma Hegde
2024-09-03 12:38 ` [v7 05/10] platform/x86/amd/hsmp: Move platform device specific code to plat.c Suma Hegde
2024-09-03 12:38 ` [v7 06/10] platform/x86/amd/hsmp: Move ACPI code to acpi.c Suma Hegde
2024-09-03 12:38 ` [v7 07/10] platform/x86/amd/hsmp: Change generic plat_dev name to hsmp_pdev Suma Hegde
2024-09-03 12:38 ` [v7 08/10] platform/x86/amd/hsmp: Create mutually exclusive ACPI and plat drivers Suma Hegde
2024-09-04 13:30 ` Ilpo Järvinen [this message]
2024-09-04 18:52 ` Hans de Goede
2024-09-11 6:12 ` Suma Hegde
2024-09-11 10:00 ` Hans de Goede
2024-09-03 12:38 ` [v7 09/10] platform/x86/amd/hsmp: Use name space while exporting module symbols Suma Hegde
2024-09-03 12:38 ` [v7 10/10] platform/x86/amd/hsmp: Use dev_groups in the driver structure Suma Hegde
2024-09-04 13:26 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dc8bd2b-07ce-4d69-cd30-82c3872a7ab1@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=naveenkrishna.chatradhi@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=suma.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox