From: "Thomas Weißschuh" <linux-9XfqOkM5JgxKQ7RDE2T8Pw@public.gmane.org>
To: Yves-Alexis Perez <corsac-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
Cc: Henrique de Moraes Holschuh
<ibm-acpi-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>,
Ognjen Galic <smclt30p-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Andy Shevchenko
<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Darren Hart <dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Platform Driver
<platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Andy Shevchenko <andy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: Re: [PATCH v2] platform/x86: thinkpad_acpi: Fix multi-battery bug
Date: Fri, 7 Sep 2018 19:59:52 +0200 [thread overview]
Message-ID: <4e387ece-dbf1-434b-8dde-18f0fa513d99@t-8ch.de> (raw)
In-Reply-To: <6c62d06dee6572f7d03280ed9e9f6d7b7d9babf1.camel-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
Hi Yves-Alexis,
On Fri, 2018-09-07T13:41+0200, Yves-Alexis Perez wrote:
> On Mon, 2018-08-06 at 16:24 +0300, Andy Shevchenko wrote:
> > On Thu, Aug 2, 2018 at 1:24 AM, Thomas Weißschuh <linux@weissschuh.net> wrote:
> > > The struct containing the supported operations for all batteries is
> > > being zeroed on each battery probe. This prevents all other batteries
> > > except the lastly probed one from being configured.
> >
> > You forgot to include subsystem maintainers along with driver maintainer.
> >
> > I pushed this to my review and testing queue, meanwhile I would wait
> > for Ack from Henrique.
>
> was this included in any tree and is it on route to Linus somehow?
This is on track to be released in 4.19.
> My ThinkPad X250 has two batteries and I can only configure threshold on BAT0,
> and I guess it's because of this, so it'd be nice to have it fixed (and maybe
> backported to relevant stable kernels).
As far as I know only changes that fix behaviour that worked before are
eligible for stable. As this specific functionality never worked before I
figured it would be moot to also send it to stable.
(If it is fine to send stuff like this to stable, we could try, though)
Thomas
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
next prev parent reply other threads:[~2018-09-07 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180616093954.8435-1-linux@weissschuh.net>
[not found] ` <00b72055-929d-4bda-bff3-3a9249568b73@t-8ch.de>
[not found] ` <00b72055-929d-4bda-bff3-3a9249568b73-khTSGRnkC0s@public.gmane.org>
2018-08-01 11:47 ` [PATCH] thinkpad_acpi: don't overwrite supported battery operations Henrique de Moraes Holschuh
[not found] ` <20180801114747.qrjclik665ya7oh5-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2018-08-01 22:19 ` [PATCH] platform/x86: thinkpad_acpi: Fix multi-battery bug Thomas Weißschuh
2018-08-01 22:24 ` [PATCH v2] " Thomas Weißschuh
[not found] ` <20180801222418.21892-1-linux-9XfqOkM5JgxKQ7RDE2T8Pw@public.gmane.org>
2018-08-06 13:24 ` Andy Shevchenko
[not found] ` <CAHp75VeprNMVniQ_KrQRU9v3kt4kxEnHYO+ds5pOYokvv=0YdQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-09-07 11:41 ` Yves-Alexis Perez
[not found] ` <6c62d06dee6572f7d03280ed9e9f6d7b7d9babf1.camel-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2018-09-07 17:59 ` Thomas Weißschuh [this message]
[not found] ` <4e387ece-dbf1-434b-8dde-18f0fa513d99-khTSGRnkC0s@public.gmane.org>
2018-09-07 21:25 ` Yves-Alexis Perez
[not found] ` <d91099a3353c6eb11ea9eaa5fa8409dc86f7f7ed.camel-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2018-09-07 21:37 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e387ece-dbf1-434b-8dde-18f0fa513d99@t-8ch.de \
--to=linux-9xfqokm5jgxkq7rde2t8pw@public.gmane.org \
--cc=andy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=corsac-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org \
--cc=dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=ibm-acpi-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org \
--cc=ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smclt30p-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox