From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD1DEC433ED for ; Wed, 7 Apr 2021 11:22:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 948C761369 for ; Wed, 7 Apr 2021 11:22:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234446AbhDGLXC (ORCPT ); Wed, 7 Apr 2021 07:23:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54619 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231138AbhDGLXB (ORCPT ); Wed, 7 Apr 2021 07:23:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617794572; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vi6mmAZvR34GygMPmuboiq8nvRacIFz1ApMzney+KHo=; b=aRtGHBm33t1ZgkMFNBllfDxY/p/ZtZbj9tg82bL6b/qzAwWumuGH2aAOJ+K9cVJpfjUXQj uQLWmOVadvIPjU/p4l9+GUcX74Njkhmi7ivAt6WqkpIYy03g7I+LylBkNf9cm1E99DVM1x bD9TCRoZDOMGv9AbSTDS0EOFutKQBwQ= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-dJfxYk1MOwyouTghJBp0gQ-1; Wed, 07 Apr 2021 07:22:50 -0400 X-MC-Unique: dJfxYk1MOwyouTghJBp0gQ-1 Received: by mail-ed1-f70.google.com with SMTP id w25so952168eds.16 for ; Wed, 07 Apr 2021 04:22:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Vi6mmAZvR34GygMPmuboiq8nvRacIFz1ApMzney+KHo=; b=gg7mSD+6bjwB+SdzkiVYIEYkRoiJ0znwGUeWpZvWdQcDfhQKmUVj2dOau+vBOkfvYS QM38yUpWP9c1IGOE22Cx868NpNOIHFzNDG5Zrc2hdxJYOZ1u1xsrIeSR21fRm3SN0c6r yTswxZL5MM7WTzJMT+9R0wx+qoFeK4OwXdcrkeJ1EZtKaPjaHWtmBUb3QJicLb09yhMu ++s25bw5N8CTL1bIj161xSzE5Jj+Kmq9Qd+Fa5omn0G0H5oeK1ZbDud+g6V5rYNr1ZMN vfD0ahThw5e5ZkZWw37Yfzm/7B0xMTMsl/QkDzgsl7dTOsxUZk7fxSlVFZ5+I8s0i7pr 0gaA== X-Gm-Message-State: AOAM531R2eCwXFM5BZlfDSAJWsSWR0++HC9rH4IT/Y8aRAULe/HD1rsn PGQYCxH4Ou98VbqyoOnvg1BNrowBVBZBBLm2iLt1J2GxkmFLYByjObLxy4B8zRKAXLBsXswEs3E 2ar/o/4VTMmFrUlPhDZiaa/BE6ZJWF7byfg== X-Received: by 2002:aa7:dc0b:: with SMTP id b11mr3839931edu.124.1617794569069; Wed, 07 Apr 2021 04:22:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLRW5PlDd6Dkn0bNfGdzeKg0oo5GGmVEYz0R4lD0wLLioxKvGHcePkwg9NHRv9JzoisN2JKg== X-Received: by 2002:aa7:dc0b:: with SMTP id b11mr3839910edu.124.1617794568897; Wed, 07 Apr 2021 04:22:48 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id jo12sm4465038ejb.52.2021.04.07.04.22.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Apr 2021 04:22:48 -0700 (PDT) Subject: Re: [PATCH v3] platform/x86: asus-wmi: Add param to turn fn-lock mode on by default To: Luca Stefani Cc: Corentin Chary , Mark Gross , acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210323202505.141496-1-luca.stefani.ge1@gmail.com> <20210323210126.145286-1-luca.stefani.ge1@gmail.com> From: Hans de Goede Message-ID: <4e816e9e-b35e-49ff-db91-82476fc4c9f7@redhat.com> Date: Wed, 7 Apr 2021 13:22:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210323210126.145286-1-luca.stefani.ge1@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 3/23/21 10:01 PM, Luca Stefani wrote: > * On recent ZenBooks the fn-lock is disabled > by default on boot while running Windows. > > * Add a module param ( fnlock_default ) that allows > changing the default at probe time > > Signed-off-by: Luca Stefani Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/asus-wmi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index 9ca15f724343..ebaeb7bb80f5 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -47,6 +47,9 @@ MODULE_AUTHOR("Corentin Chary , " > MODULE_DESCRIPTION("Asus Generic WMI Driver"); > MODULE_LICENSE("GPL"); > > +static bool fnlock_default = true; > +module_param(fnlock_default, bool, 0444); > + > #define to_asus_wmi_driver(pdrv) \ > (container_of((pdrv), struct asus_wmi_driver, platform_driver)) > > @@ -2673,7 +2676,7 @@ static int asus_wmi_add(struct platform_device *pdev) > err = asus_wmi_set_devstate(ASUS_WMI_DEVID_BACKLIGHT, 2, NULL); > > if (asus_wmi_has_fnlock_key(asus)) { > - asus->fnlock_locked = true; > + asus->fnlock_locked = fnlock_default; > asus_wmi_fnlock_update(asus); > } > >