From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org, Patil.Reddy@amd.com,
mario.limonciello@amd.com
Subject: Re: [PATCH v1 1/2] platform/x86/amd/pmf: Use existing input event codes to update system states
Date: Sat, 6 Jul 2024 19:58:10 +0530 [thread overview]
Message-ID: <4f0940ba-05ab-43aa-ad47-62495f687e96@amd.com> (raw)
In-Reply-To: <531d4d0a-9ba0-e67f-6f84-d11de1a0156e@linux.intel.com>
On 7/6/2024 18:39, Ilpo Järvinen wrote:
> On Tue, 2 Jul 2024, Shyam Sundar S K wrote:
>
>> At present, the PMF driver employs custom system state codes to update
>> system states. It is recommended to replace these with existing input
>
> This change entirely removes the way userspace worked before this change?
No. It's still the same way it worked like before; just that we are
removing an additional technical debt of maintaining a separate udev
rules file for kicking in the user-space action.
GNOME folks told that they cannot have a custom actions defined in
udev rules, instead asked to use KEY_SCREENLOCK, KEY_SLEEP,
and KEY_SUSPEND so it entirely matches the behavior.
> We cannot take userspace functionality away like this.
>
Can you please take a look at PATCH 2/2, that may help to clarify on
why PATCH 1/2 is required.
Thanks,
Shyam
next prev parent reply other threads:[~2024-07-06 14:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 8:06 [PATCH v1 1/2] platform/x86/amd/pmf: Use existing input event codes to update system states Shyam Sundar S K
2024-07-02 8:06 ` [PATCH v1 2/2] platform/x86/amd/pmf: Remove update system state document Shyam Sundar S K
2024-07-02 13:14 ` Mario Limonciello
2024-07-02 13:14 ` [PATCH v1 1/2] platform/x86/amd/pmf: Use existing input event codes to update system states Mario Limonciello
2024-07-06 13:09 ` Ilpo Järvinen
2024-07-06 14:28 ` Shyam Sundar S K [this message]
2024-07-10 8:43 ` Hans de Goede
2024-07-10 11:03 ` Ilpo Järvinen
2024-07-10 11:06 ` Ilpo Järvinen
2024-07-11 5:06 ` Shyam Sundar S K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f0940ba-05ab-43aa-ad47-62495f687e96@amd.com \
--to=shyam-sundar.s-k@amd.com \
--cc=Patil.Reddy@amd.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox