From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Xi Pardee <xi.pardee@linux.intel.com>
Cc: irenic.rajneesh@gmail.com, david.e.box@linux.intel.com,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] platform/x86/intel/pmc: Update NVLS PCDS LPM request GUID
Date: Tue, 21 Jul 2026 11:24:32 +0300 (EEST) [thread overview]
Message-ID: <4f188cff-9339-4677-c686-ff5f6f66b6f0@linux.intel.com> (raw)
In-Reply-To: <20260720231219.1278923-1-xi.pardee@linux.intel.com>
On Mon, 20 Jul 2026, Xi Pardee wrote:
> Now that NVL support is available, update the PCDS_LPM_REQ_GUID for
> Nova Lake S (NVLS) from 0x01091102 to 0x01091103. The PMC core driver
> requires the correct GUID to load successfully.
Hi,
You need to explain why this has to be changed. Preferrably so that it is
followable to anyone without inside knowledge.
> Signed-off-by: Xi Pardee <xi.pardee@linux.intel.com>
> ---
> drivers/platform/x86/intel/pmc/nvl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/pmc/nvl.c b/drivers/platform/x86/intel/pmc/nvl.c
> index 8dabf2511dd9d..1ed02332dbfce 100644
> --- a/drivers/platform/x86/intel/pmc/nvl.c
> +++ b/drivers/platform/x86/intel/pmc/nvl.c
> @@ -14,7 +14,7 @@
> /* PMC SSRAM PMT Telemetry GUIDS */
> #define PCDH_LPM_REQ_GUID 0x01093101
> #define PCHS_LPM_REQ_GUID 0x01092101
> -#define PCDS_LPM_REQ_GUID 0x01091102
> +#define PCDS_LPM_REQ_GUID 0x01091103
>
> /*
> * Die Mapping to Product.
>
--
i.
prev parent reply other threads:[~2026-07-21 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 23:12 [PATCH] platform/x86/intel/pmc: Update NVLS PCDS LPM request GUID Xi Pardee
2026-07-21 8:24 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f188cff-9339-4677-c686-ff5f6f66b6f0@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=irenic.rajneesh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=xi.pardee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox