From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Jencks Subject: thinkpad_acpi: unhandled HKEY event 0x6050 Date: Mon, 22 Apr 2013 15:25:25 -0400 Message-ID: <51758EA5.6030405@bjencks.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qc0-f169.google.com ([209.85.216.169]:48161 "EHLO mail-qc0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754756Ab3DVTZa (ORCPT ); Mon, 22 Apr 2013 15:25:30 -0400 Received: by mail-qc0-f169.google.com with SMTP id t2so2358478qcq.0 for ; Mon, 22 Apr 2013 12:25:29 -0700 (PDT) Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Henrique de Moraes Holschuh , Matthew Garrett , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org On a Thinkpad T530, BIOS 2.07: Event 0x6050 is generated when there's a brightness change generated by the firmware (not from the kernel through _BCM). This only happens when the ACPI video driver is not loaded, or acpi_backlight=vendor. (actually, when _BCL has not been called). It should probably be ignored, like TP_HKEY_EV_BRGHT_CHANGED (0x5010). Whether _BCL has been called is stored in variable \NBCF. ACPI dump is here: http://www.bjencks.net/t530/acpidump.out.xz The full logic in the firmware appears to be: When a brightness key is pressed: If the key is unmasked: Report the key to thinkpad-acpi If _BCL has been called: Report the key (video event) to acpi video Else: Adjust the brightness Report event 0x6050 to thinkpad-acpi This results in correct behavior when acpi video is loaded, since thinkpad-acpi automatically masks the brightness keys in that case. However, without acpi video the keys are unmasked, so keypresses generate two brightness changes -- one from the firmware and one from userspace. It seems like the brightness keys should always be masked on this type of firmware. -Ben Jencks