From: Kyle Evans <kvans32@gmail.com>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: Re: hp-wmi: SMBus hotkeys
Date: Sat, 11 May 2013 11:34:52 -0400 [thread overview]
Message-ID: <518E651C.9020700@gmail.com> (raw)
In-Reply-To: <1368046965.2425.34.camel@x230>
On 05/08/2013 05:02 PM, Matthew Garrett wrote:
> On Mon, 2013-05-06 at 12:57 -0400, Kyle Evans wrote:
>
>> So, what is the plan for this? We have the WMI method so that ec_write
>> is not needed, but how are you thinking it should be triggered? I've got
>> some free time coming up and would like to get this banged out during
>> that time if it is something I can do.
> Well, with luck this patch would be safe on its own. How did you figure
> out that you needed to set this register to this value?
>
Well, in the end I dumped the EC contents from windows several times and
compared the static values with those in the dump from linux. From your
reply I understand that you are thinking that register 0xe6 is not SFHK
on machines that the previous patch broke.... That sounds reasonable.
My concern was that SFHK required a different value on those machines,
but I am not at all familiar with common practice.
Just a note, I found several other registers with static, non-zero
values, which are zero in linux.
next prev parent reply other threads:[~2013-05-11 15:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 1:31 BUG: Fn keys not working on EliteBook 8460p after fabf85e3ca15d5b94058f391dac8df870cdd427a Pali Rohár
2013-04-13 1:35 ` Matthew Garrett
2013-04-13 12:36 ` Kyle Evans
2013-04-13 16:21 ` Matthew Garrett
2013-04-13 17:39 ` Kyle Evans
2013-04-13 17:42 ` Matthew Garrett
2013-04-16 16:26 ` Matthew Garrett
2013-04-17 13:56 ` Pali Rohár
2013-04-17 15:37 ` Kyle Evans
2013-04-17 17:59 ` Matthew Garrett
2013-04-17 18:55 ` Kyle Evans
2013-04-18 13:55 ` Kyle Evans
2013-04-18 15:58 ` Matthew Garrett
2013-04-18 16:48 ` Kyle Evans
2013-04-18 16:53 ` Matthew Garrett
2013-05-06 16:57 ` hp-wmi: SMBus hotkeys Kyle Evans
2013-05-08 21:02 ` Matthew Garrett
2013-05-11 15:34 ` Kyle Evans [this message]
2013-08-14 8:19 ` BUG: Again: Fn keys not working on EliteBook 8460p after b253c9d1d858a3f115f791ee4fe2b9399ae7dbbd Pali Rohár
2013-08-14 19:16 ` [PATCH] hp-wmi; Limit hotkey enable funtion Kyle Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518E651C.9020700@gmail.com \
--to=kvans32@gmail.com \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox