X86 platform drivers
 help / color / mirror / Atom feed
From: Oleksij Rempel <linux@rempel-privat.de>
To: joeyli <jlee@suse.com>
Cc: matthew.garrett@nebula.com, platform-driver-x86@vger.kernel.org,
	Aaron Lu <aaron.lu@intel.com>
Subject: Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572
Date: Wed, 01 Jan 2014 15:37:21 +0100	[thread overview]
Message-ID: <52C42821.3020801@rempel-privat.de> (raw)
In-Reply-To: <1388118336.3539.6055.camel@linux-s257.site>

[-- Attachment #1: Type: text/plain, Size: 1799 bytes --]

Am 27.12.2013 05:25, schrieb joeyli:
> Hi Oleksij, 
> 
> 於 五,2013-12-27 於 11:51 +0800,joeyli 提到:
>> Hi Oleksij, 
>>
>> 於 四,2013-12-05 於 14:00 +0100,Oleksij Rempel 提到:
>>> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
>>> ---
>>>  drivers/platform/x86/acer-wmi.c | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>>> index c9076bd..d5ca1648 100644
>>> --- a/drivers/platform/x86/acer-wmi.c
>>> +++ b/drivers/platform/x86/acer-wmi.c
>>> @@ -572,6 +572,14 @@ static const struct dmi_system_id video_vendor_dmi_table[] = {
>>>  			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5750"),
>>>  		},
>>>  	},
>>> +	{
>>> +		.callback = video_set_backlight_video_vendor,
>>> +		.ident = "Acer Aspire E1-572",
>>> +		.matches = {
>>> +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
>>> +			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire E1-572"),
>>> +		},
>>> +	},
>>>  	{}
>>>  };
>>>  
>>
>> I have applied this patch, build and load acer-wmi driver, didn't see
>> problem.
>>
>> Acked-by: Lee, Chun-Yi <jlee@suse.com>
>>
>>
>> Thanks for your patch!
>> Joey Lee
> 
> I just aware Aspire E1-572 shipped with Windows 8. Before merge this
> patch. Could you please try v3.13-rc5 kernel with
> video.use_native_backlight=1 kernel parameter?
> 
> Aaron Lu's "[PATCH v5 0/4] Fix Win8 backlight issue" merged to mainline
> in v3.13-rc1, his patches works to me on a Gateway Windows 8 notebook.
> 
> Please try it, if Aaron's patches works on E1-572, then we don't need
> this patch.

Hi,

suddenly i do not have access to this Laptops any more. It was a
purchase for a friend. I tested it, provided some patch and gave it away :(

-- 
Regards,
Oleksij


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]

  reply	other threads:[~2014-01-01 14:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-05 13:00 [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572 Oleksij Rempel
2013-12-27  3:51 ` joeyli
2013-12-27  4:25   ` joeyli
2014-01-01 14:37     ` Oleksij Rempel [this message]
2014-01-02 12:39       ` joeyli
2014-01-06 16:20         ` Oleksij Rempel
2014-01-09  7:06           ` joeyli
2014-01-09  8:11             ` Oleksij Rempel
2014-01-09  9:05               ` joeyli
2014-01-13  2:49                 ` Aaron Lu
2014-01-13  7:05                   ` joeyli
2014-01-13  7:09                     ` Aaron Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52C42821.3020801@rempel-privat.de \
    --to=linux@rempel-privat.de \
    --cc=aaron.lu@intel.com \
    --cc=jlee@suse.com \
    --cc=matthew.garrett@nebula.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox