Re: [PATCH 0/4] Add a workaround for Framework 13 spurious IRQ1

[Hans de Goede <hdegoede@redhat.com>]

Hi All,

On 12/12/23 21:19, Thomas Weißschuh wrote:
> On 2023-12-11 22:50:02-0600, Mario Limonciello wrote:
>> The 13" Framework laptop EC emits a spurious keyboard interrupt on every
>> resume from hardware sleep.  When a user closes the lid on an already
>> suspended system this causes the system to wake up.
>>
>> This series adjusts the previous Cezanne quirk (which has a much different
>> root cause) to be able to apply to other systems too. The Framework 13"
>> system is added to the list it will apply to.
>>
>> Mario Limonciello (4):
>>   platform/x86/amd/pmc: Move platform defines to header
>>   platform/x86/amd/pmc: Only run IRQ1 firmware version check on Cezanne
>>   platform/x86/amd/pmc: Move keyboard wakeup disablement detection to
>>     pmc-quirks
>>   platform/x86/amd/pmc: Disable keyboard wakeup on AMD Framework 13
>>
>>  drivers/platform/x86/amd/pmc/pmc-quirks.c | 20 ++++++++++++++
>>  drivers/platform/x86/amd/pmc/pmc.c        | 33 +++++++++--------------
>>  drivers/platform/x86/amd/pmc/pmc.h        | 12 +++++++++
>>  3 files changed, 45 insertions(+), 20 deletions(-)
> 
> For the full series:
> 
> Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>
> Tested-by: Thomas Weißschuh <linux@weissschuh.net> # on AMD Framework 13
> 
> The device now only wakes up when opening the lid.

Thomas, thank you for the review and testing.

The series looks good to me too:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Ilpo, do you plan on sending out one more fixes pull-req for 6.7
and if yes, can you add this series to that; or shall I merge
this into for-next so that it gets included in 6.8-rc1 ?

Regards,

Hans