From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Lutomirski Subject: Re: [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys Date: Fri, 20 Feb 2015 11:27:39 -0800 Message-ID: <54E78AAB.2020604@mit.edu> References: <1424443477.22910.18.camel@hadess.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f41.google.com ([209.85.220.41]:46749 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165AbbBTT1n (ORCPT ); Fri, 20 Feb 2015 14:27:43 -0500 Received: by pabkx10 with SMTP id kx10so10159795pab.13 for ; Fri, 20 Feb 2015 11:27:43 -0800 (PST) In-Reply-To: <1424443477.22910.18.camel@hadess.net> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Bastien Nocera , Henrique de Moraes Holschuh , Darren Hart , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Jiri Kosina On 02/20/2015 06:44 AM, Bastien Nocera wrote: > + KEY_MICCANCEL_MODE, /* Microphone cancellation */ What's this? We already have KEY_MICMUTE. Is this different? If so, can you improve the comment a bit? The answer may be obvious to anyone who has an awful X1 carbon gen 2 keyboard, but these KEY_XYZ defines should IMO be clear enough that even people without the hardware can figure out what's going on. --Andy