From: "Michał Szczepaniak" <m.szczepaniak.000@gmail.com>
To: ibm-acpi-devel@lists.sourceforge.net
Cc: hmh@hmh.eng.br, platform-driver-x86@vger.kernel.org
Subject: [ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: Fix a max_brightness of thinklight
Date: Sat, 8 Oct 2022 20:49:56 +0200 [thread overview]
Message-ID: <55400326-e64f-5444-94e5-22b8214d00b6@gmail.com> (raw)
Thinklight has only two values, on/off so it's reasonable for
max_brightness to be 0 and 1 as if you write anything between 0 and 255
it will be 255 anyway so there's no point for it to be 255.
Also sorry for repeated messages, I got no reply so I'm trying to figure
out what I did wrong.
---
drivers/platform/x86/thinkpad_acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 22d4e8633e30e9..775c2f327dc3a8 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -5562,6 +5562,7 @@ static enum led_brightness light_sysfs_get(struct
led_classdev *led_cdev)
static struct tpacpi_led_classdev tpacpi_led_thinklight = {
.led_classdev = {
.name = "tpacpi::thinklight",
+ .max_brightness = 1,
.brightness_set_blocking = &light_sysfs_set,
.brightness_get = &light_sysfs_get,
}
next reply other threads:[~2022-10-08 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 18:49 Michał Szczepaniak [this message]
2022-11-07 12:48 ` [ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: Fix a max_brightness of thinklight Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55400326-e64f-5444-94e5-22b8214d00b6@gmail.com \
--to=m.szczepaniak.000@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox