From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: "Matthew Garrett" <mjg59@srcf.ucam.org>,
"Darren Hart" <dvhart@infradead.org>,
"Michał Kępień" <kernel@kempniu.pl>,
"Andy Lutomirski" <luto@kernel.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Fixes for dell-wmi
Date: Sun, 27 Dec 2015 14:10:55 +0100 [thread overview]
Message-ID: <567FE35F.9060101@gmail.com> (raw)
In-Reply-To: <201512271407.47844@pali>
On 27/12/2015 14:07, Pali Rohár wrote:
> On Sunday 27 December 2015 13:59:57 Gabriele Mazzotta wrote:
>> On 24/12/2015 22:18, Pali Rohár wrote:
>>> This patch series adds check if Dell WMI descriptor structure is
>>> valid and fixes processing WMI events on devices with WMI
>>> interface version 0.
>>>
>>> After testing, second patch is good candidate for backporting into
>>> stable kernels, but problem is that it cannot be used without
>>> first patch. So I let decision to other people.
>>>
>>> Gabriele and Michał, this patch series should fix processing events
>>> on yours Dell laptops (you have in DSDT defined version 0). Can
>>> you test it?
>>
>> Hi,
>>
>> I tested the patches and all the function keys work, but I can see
>> that there are some differences in the dmesg.
>>
>> Here a before and after comparison.
>>
>> The radio button seems to generate longer messages when compared to
>> the others.
>
> Hi! Thanks for testing. Can you please recompile driver with line
> #define DEBUG at beginning of dell-wmi.c file and send dmesg output
> again? I want to see processing buffer debug lines in dmesg. Here we
> should see that after this patch series garbage will not be parsed.
I had to define DEBUG to get those lines.
dell_new_hk_type is false, so that's all I can get.
next prev parent reply other threads:[~2015-12-27 13:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 21:18 [PATCH 0/2] Fixes for dell-wmi Pali Rohár
2015-12-24 21:18 ` [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid Pali Rohár
2015-12-25 1:23 ` Andy Lutomirski
2015-12-25 13:02 ` Pali Rohár
2015-12-28 13:37 ` Michał Kępień
2015-12-28 14:08 ` Pali Rohár
2015-12-29 12:44 ` Michał Kępień
2015-12-29 16:05 ` Pali Rohár
2015-12-30 11:27 ` Michał Kępień
2016-01-04 18:23 ` Andy Lutomirski
2015-12-24 21:18 ` [PATCH 2/2] dell-wmi: Process only one event on devices with interface version 0 Pali Rohár
2015-12-28 13:40 ` Michał Kępień
2015-12-28 13:49 ` Pali Rohár
2015-12-27 12:59 ` [PATCH 0/2] Fixes for dell-wmi Gabriele Mazzotta
2015-12-27 13:07 ` Pali Rohár
2015-12-27 13:10 ` Gabriele Mazzotta [this message]
2015-12-27 13:17 ` Pali Rohár
2015-12-28 13:33 ` Michał Kępień
2015-12-28 13:46 ` Pali Rohár
2015-12-29 12:18 ` Michał Kępień
2016-01-04 20:48 ` Darren Hart
2016-01-07 22:31 ` Pali Rohár
2016-01-04 21:26 ` [PATCH v2 " Pali Rohár
2016-01-04 21:26 ` [PATCH v2 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid Pali Rohár
2016-01-04 21:26 ` [PATCH v2 2/2] dell-wmi: Process only one event on devices with interface version 0 Pali Rohár
2016-01-12 11:14 ` Michał Kępień
2016-01-12 17:49 ` Pali Rohár
2016-01-12 20:12 ` Michał Kępień
2016-01-14 23:06 ` Darren Hart
2016-01-11 19:22 ` [PATCH v2 0/2] Fixes for dell-wmi Darren Hart
2016-01-12 0:30 ` Gabriele Mazzotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567FE35F.9060101@gmail.com \
--to=gabriele.mzt@gmail.com \
--cc=dvhart@infradead.org \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox