X86 platform drivers
 help / color / mirror / Atom feed
From: "Éric Piel" <eric.piel@tremplin-utc.net>
To: Darren Hart <dvhart@infradead.org>,
	Martin Vajnar <martin.vajnar@gmail.com>
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] hp_accel: Add support for HP ProBook 440 G3
Date: Mon, 11 Apr 2016 23:06:53 +0200	[thread overview]
Message-ID: <570C11ED.4080002@tremplin-utc.net> (raw)
In-Reply-To: <20160410031042.GC18689@dvhart-mobl5.amr.corp.intel.com>

On 10-04-16 05:10, Darren Hart wrote:
> On Sat, Apr 02, 2016 at 08:11:13PM +0200, Martin Vajnar wrote:
>> HP ProBook 440 G3 laptop needs a non-standard mapping (x_inverted_usd).
>>
>> Signed-off-by: Martin Vajnar <martin.vajnar@gmail.com>
>
> Eric, this looks good to me. Any concerns?
Hi Darren, Martin,

Indeed it looks fine :-)

Here is my:
Acked-by: Éric Piel <eric.piel@tremplin-utc.net>

Darren, could you pick it up in your tree?

Thanks,
Éric

>
>> ---
>>   drivers/platform/x86/hp_accel.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c
>> index 10ce6cb..263002b 100644
>> --- a/drivers/platform/x86/hp_accel.c
>> +++ b/drivers/platform/x86/hp_accel.c
>> @@ -173,6 +173,7 @@ static int lis3lv02d_dmi_matched(const struct dmi_system_id *dmi)
>>   DEFINE_CONV(normal, 1, 2, 3);
>>   DEFINE_CONV(y_inverted, 1, -2, 3);
>>   DEFINE_CONV(x_inverted, -1, 2, 3);
>> +DEFINE_CONV(x_inverted_usd, -1, 2, -3);
>>   DEFINE_CONV(z_inverted, 1, 2, -3);
>>   DEFINE_CONV(xy_swap, 2, 1, 3);
>>   DEFINE_CONV(xy_rotated_left, -2, 1, 3);
>> @@ -236,6 +237,7 @@ static const struct dmi_system_id lis3lv02d_dmi_ids[] = {
>>   	AXIS_DMI_MATCH("HP8710", "HP Compaq 8710", y_inverted),
>>   	AXIS_DMI_MATCH("HDX18", "HP HDX 18", x_inverted),
>>   	AXIS_DMI_MATCH("HPB432x", "HP ProBook 432", xy_rotated_left),
>> +	AXIS_DMI_MATCH("HPB440G3", "HP ProBook 440 G3", x_inverted_usd),
>>   	AXIS_DMI_MATCH("HPB442x", "HP ProBook 442", xy_rotated_left),
>>   	AXIS_DMI_MATCH("HPB452x", "HP ProBook 452", y_inverted),
>>   	AXIS_DMI_MATCH("HPB522x", "HP ProBook 522", xy_swap),
>> --
>> 2.5.0
>>
>>
>

  reply	other threads:[~2016-04-11 21:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-02 18:11 [PATCH] hp_accel: Add support for HP ProBook 440 G3 Martin Vajnar
2016-04-10  3:10 ` Darren Hart
2016-04-11 21:06   ` Éric Piel [this message]
2016-04-15  3:31     ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570C11ED.4080002@tremplin-utc.net \
    --to=eric.piel@tremplin-utc.net \
    --cc=dvhart@infradead.org \
    --cc=martin.vajnar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox