From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yong, Jonathan" Subject: Re: [PATCH 2/2] x86: Fix Apollo Lake Watchdog address in PMC driver Date: Wed, 18 May 2016 12:48:33 +0800 Message-ID: <573BF421.2020503@intel.com> References: <1463541972-19758-1-git-send-email-jonathan.yong@intel.com> <1463541972-19758-3-git-send-email-jonathan.yong@intel.com> <573BE985.1000306@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com ([192.55.52.93]:61633 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbcEREsg (ORCPT ); Wed, 18 May 2016 00:48:36 -0400 In-Reply-To: <573BE985.1000306@roeck-us.net> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Guenter Roeck , linux-watchdog@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: qipeng.zha@intel.com On 05/18/2016 12:03, Guenter Roeck wrote: > On 05/17/2016 08:26 PM, Yong, Jonathan wrote: >> The TCO I/O base is 40h rather than the usual 30h, and the >> re_reboot bit is at ACPIBASE+8. >> > > Does this mean that the code never worked, or in other words that it > was never tested, or are there now other chips which used the old > definitions which no longer work after this patch has been applied ? To my knowledge, it has never worked since 30h is claimed by ACPI GPE0_BLK. With this patch, watchdog ioctl is working properly with WDIOC_SETTIMEOUT, WDIOC_GETTIMEOUT and WDIOC_GETTIMELEFT as expected.