X86 platform drivers
 help / color / mirror / Atom feed
From: Jan-Marek Glogowski <glogow@fbihome.de>
To: "Michał Kępień" <kernel@kempniu.pl>
Cc: Jonathan Woithe <jwoithe@just42.net>,
	platform-driver-x86@vger.kernel.org
Subject: Re: Brightness and "touchpad dis-/enable" keys not working for Fujitsu e7x6
Date: Thu, 23 Jun 2016 15:42:30 +0200	[thread overview]
Message-ID: <576BE746.2010504@fbihome.de> (raw)
In-Reply-To: <20160623133146.GA4558@eudyptula.hq.kempniu.pl>

Am 23.06.2016 um 15:31 schrieb Michał Kępień:
>>> First I figured out (using a command almost identical to the one I
>>> suggested to you) which GPE is used for signalling brightness-related
>>> key presses on my Haswell machine.  This immediately led me to ACPI
>>> method _L11.  I selectively commented out ACPI code from this method,
>>> recompiling and overriding it using /sys/kernel/debug/acpi/custom_method
>>> after every change until I figured out exactly which method invocation
>>> causes the key events to be generated.  Once I knew that, I searched for
>>> a similar invocation in a Skylake DSDT dump.  This led me to ACPI method
>>> _L21, which is very similar to Haswell's _L11.
>>
>> Thanks for this info. I guess I can also debug the "disable touchpad"
>> button with this method.
> 
> If that button is supposed to be handled by ACPI, then yes, this should
> help.

I'm not sure if it's supposed to be handled by ACPI and not completely
in HW, like in the Haswell line, but I get Notify events for the fujitsu
driver.

>> I'm currently to recompiling my Ubuntu kernel, as it doesn't set
>> CONFIG_ACPI_CUSTOM_METHOD
> 
> Right, you are going to need that.
> 
>> Reading _L21, there are quite a few calls to Notify (\_SB.FEXT, 0x80),
>> which is exactly the notify function for the Fujitsu ACPI device.
>>
>> Actually there are a few more GPEs, which emit Notify (\_SB.FEXT, 0x80)
>> calls, which are caught by the fujitsu-notebook driver.
>>
>>>>> If it does, try overriding ACPI method _L21 [3] so that you can read
>>>>> the value of BSWF when the method is invoked.
>>
>> What's the easiest way to report the value to userspace? I don't think I
>> can add variables.
>>
>> My idea was to add a Notify (\_SB.FEXT, 0x80) into the BSWF branch, and
>> remove the Notify calls from all other branches.
>>
>> Probably even start by removing all Notify calls to be sure the function
>> actually is overwritten.
> 
> Just use the ACPI debug object.  Everything you need is in the
> documentation I have already referred you to (method-customizing.txt).

Ups. Sorry - too much parallel stuff going on today.
I'll really read the document and not just skim through it (which I did
after realizing my kernel misses the needed modules.

> I would simply use the original _L21 method with a "Store (BSWF, Debug)"
> line inserted just before the "If (BSWF)" conditional expression.

Yup.

Regards,

Jan-Marek

  reply	other threads:[~2016-06-23 13:42 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14  8:48 Brightness and "touchpad dis-/enable" keys not working for Fujitsu e7x6 Jan-Marek Glogowski
2016-06-16 23:46 ` Jonathan Woithe
2016-06-17  9:20   ` Jan-Marek Glogowski
2016-06-21  8:12     ` Jonathan Woithe
2016-06-22  7:32       ` Michał Kępień
2016-06-22 10:18         ` Jan-Marek Glogowski
2016-06-22 10:53           ` Jonathan Woithe
2016-06-22 11:23             ` Jan-Marek Glogowski
2016-06-22 12:39               ` Michał Kępień
2016-06-22 13:22                 ` Jan-Marek Glogowski
2016-06-23 11:18                   ` Michał Kępień
2016-06-23 12:08                     ` Jan-Marek Glogowski
2016-06-23 12:35                       ` Michał Kępień
2016-06-23 13:17                         ` Jan-Marek Glogowski
2016-06-23 13:31                           ` Michał Kępień
2016-06-23 13:42                             ` Jan-Marek Glogowski [this message]
2016-06-23 17:23                         ` Jan-Marek Glogowski
2016-06-24  7:12                           ` Michał Kępień
2016-06-24  9:22                             ` Jan-Marek Glogowski
2016-06-24 10:20                               ` Michał Kępień
2016-06-24 11:39                                 ` Jan-Marek Glogowski
2016-06-24 15:43                                 ` Jan-Marek Glogowski
2016-06-24 20:17                                   ` Michał Kępień
2016-06-25  8:50                                     ` Jonathan Woithe
2016-06-25  9:15                                       ` Michał Kępień
2016-06-26  7:41                                         ` [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Michał Kępień
2016-06-27  8:03                                           ` [PATCH] Register KEY_TOUCHPAD_TOGGLE with input device Jan-Marek Glogowski
2016-06-27 12:48                                           ` [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Jonathan Woithe
2016-06-27 12:55                                             ` Michał Kępień
2016-06-27 13:19                                             ` [PATCH v2] " Michał Kępień
2016-06-28  1:06                                               ` Jonathan Woithe
2016-06-28  7:25                                                 ` [PATCH v3] " Michał Kępień
2016-06-28 11:19                                                   ` Jonathan Woithe
2016-06-28 17:50                                                     ` Darren Hart
2016-06-27  8:32                                         ` Brightness and "touchpad dis-/enable" keys not working for Fujitsu e7x6 Jan-Marek Glogowski
2016-06-27 11:16                                           ` Michał Kępień
2016-06-27 11:40                                             ` Jan-Marek Glogowski
2016-06-27 12:40                                               ` Jonathan Woithe
2016-06-29 13:59                                           ` Jani Nikula
2016-06-29 15:38                                             ` Jani Nikula
2016-06-22 10:46         ` Jonathan Woithe
2016-06-23 10:02   ` [PATCH 0/2] fujitsu-laptop: Debugging cleanup Michał Kępień
2016-06-23 10:02     ` [PATCH 1/2] fujitsu-laptop: Use module name in debug messages Michał Kępień
2016-06-23 10:02     ` [PATCH 2/2] fujitsu-laptop: Remove unused macros Michał Kępień
2016-06-23 10:35     ` [PATCH 0/2] fujitsu-laptop: Debugging cleanup Jonathan Woithe
2016-06-28 17:49       ` Darren Hart
2016-06-22  7:15 ` Brightness and "touchpad dis-/enable" keys not working for Fujitsu e7x6 Michał Kępień
2016-06-22 10:07   ` Jan-Marek Glogowski
2016-06-22 11:31     ` Michał Kępień

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576BE746.2010504@fbihome.de \
    --to=glogow@fbihome.de \
    --cc=jwoithe@just42.net \
    --cc=kernel@kempniu.pl \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox