X86 platform drivers
 help / color / mirror / Atom feed
From: Evgenii Shatokhin <eugene.shatokhin@yandex.ru>
To: Alex Hung <alex.hung@canonical.com>,
	dvhart@infradead.org, platform-driver-x86@vger.kernel.org,
	david.ward@ll.mit.edu
Subject: Re: [PATCH] hp-wmi: fix wifi cannot be hard-unblock
Date: Tue, 28 Jun 2016 14:32:23 +0300	[thread overview]
Message-ID: <57726047.6070209@yandex.ru> (raw)
In-Reply-To: <1465818240-11994-1-git-send-email-alex.hung@canonical.com>

On 13.06.2016 14:44, Alex Hung wrote:
> Several users reported wifi cannot be unblocked as discussed in [1].
> This patch removes the useof 2009 flag by BIOS but uses the actual WMI
> function calls - it will be skipped if WMI reports unsupported
>
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=69131
>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   drivers/platform/x86/hp-wmi.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
> index 6f145f2..96ffda4 100644
> --- a/drivers/platform/x86/hp-wmi.c
> +++ b/drivers/platform/x86/hp-wmi.c
> @@ -718,6 +718,11 @@ static int __init hp_wmi_rfkill_setup(struct platform_device *device)
>   	if (err)
>   		return err;
>
> +	err = hp_wmi_perform_query(HPWMI_WIRELESS_QUERY, 1, &wireless,
> +				   sizeof(wireless), 0);
> +	if (err)
> +		return err;
> +
>   	if (wireless & 0x1) {
>   		wifi_rfkill = rfkill_alloc("hp-wifi", &device->dev,
>   					   RFKILL_TYPE_WLAN,
> @@ -882,7 +887,7 @@ static int __init hp_wmi_bios_setup(struct platform_device *device)
>   	wwan_rfkill = NULL;
>   	rfkill2_count = 0;
>
> -	if (hp_wmi_bios_2009_later() || hp_wmi_rfkill_setup(device))
> +	if (hp_wmi_rfkill_setup(device))
>   		hp_wmi_rfkill2_setup(device);
>
>   	err = device_create_file(&device->dev, &dev_attr_display);
>

I checked this patch with kernels 4.1.19 - 4.1.25 on HP EliteBook 6930p 
where the problem was spotted earlier. The patch does fix the problem 
for me.

Tested-by: Evgenii Shatokhin <eugene.shatokhin@yandex.ru>

Regards,
Evgenii

  reply	other threads:[~2016-06-28 11:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13 11:44 [PATCH] hp-wmi: fix wifi cannot be hard-unblock Alex Hung
2016-06-28 11:32 ` Evgenii Shatokhin [this message]
2016-06-28 16:04   ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57726047.6070209@yandex.ru \
    --to=eugene.shatokhin@yandex.ru \
    --cc=alex.hung@canonical.com \
    --cc=david.ward@ll.mit.edu \
    --cc=dvhart@infradead.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox