From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35D9E81730 for ; Mon, 3 Jun 2024 09:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717407848; cv=none; b=PyG1kaVF9p1s9Tw2xx0mmmWJCloiyUneBFMmJnwMZg1uJj3q67J0IRL2O/ZgZPis+gjzEPBoeDLUjjN/HPAMx3apJoTqAJI7VYUNsvWCaqCr5nH79Bz8Xn9glF0A2yjdhi1UT+BvDrKhqm9rNzjaFVcUcNOn8gFi5G/YQYu7Am8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717407848; c=relaxed/simple; bh=nM8uSllZ7RbY1J691S8kJGCcalGOytS3CRH3nRriecg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NEcbDDdm3rGiRuFc9lgTUJGDqzA2D8TTACxsFakL1K/vpO99vMY1Y+nvde4jI+EV2CkbsgvBfSVN2fYAzcv8b85hNBbaaNlFa2XGYSgvNR468trt+hj6AxEEQeJhOL1uteGAFyNi23aZZKF1q5CJzBnOxOAee6cuWP6bgvfLTpg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OyHee177; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OyHee177" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717407846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UNeEzqEwDLFqI3mQx5TerVCCfIrf8PlxwIfB2OPQ4fg=; b=OyHee1773yt9Qa1gi+hLypUGmZDtTjAc6VkRPL+Np30wEgj6JkNxsGWHkLG98tpe3c6mZf hZaVnKD65U4gDGbnRtXxoN8UXAQkc7gSOj8sAHlUGQmwClGScM4pCouwC7lOGnqdQtR+ED HprlOLvBNC93+UtOR751yQnSjSdcksw= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-599-aKuvQbtbOrmquBcFDxJCYw-1; Mon, 03 Jun 2024 05:44:04 -0400 X-MC-Unique: aKuvQbtbOrmquBcFDxJCYw-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a68b4937c43so109615366b.2 for ; Mon, 03 Jun 2024 02:44:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717407843; x=1718012643; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UNeEzqEwDLFqI3mQx5TerVCCfIrf8PlxwIfB2OPQ4fg=; b=mBCy5KUJV7pFRxvKVFYZh6fmMzxGs/5f0rxyh41wy8t9FrZVd3P0wJ+139bI0lkW+B uaJ68fPqCp+be7cmwVthdt9ViOKT2SgNDuFjKSO+t8GOzI39X/H0Pf3lI682JjpE+Nyu vAC8ZqJqCyNMVGpQE3mJ9/nJJe03lDn94JO2/JQxBppq6L5FqyJEUk2RiuSBjcybZysP /n840YZ8TLLd0cFXcsHiwCQhTssytj0Xjn+hhrvs45vw/5miP3pH1tdaIags7M2saRXG M+PdBHLdDTFI7Zt/yvELtAvfk0B44tdbVIZxvOGXCppU9BTjTBaRZ6h746N7dbuAdwox mOvA== X-Forwarded-Encrypted: i=1; AJvYcCUT72kVJobDfo+9FWr9BXL3TztH1Z/idJGvHRuQ3AcJ2M2+KQLihzzFTPfTWKgtA3coRFYJt5QPyD72hMR71nDwSxb8H1mymC3l8Sa49Hxj/Tg/PA== X-Gm-Message-State: AOJu0YzmZsGOTOkMkZ92QDEao+7upHeSBDw+Y5CqInIeK37RaqFywSFX x4tuqhwo99tyTbGypUUYRD17b3XhceluZm4iS5o/kcZBPHt+9MPD8FU0vaoLVdzZ5Xb99yxnlhz DdGoMmb9nrRGgHi1tRjkz+qQ3OCvLRCVDN3sDON6ZrIAHgw6kQs1UIsYjny4CL4porAyjAFo= X-Received: by 2002:a17:906:1b5b:b0:a68:c672:9ea9 with SMTP id a640c23a62f3a-a68c672a238mr327571066b.28.1717407842983; Mon, 03 Jun 2024 02:44:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHL2jVRaMVe/2bPmtGU7yX8A5bJtJXVMPpIgslWnfKfooeBA8Go5dQoxUgh1LEK+9vpH589DQ== X-Received: by 2002:a17:906:1b5b:b0:a68:c672:9ea9 with SMTP id a640c23a62f3a-a68c672a238mr327570166b.28.1717407842605; Mon, 03 Jun 2024 02:44:02 -0700 (PDT) Received: from [10.40.98.157] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a68cf23c63esm265077366b.5.2024.06.03.02.44.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jun 2024 02:44:02 -0700 (PDT) Message-ID: <577cc35e-00c6-4893-b917-d3f44bf19191@redhat.com> Date: Mon, 3 Jun 2024 11:44:01 +0200 Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform/x86: yt2-1380: add CONFIG_EXTCON dependency To: Arnd Bergmann , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: Arnd Bergmann , Armin Wolf , SungHwan Jung , Henning Schild , Ai Chao , Robert Joslyn , Heiner Kallweit , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240528115940.3169455-1-arnd@kernel.org> Content-Language: en-US From: Hans de Goede In-Reply-To: <20240528115940.3169455-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 5/28/24 1:59 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > This driver uses the extcon subsystem and fails to build > when it cannot call into that subsystem: > > x86_64-linux-ld: vmlinux.o: in function `yt2_1380_fc_worker': > lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9d819): undefined reference to `extcon_get_state' > x86_64-linux-ld: lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9d853): undefined reference to `extcon_get_state' > x86_64-linux-ld: vmlinux.o: in function `yt2_1380_fc_serdev_probe': > lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9da22): undefined reference to `extcon_get_extcon_dev' > x86_64-linux-ld: lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9dc0c): undefined reference to `devm_extcon_register_notifier_all' > > Add a Kconfig dependency to make it it always builds correctly. > > Fixes: b2ed33e8d486 ("platform/x86: Add lenovo-yoga-tab2-pro-1380-fastcharger driver") > Signed-off-by: Arnd Bergmann Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > --- > drivers/platform/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 809888e4c1e7..9f850e4617bf 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -136,6 +136,7 @@ config YOGABOOK > config YT2_1380 > tristate "Lenovo Yoga Tablet 2 1380 fast charge driver" > depends on SERIAL_DEV_BUS > + depends on EXTCON > depends on ACPI > help > Say Y here to enable support for the custom fast charging protocol