Re: [PATCH v4 2/3] platform/x86/amd/pmf: Use devm_mutex_init() for mutex initialization

[Mario Limonciello <superm1@kernel.org>]

On 11/19/25 2:58 AM, Shyam Sundar S K wrote:
> Replace mutex_init() with the devm_mutex_init(), to ensure proper mutex
> cleanup during probe failure and driver removal.
> 
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>> ---
> v4:
>   - New patch spinned off from v3
> 
>   drivers/platform/x86/amd/pmf/core.c | 17 +++++++++++------
>   1 file changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c
> index bc544a4a5266..2ec4cb92e34f 100644
> --- a/drivers/platform/x86/amd/pmf/core.c
> +++ b/drivers/platform/x86/amd/pmf/core.c
> @@ -465,9 +465,17 @@ static int amd_pmf_probe(struct platform_device *pdev)
>   	if (!dev->regbase)
>   		return -ENOMEM;
>   
> -	mutex_init(&dev->lock);
> -	mutex_init(&dev->update_mutex);
> -	mutex_init(&dev->cb_mutex);
> +	err = devm_mutex_init(dev->dev, &dev->lock);
> +	if (err)
> +		return err;
> +
> +	err = devm_mutex_init(dev->dev, &dev->update_mutex);
> +	if (err)
> +		return err;
> +
> +	err = devm_mutex_init(dev->dev, &dev->cb_mutex);
> +	if (err)
> +		return err;
>   
>   	apmf_acpi_init(dev);
>   	platform_set_drvdata(pdev, dev);
> @@ -491,9 +499,6 @@ static void amd_pmf_remove(struct platform_device *pdev)
>   		amd_pmf_notify_sbios_heartbeat_event_v2(dev, ON_UNLOAD);
>   	apmf_acpi_deinit(dev);
>   	amd_pmf_dbgfs_unregister(dev);
> -	mutex_destroy(&dev->lock);
> -	mutex_destroy(&dev->update_mutex);
> -	mutex_destroy(&dev->cb_mutex);
>   }
>   
>   static const struct attribute_group *amd_pmf_driver_groups[] = {