From: "Mario Limonciello (AMD) (kernel.org)" <superm1@kernel.org>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org, Patil.Reddy@amd.com
Subject: Re: [PATCH 1/2] platform/x86/amd/pmf: Rename ipu fields to npu in smu_pmf_metrics_v2 structure
Date: Fri, 19 Sep 2025 09:06:49 -0500 [thread overview]
Message-ID: <59b6952f-32ec-45a5-9576-a046c0d9ed0e@kernel.org> (raw)
In-Reply-To: <20250919055425.3055817-1-Shyam-sundar.S-k@amd.com>
On 9/19/2025 12:54 AM, Shyam Sundar S K wrote:
> Rename multiple fields in the struct smu_pmf_metrics_v2 from "ipu" to "npu"
> to align with updated hardware terminology and enhance code clarity.
>
> Co-developed-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
> Signed-off-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>> ---
> Hi Ilpo, this can be applied on origin/review-ilpo-next with git tip commit
> "8236b4667aca"
>
> drivers/platform/x86/amd/pmf/pmf.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h
> index bd19f2a6bc78..6ea5380f3b23 100644
> --- a/drivers/platform/x86/amd/pmf/pmf.h
> +++ b/drivers/platform/x86/amd/pmf/pmf.h
> @@ -243,12 +243,12 @@ struct smu_pmf_metrics_v2 {
> u16 vclk_freq; /* MHz */
> u16 vcn_activity; /* VCN busy % [0-100] */
> u16 vpeclk_freq; /* MHz */
> - u16 ipuclk_freq; /* MHz */
> - u16 ipu_busy[8]; /* NPU busy % [0-100] */
> + u16 npuclk_freq; /* MHz */
> + u16 npu_busy[8]; /* NPU busy % [0-100] */
> u16 dram_reads; /* MB/sec */
> u16 dram_writes; /* MB/sec */
> u16 core_c0residency[16]; /* C0 residency % [0-100] */
> - u16 ipu_power; /* mW */
> + u16 npu_power; /* mW */
> u32 apu_power; /* mW */
> u32 gfx_power; /* mW */
> u32 dgpu_power; /* mW */
> @@ -257,9 +257,9 @@ struct smu_pmf_metrics_v2 {
> u32 filter_alpha_value; /* time constant [us] */
> u32 metrics_counter;
> u16 memclk_freq; /* MHz */
> - u16 mpipuclk_freq; /* MHz */
> - u16 ipu_reads; /* MB/sec */
> - u16 ipu_writes; /* MB/sec */
> + u16 mpnpuclk_freq; /* MHz */
> + u16 npu_reads; /* MB/sec */
> + u16 npu_writes; /* MB/sec */
> u32 throttle_residency_prochot;
> u32 throttle_residency_spl;
> u32 throttle_residency_fppt;
prev parent reply other threads:[~2025-09-19 14:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 5:54 [PATCH 1/2] platform/x86/amd/pmf: Rename ipu fields to npu in smu_pmf_metrics_v2 structure Shyam Sundar S K
2025-09-19 5:54 ` [PATCH 2/2] platform/x86/amd/pmf: Introduce new interface to export NPU metrics Shyam Sundar S K
2025-09-19 14:21 ` Mario Limonciello
2025-09-22 16:07 ` Shyam Sundar S K
2025-09-22 16:19 ` Mario Limonciello (AMD) (kernel.org)
2025-09-19 20:26 ` Lizhi Hou
2025-09-22 16:08 ` Shyam Sundar S K
2025-09-19 14:06 ` Mario Limonciello (AMD) (kernel.org) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59b6952f-32ec-45a5-9576-a046c0d9ed0e@kernel.org \
--to=superm1@kernel.org \
--cc=Patil.Reddy@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).